FAILED: patch "[PATCH] counter: 104-quad-8: Fix skipped IRQ lines during events" failed to apply to 5.19-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Possible dependencies:
2bc54aaa65d2 ("counter: 104-quad-8: Fix skipped IRQ lines during events configuration") daae1ee572d1 ("counter: 104-quad-8: Implement and utilize register structures") b6e9cded90d4 ("counter: 104-quad-8: Utilize iomap interface")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 2bc54aaa65d2126ae629919175708a28ce7ef06e Mon Sep 17 00:00:00 2001
From: William Breathitt Gray <[email protected]>
Date: Thu, 22 Sep 2022 07:20:56 -0400
Subject: [PATCH] counter: 104-quad-8: Fix skipped IRQ lines during events
configuration
IRQ trigger configuration is skipped if it has already been set before; however, the IRQ line still needs to be OR'd to irq_enabled because irq_enabled is reset for every events_configure call. This patch moves the irq_enabled OR operation update to before the irq_trigger check so that IRQ line enablement is not skipped.
drivers/counter/104-quad-8.c +3 -3
@@ -449,6 +449,9 @@ static int quad8_events_configure(struct counter_device *counter)return -EINVAL ; } +/* Enable IRQ line */ + irq_enabled |=BIT (event_node->channel); +/* Skip configuration if it is the same as previously set */ if (priv->irq_trigger[event_node->channel] == next_irq_trigger)continue ;
@@ -462,9 +465,6 @@ static int quad8_events_configure(struct counter_device *counter) priv->irq_trigger[event_node->channel] <<3 ;iowrite8 (QUAD8_CTR_IOR | ior_cfg, &priv->reg->channel[event_node->channel].control); - -/* Enable IRQ line */ - irq_enabled |=BIT (event_node->channel); }iowrite8 (irq_enabled, &priv->reg->index_interrupt);