pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm
Subsystems (2)
PATCH v3 1/1 pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm
From: xinlei lee <[email protected]>
In the original mtk_disp_pwm_get_state() function, the result of reading con0 & BIT(0) is enabled as disp_pwm.
In order to conform to the register table, we should use the disp_pwm base address as the enabled judgment.
---
Base on the branch of Linux-next/master.
change since v2:
1. Modify the code for readability.
change since v1:
1. Modify the way to set disp_pwm enbale.
---
--- drivers/pwm/pwm-mtk-disp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pwm/pwm-mtk-disp.c +3 -2
@@ -178,7 +178,7 @@ static void mtk_disp_pwm_get_state(struct pwm_chip *chip, {struct mtk_disp_pwm *mdp =to_mtk_disp_pwm (chip);u64 rate, period, high_width; -u32 clk_div, con0, con1; +u32 clk_div, pwm_en, con0, con1;int err; err =clk_prepare_enable (mdp->clk_main);
@@ -197,7 +197,8 @@ static void mtk_disp_pwm_get_state(struct pwm_chip *chip, rate =clk_get_rate (mdp->clk_main); con0 =readl (mdp->base + mdp->data->con0); con1 =readl (mdp->base + mdp->data->con1); - state->enabled = !!(con0 &BIT (0 )); + pwm_en =readl (mdp->base +DISP_PWM_EN ); + state->enabled = !!(pwm_en & mdp->data->enable_mask); clk_div =FIELD_GET (PWM_CLKDIV_MASK , con0); period =FIELD_GET (PWM_PERIOD_MASK , con1);/*
Signature · 1 line
2.18.0
Hello,
Quoted 6 lines · On Thu, Sep 29, 2022 at 06:26:49PM +0800, [email protected] wrote:
From: xinlei lee <[email protected]>
In the original
mtk_disp_pwm_get_state()function, the result of reading con0 & BIT(0) is enabled asdisp_pwm.
In order to conform to the register table, we should use thedisp_pwmbase address as the enabled judgment.
I assume the change is fine. However I don't understand the commit log. My guess is you mean:
mtk_disp_pwm_get_state() wrongly uses bit 0 of CON0 to judge if the PWM is enabled. However that is indicated by a bit (at a machine dependent position) in the DISP_PWM_EN register. Fix this accordingly.
Quoted 3 lines
Fixes 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")Signed-off-by xinlei lee <[email protected]>
Nitpick: There is no empty line between Fixes: and S-o-b.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 27 lines · Uwe Kleine-König
Hello,
Quoted 8 lines · On Thu, Sep 29, 2022 at 06:26:49PM +0800, [email protected] wrote:
From: xinlei lee <[email protected]>
In the original
mtk_disp_pwm_get_state()function, the result of reading
con0 & BIT(0) is enabled asdisp_pwm.
In order to conform to the register table, we should use thedisp_pwm
base address as the enabled judgment.I assume the change is fine. However I don't understand the commit log.
My guess is you mean:
mtk_disp_pwm_get_state()wrongly uses bit 0 of CON0 to judge if
the
PWM is enabled. However that is indicated by a bit (at a
machine
dependent position) in theDISP_PWM_ENregister. Fix this accordingly.Quoted 3 lines
Fixes 3f2b16734914 ("pwm: mtk-disp: Implement atomic API.get_state()")
Quoted 7 lines
Quoted 1 line
Signed-off-by xinlei lee <[email protected]>Nitpick: There is no empty line between Fixes: and S-o-b.
Best regards
Uwe
Hi Uwe:
Yes, as you describe, I will remove the blank lines you mentioned in the next version.
Best Regards!
xinlei