ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
Subsystems (2)
PATCH 1/1 ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
The correct binding is "micrel,led-mode", not "led-mode".
This corrects an error which was introduced when setting of ethernet PHY LED mode was added by 82e62182d59bd1d0 ("ARM: shmobile: lager: Set ethernet PHY LED mode").
This makes the lager code consistent with the koelsch code which was added by ae00d12a032490b3 ("ARM: shmobile: koelsch: Set ethernet PHY LED mode").
---
* This is compile tested only (which is of negligible value) as I do not have physical access to a Lager board.
--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
@@ -213,7 +213,7 @@ reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - led-mode = <1>; + micrel,led-mode = <1>; }; };
Signature · 1 line
1.8.5.2
PATCH 1/1 ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
Hi Simon,
Quoted 5 lines · On Tuesday 08 April 2014 09:21:35 Simon Horman wrote:
The correct binding is "micrel,led-mode", not "led-mode".
This corrects an error which was introduced when setting of ethernet PHY LED mode was added by
82e62182d59bd1d0("ARM: shmobile: lager: Set ethernet PHY LED mode").
Indeed. I wonder how I've missed that... :-( Sorry.
Quoted 5 lines
This makes the lager code consistent with the koelsch code which was added by
ae00d12a032490b3("ARM: shmobile: koelsch: Set ethernet PHY LED mode").Cc Laurent Pinchart <[email protected]>Signed-off-by Simon Horman <[email protected]>
Quoted 20 lines
---
* This is compile tested only (which is of negligible value) as I do not have physical access to a Lager board.
--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/r8a7790-lager.dtsindex a55c5f8..265cba1 100644arch/arm/boot/dts/r8a7790-lager.dts +1
-1@@ -213,7 +213,7 @@ reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - led-mode = <1>; + micrel,led-mode = <1>; }; };
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
Quoted 10 lines · Laurent Pinchart
Hi Simon,
Quoted 5 lines · On Tuesday 08 April 2014 09:21:35 Simon Horman wrote:
The correct binding is "micrel,led-mode", not "led-mode".
This corrects an error which was introduced when setting of ethernet PHY LED mode was added by
82e62182d59bd1d0("ARM: shmobile: lager: Set ethernet PHY LED mode").Indeed. I wonder how I've missed that... :-( Sorry.
Thanks, I have queued this up.
Quoted 35 lines
Quoted 6 lines
This makes the lager code consistent with the koelsch code which was added by
ae00d12a032490b3("ARM: shmobile: koelsch: Set ethernet PHY LED mode").Cc Laurent Pinchart <[email protected]>Signed-off-by Simon Horman <[email protected]>Acked-by Laurent Pinchart <[email protected]>Quoted 20 lines
---
* This is compile tested only (which is of negligible value) as I do not have physical access to a Lager board.
--- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/r8a7790-lager.dtsindex a55c5f8..265cba1 100644arch/arm/boot/dts/r8a7790-lager.dts +1
-1@@ -213,7 +213,7 @@ reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - led-mode = <1>; + micrel,led-mode = <1>; }; };Signature · 3 lines
Regards, Laurent Pinchart