WTF: patch "[PATCH] scsi: qla2xxx: Define static symbols" was seriously submitted to be applied to the 6.0-stable tree?
Subsystems (3)
[email protected]
maintainerThe patch below was submitted to be applied to the 6.0-stable tree.
I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.
I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 2c57d0defa22b2339c06364a275bcc9048a77255 Mon Sep 17 00:00:00 2001
From: Nilesh Javali <[email protected]>
Date: Fri, 26 Aug 2022 03:25:58 -0700
Subject: [PATCH] scsi: qla2xxx: Define static symbols
drivers/scsi/qla2xxx/qla_os.c:40:20: warning: symbol 'qla_trc_array' was not declared. Should it be static? drivers/scsi/qla2xxx/qla_os.c:345:5: warning: symbol 'ql2xdelay_before_pci_error_handling' was not declared. Should it be static?
Define qla_trc_array and ql2xdelay_before_pci_error_handling as static to fix sparse warnings.
drivers/scsi/qla2xxx/qla_os.c +2 -2
@@ -37,7 +37,7 @@ static int apidev_major;*/ struct kmem_cache *srb_cachep; -struct trace_array *qla_trc_array; +static struct trace_array *qla_trc_array;int ql2xfulldump_on_mpifail;module_param (ql2xfulldump_on_mpifail, int,S_IRUGO |S_IWUSR );
@@ -342,7 +342,7 @@ MODULE_PARM_DESC(ql2xabts_wait_nvme, "To wait for ABTS response on I/O timeouts for NVMe. (default: 1)"); -u32 ql2xdelay_before_pci_error_handling =5 ; +static u32 ql2xdelay_before_pci_error_handling =5 ;module_param (ql2xdelay_before_pci_error_handling, uint,0644 );MODULE_PARM_DESC (ql2xdelay_before_pci_error_handling,"Number of seconds delayed before qla begin PCI error self-handling (default: 5).\n" );