dt-bindings: mmc: arm,pl18x: Document interrupt-names is ignored
PATCH v2 1/3 dt-bindings: mmc: arm,pl18x: Document interrupt-names is ignored
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add deprecated:false to interrupts: description
--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +3 -1
@@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: false minItems: 1 maxItems: 2
Signature · 1 line
2.35.1
PATCH v2 2/3 ARM: dts: qcom: Drop MMCI interrupt-names
The pl18x MMCI driver does not use the interrupt-names property, the binding document has been updated to recommend this property be unused, remove it.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add RB from Linus
--- arch/arm/boot/dts/qcom-apq8064.dtsi | 3 --- arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 -- arch/arm/boot/dts/qcom-mdm9615.dtsi | 2 -- arch/arm/boot/dts/qcom-msm8660.dtsi | 5 ----- arch/arm/boot/dts/qcom-msm8960.dtsi | 2 -- 5 files changed, 14 deletions(-)
arch/arm/boot/dts/qcom-apq8064.dtsi +0 -3
@@ -1129,7 +1129,6 @@ sdcc1: mmc@12400000 { arm,primecell-periphid = <0x00051180>; reg = <0x12400000 0x2000>; interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -1147,7 +1146,6 @@ sdcc3: mmc@12180000 { status = "disabled"; reg = <0x12180000 0x2000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC3_CLK>, <&gcc SDC3_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
@@ -1165,7 +1163,6 @@ sdcc4: mmc@121c0000 { status = "disabled"; reg = <0x121c0000 0x2000>; interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC4_CLK>, <&gcc SDC4_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
arch/arm/boot/dts/qcom-ipq8064.dtsi +0 -2
@@ -728,7 +728,6 @@ sdcc3: mmc@12180000 { status = "disabled"; reg = <0x12180000 0x2000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC3_CLK>, <&gcc SDC3_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -748,7 +747,6 @@ sdcc1: mmc@12400000 { arm,primecell-periphid = <0x00051180>; reg = <0x12400000 0x2000>; interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
arch/arm/boot/dts/qcom-mdm9615.dtsi +0 -2
@@ -362,7 +362,6 @@ sdcc1: mmc@12180000 { arm,primecell-periphid = <0x00051180>; reg = <0x12180000 0x2000>; interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -382,7 +381,6 @@ sdcc2: mmc@12140000 { status = "disabled"; reg = <0x12140000 0x2000>; interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
arch/arm/boot/dts/qcom-msm8660.dtsi +0 -5
@@ -549,7 +549,6 @@ sdcc1: mmc@12400000 { arm,primecell-periphid = <0x00051180>; reg = <0x12400000 0x8000>; interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -565,7 +564,6 @@ sdcc2: mmc@12140000 { arm,primecell-periphid = <0x00051180>; reg = <0x12140000 0x8000>; interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -580,7 +578,6 @@ sdcc3: mmc@12180000 { status = "disabled"; reg = <0x12180000 0x8000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC3_CLK>, <&gcc SDC3_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
@@ -596,7 +593,6 @@ sdcc4: mmc@121c0000 { status = "disabled"; reg = <0x121c0000 0x8000>; interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC4_CLK>, <&gcc SDC4_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
@@ -611,7 +607,6 @@ sdcc5: mmc@12200000 { status = "disabled"; reg = <0x12200000 0x8000>; interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC5_CLK>, <&gcc SDC5_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
arch/arm/boot/dts/qcom-msm8960.dtsi +0 -2
@@ -308,7 +308,6 @@ sdcc1: mmc@12400000 { arm,primecell-periphid = <0x00051180>; reg = <0x12400000 0x8000>; interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <8>;
@@ -325,7 +324,6 @@ sdcc3: mmc@12180000 { status = "disabled"; reg = <0x12180000 0x8000>; interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&gcc SDC3_CLK>, <&gcc SDC3_H_CLK>; clock-names = "mclk", "apb_pclk"; bus-width = <4>;
Signature · 1 line
2.35.1
PATCH v2 3/3 ARM: dts: stm32: Drop MMCI interrupt-names
In reply to Marek VasutThe pl18x MMCI driver does not use the interrupt-names property, the binding document has been updated to recommend this property be unused, remove it.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add RB from Linus and Yann
--- arch/arm/boot/dts/stm32h743.dtsi | 2 -- arch/arm/boot/dts/stm32mp131.dtsi | 2 -- arch/arm/boot/dts/stm32mp151.dtsi | 3 --- 3 files changed, 7 deletions(-)
arch/arm/boot/dts/stm32h743.dtsi +0 -2
@@ -375,7 +375,6 @@ sdmmc1: mmc@52007000 { arm,primecell-periphid = <0x10153180>; reg = <0x52007000 0x1000>; interrupts = <49>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC1_CK>; clock-names = "apb_pclk"; resets = <&rcc STM32H7_AHB3_RESET(SDMMC1)>;
@@ -389,7 +388,6 @@ sdmmc2: mmc@48022400 { arm,primecell-periphid = <0x10153180>; reg = <0x48022400 0x400>; interrupts = <124>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC2_CK>; clock-names = "apb_pclk"; resets = <&rcc STM32H7_AHB2_RESET(SDMMC2)>;
arch/arm/boot/dts/stm32mp131.dtsi +0 -2
@@ -356,7 +356,6 @@ sdmmc1: mmc@58005000 { arm,primecell-periphid = <0x20253180>; reg = <0x58005000 0x1000>, <0x58006000 0x1000>; interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC1_K>; clock-names = "apb_pclk"; resets = <&rcc SDMMC1_R>;
@@ -371,7 +370,6 @@ sdmmc2: mmc@58007000 { arm,primecell-periphid = <0x20253180>; reg = <0x58007000 0x1000>, <0x58008000 0x1000>; interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC2_K>; clock-names = "apb_pclk"; resets = <&rcc SDMMC2_R>;
arch/arm/boot/dts/stm32mp151.dtsi +0 -3
@@ -1118,7 +1118,6 @@ sdmmc3: mmc@48004000 { arm,primecell-periphid = <0x00253180>; reg = <0x48004000 0x400>; interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC3_K>; clock-names = "apb_pclk"; resets = <&rcc SDMMC3_R>;
@@ -1439,7 +1438,6 @@ sdmmc1: mmc@58005000 { arm,primecell-periphid = <0x00253180>; reg = <0x58005000 0x1000>; interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC1_K>; clock-names = "apb_pclk"; resets = <&rcc SDMMC1_R>;
@@ -1454,7 +1452,6 @@ sdmmc2: mmc@58007000 { arm,primecell-periphid = <0x00253180>; reg = <0x58007000 0x1000>; interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "cmd_irq"; clocks = <&rcc SDMMC2_K>; clock-names = "apb_pclk"; resets = <&rcc SDMMC2_R>;
Signature · 1 line
2.35.1
Alexandre TORGUE
maintainerRe: [PATCH v2 3/3] ARM: dts: stm32: Drop MMCI interrupt-names
Quoted 24 lines · Marek Vasut
The pl18x MMCI driver does not use the interrupt-names property, the binding document has been updated to recommend this property be unused, remove it.
Reviewed-by Linus Walleij <[email protected]>Reviewed-by Yann Gautier <[email protected]>Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add RB from Linus and Yann
Quoted 6 lines
--- arch/arm/boot/dts/stm32h743.dtsi | 2 -- arch/arm/boot/dts/stm32mp131.dtsi | 2 -- arch/arm/boot/dts/stm32mp151.dtsi | 3 --- 3 files changed, 7 deletions(-)
Applied on stm32-next.
Cheers
Alex
Quoted 22 lines · Marek Vasut
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add deprecated:false to interrupts: description
Quoted 4 lines
--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 31 lines · Marek Vasut
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add deprecated:false to interrupts: description--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +0
-0
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml properties: · line 100
Quoted 7 lines
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +3
-1@@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: false
Why do you add deprecated false? All properties are not deprecated by default. Did any other referenced schema make it deprecated?
Best regards,
Krzysztof
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Marek Vasut
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add deprecated:false to interrupts: description--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 15 lines
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml properties: · line 100
Quoted 12 lines
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +3
-1@@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: falseWhy do you add deprecated false? All properties are not deprecated by default. Did any other referenced schema make it deprecated?
Rob asked me to add it in V1 .
Quoted 20 lines · Marek Vasut
Quoted 4 lines
Quoted 4 lines
--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Quoted 15 lines
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml properties: · line 100
Quoted 12 lines
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +3
-1@@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: falseWhy do you add deprecated false? All properties are not deprecated by default. Did any other referenced schema make it deprecated?
Quoted 1 line
Rob asked me to add it in V1 .
Indeed, thanks.
Best regards,
Krzysztof
Quoted 6 lines · Marek Vasut
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
Signed-off-by Marek Vasut <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 37 lines
---
Cc: Alexandre Torgue <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Yann Gautier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]
---
V2: Add deprecated:false to interrupts: description--- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +3
-2@@ -95,7 +95,9 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. + deprecated: false minItems: 1 maxItems: 2 --
Quoted 2 lines
2.35.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Bjorn Andersson
AppliedRe: (subset) [PATCH v2 1/3] dt-bindings: mmc: arm,pl18x: Document interrupt-names is ignored
In reply to Marek VasutQuoted 5 lines · Marek Vasut
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings.
Applied, thanks!
[2/3] ARM: dts: qcom: Drop MMCI interrupt-names
commit: 2f7fa366bac9aa2addb83ffa5f208291f4dbe4d8
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>