net: phy: dp83867: Extend RX strap quirk for SGMII mode
Subsystems (3)
PATCH v2 1/1 net: phy: dp83867: Extend RX strap quirk for SGMII mode
When RX strap in HW is not set to MODE 3 or 4, bit 7 and 8 in CF4 register should be set. The former is already handled in dp83867_config_init; add the latter in SGMII specific initialization.
--- drivers/net/phy/dp83867.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/net/phy/dp83867.c +8 -0
@@ -853,6 +853,14 @@ static int dp83867_config_init(struct phy_device *phydev)else val &= ~DP83867_SGMII_TYPE ;phy_write_mmd (phydev,DP83867_DEVADDR ,DP83867_SGMIICTL , val); + +/* This is a SW workaround for link instability if RX_CTRL is +* not strapped to mode 3 or 4 in HW. This is required for SGMII +* in addition to clearing bit 7, handled above. +*/ +if (dp83867->rxctrl_strap_quirk) +phy_set_bits_mmd (phydev,DP83867_DEVADDR ,DP83867_CFG4 , +BIT (8 )); } val =phy_read (phydev,DP83867_CFG3 );
Signature · 1 line
2.17.1
Quoted 6 lines · Harini Katakam
When RX strap in HW is not set to MODE 3 or 4, bit 7 and 8 in CF4 register should be set. The former is already handled in
dp83867_config_init; add the latter in SGMII specific initialization.Fixes 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")Signed-off-by Harini Katakam <[email protected]>
Please see the netdev FAQ. You are supposed to put the tree this patch is for in the subject line, [PATCH net v2] ... etc. Please remember this for next time.
Andrew
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 14 Oct 2022 12:17:35 +0530 you wrote:
When RX strap in HW is not set to MODE 3 or 4, bit 7 and 8 in CF4 register should be set. The former is already handled in
dp83867_config_init; add the latter in SGMII specific initialization.Fixes 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")Signed-off-by Harini Katakam <[email protected]>[...]
Here is the summary with links:
- [v2] net: phy: dp83867: Extend RX strap quirk for SGMII mode
https://git.kernel.org/netdev/net/c/0c9efbd5c50c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html