Skip to contentSkip to conversation

platform/chrome: cros_hps_i2c: make remove callback return void

PATCH Applied Dan Callaghan 2 participants 3 messages Oct 18, 2022 – Oct 19, 2022

Subsystems (3)
lore
Share & tools
lore

Dan Callaghan

author maintainer
#0 lore raw

PATCH 1/1 platform/chrome: cros_hps_i2c: make remove callback return void

Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed the return type of the 'remove' callback to void, but this driver was originally written before that change landed. Update the remove callback to match.

Fixes 5f9952548d91 ("platform/chrome: add a driver for HPS")
---
 drivers/platform/chrome/cros_hps_i2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/platform/chrome/cros_hps_i2c.c +1 -3
index 92da59d94745..62ccb1acb5de 100644
@@ -95,7 +95,7 @@ static int hps_i2c_probe(struct i2c_client *client)
 	return 0;
 }
 
-static int hps_i2c_remove(struct i2c_client *client)
+static void hps_i2c_remove(struct i2c_client *client)
 {
 	struct hps_drvdata *hps = i2c_get_clientdata(client);
 
@@ -107,8 +107,6 @@ static int hps_i2c_remove(struct i2c_client *client)
 	 * (i.e. powered on).
 	 */
 	hps_set_power(hps, true);
-
-	return 0;
 }
 
 static int hps_suspend(struct device *dev)

base-commit: c7e2618e12562ba6f9d230d8ed4257dfa94d2d9d

Signature · 1 line
2.38.0.413.g74048e4d9e-goog
#1 lore raw
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Wed, 19 Oct 2022 10:52:37 +1100 you wrote:

Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed the return type of the 'remove' callback to void, but this driver was originally written before that change landed. Update the remove callback to match.

Fixes 5f9952548d91 ("platform/chrome: add a driver for HPS")

[...]

Here is the summary with links:
- platform/chrome: cros_hps_i2c: make remove callback return void

    https://git.kernel.org/chrome-platform/c/d8cb88f1541f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
In reply to Dan Callaghan
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Wed, 19 Oct 2022 10:52:37 +1100 you wrote:

Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed the return type of the 'remove' callback to void, but this driver was originally written before that change landed. Update the remove callback to match.

Fixes 5f9952548d91 ("platform/chrome: add a driver for HPS")

[...]

Here is the summary with links:
- platform/chrome: cros_hps_i2c: make remove callback return void

    https://git.kernel.org/chrome-platform/c/d8cb88f1541f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html