net: macb: Specify PHY PM management done by MAC
Subsystems (3)
PATCH v2 1/1 net: macb: Specify PHY PM management done by MAC
The macb_resume/macb_suspend methods already call the phylink_start/phylink_stop methods during their execution so explicitly say that the PM of the PHY is done by MAC by using the mac_managed_pm flag of the struct phylink_config.
This also fixes the warning message issued during resume:
WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148
Depends-on: 96de900ae78e ("net: phylink: add mac_managed_pm in phylink_config structure")
---
v1 -> v2:
- Add Depends-on: tag
drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/cadence/macb_main.c +1 -0
@@ -806,6 +806,7 @@ static int macb_mii_probe(struct net_device *dev) bp->phylink_config.dev = &dev->dev; bp->phylink_config.type =PHYLINK_NETDEV ; + bp->phylink_config.mac_managed_pm = true;if (bp->phy_interface ==PHY_INTERFACE_MODE_SGMII ) { bp->phylink_config.poll_fixed_state = true;
Signature · 1 line
2.34.1
Quoted 11 lines · Sergiu Moga
The
macb_resume/macb_suspendmethods already call thephylink_start/phylink_stopmethods during their execution so explicitly say that the PM of the PHY is done by MAC by using themac_managed_pmflag of thestruct phylink_config.This also fixes the warning message issued during resume:
WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148Depends-on:
96de900ae78e("net: phylink: addmac_managed_pminphylink_configstructure")Fixes 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")Signed-off-by Sergiu Moga <[email protected]>
Makes me realize we need to do the same in DSA, I will cook a patch soon.
Signature · 1 line
Florian
Quoted 11 lines · Sergiu Moga
The
macb_resume/macb_suspendmethods already call thephylink_start/phylink_stopmethods during their execution so explicitly say that the PM of the PHY is done by MAC by using themac_managed_pmflag of thestruct phylink_config.This also fixes the warning message issued during resume:
WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148Depends-on:
96de900ae78e("net: phylink: addmac_managed_pminphylink_configstructure")Fixes 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")Signed-off-by Sergiu Moga <[email protected]>
Quoted 22 lines
---
v1 -> v2:
- Add Depends-on: tagdrivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/cadence/macb_main.c +1
-0@@ -806,6 +806,7 @@ static int macb_mii_probe(struct net_device *dev) bp->phylink_config.dev = &dev->dev; bp->phylink_config.type =PHYLINK_NETDEV ; + bp->phylink_config.mac_managed_pm = true;if (bp->phy_interface ==PHY_INTERFACE_MODE_SGMII ) { bp->phylink_config.poll_fixed_state = true;
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 19 Oct 2022 15:09:32 +0300 you wrote:
The
macb_resume/macb_suspendmethods already call thephylink_start/phylink_stopmethods during their execution so explicitly say that the PM of the PHY is done by MAC by using themac_managed_pmflag of thestruct phylink_config.This also fixes the warning message issued during resume:
WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148[...]
Here is the summary with links:
- [v2] net: macb: Specify PHY PM management done by MAC
https://git.kernel.org/netdev/net/c/15a9dbec631c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html