net: remove useless parameter of __sock_cmsg_send
Subsystems (4)
PATCH v2 1/1 net: remove useless parameter of __sock_cmsg_send
From: xu xin <[email protected]>
The parameter 'msg' has never been used by __sock_cmsg_send, so we can remove it safely.
Reported-by Zeal Robot <[email protected]>
Signed-off-by xu xin <[email protected]>
Reviewed-by Zhang Yunkai <[email protected]>
---v1->v2:
fix the title and commit log.
--- include/net/sock.h | 2 +- net/core/sock.c | 4 ++-- net/ipv4/ip_sockglue.c | 2 +- net/ipv6/datagram.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
include/net/sock.h +1 -1
@@ -1901,7 +1901,7 @@ static inline void sockcm_init(struct sockcm_cookie *sockc, *sockc = (struct sockcm_cookie ) { .tsflags = sk->sk_tsflags }; } -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc);int sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct sockcm_cookie *sockc);
net/core/sock.c +2 -2
@@ -2730,7 +2730,7 @@ struct sk_buff *sock_alloc_send_pskb(struct sock *sk, unsigned long header_len, }EXPORT_SYMBOL (sock_alloc_send_pskb); -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc) {u32 tsflags;
@@ -2784,7 +2784,7 @@ int sock_cmsg_send(struct sock *sk, struct msghdr *msg,return -EINVAL ;if (cmsg->cmsg_level !=SOL_SOCKET )continue ; - ret =__sock_cmsg_send (sk, msg, cmsg, sockc); + ret =__sock_cmsg_send (sk, cmsg, sockc);if (ret)return ret; }
net/ipv4/ip_sockglue.c +1 -1
@@ -267,7 +267,7 @@ int ip_cmsg_send(struct sock *sk, struct msghdr *msg, struct ipcm_cookie *ipc, }#endif if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc->sockc);if (err)return err;continue ;
net/ipv6/datagram.c +1 -1
@@ -771,7 +771,7 @@ int ip6_datagram_send_ctl(struct net *net, struct sock *sk, }if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc6->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc6->sockc);if (err)return err;continue ;
Signature · 1 line
2.25.1
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 11 lines · On Thu, 20 Oct 2022 06:54:41 +0000 you wrote:
From: xu xin <[email protected]>
The parameter 'msg' has never been used by
__sock_cmsg_send, so we can remove it safely.Reported-by Zeal Robot <[email protected]>Signed-off-by xu xin <[email protected]>Reviewed-by Zhang Yunkai <[email protected]>[...]
Here is the summary with links:
- [PATCHv2,linux-next] net: remove useless parameter of __sock_cmsg_send
https://git.kernel.org/netdev/net-next/c/233baf9a1bc4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html