Skip to contentSkip to conversation

bna: remove variable num_entries

PATCH Applied Colin Ian King 2 participants 2 messages Oct 24, 2022 – Oct 26, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bna: remove variable num_entries

Variable num_entries is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/net/ethernet/brocade/bna/bfa_msgq.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/brocade/bna/bfa_msgq.c +0 -2
index 47125f419530..fa40d5ec6f1c 100644
@@ -202,7 +202,6 @@ static void
 __cmd_copy(struct bfa_msgq_cmdq *cmdq, struct bfa_msgq_cmd_entry *cmd)
 {
 	size_t len = cmd->msg_size;
-	int num_entries = 0;
 	size_t to_copy;
 	u8 *src, *dst;
 
@@ -219,7 +218,6 @@ __cmd_copy(struct bfa_msgq_cmdq *cmdq, struct bfa_msgq_cmd_entry *cmd)
 		BFA_MSGQ_INDX_ADD(cmdq->producer_index, 1, cmdq->depth);
 		dst = (u8 *)cmdq->addr.kva;
 		dst += (cmdq->producer_index * BFI_MSGQ_CMD_ENTRY_SIZE);
-		num_entries++;
 	}
 
 }
Signature · 1 line
2.37.3
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 24 Oct 2022 13:59:51 +0100 you wrote:

Variable num_entries is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/net/ethernet/brocade/bna/bfa_msgq.c | 2 --
 1 file changed, 2 deletions(-)

Here is the summary with links:
- bna: remove variable num_entries

    https://git.kernel.org/netdev/net-next/c/bb214ac47e0a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html