Skip to contentSkip to conversation

net: dl2k: remove variable tx_use

PATCH Applied Colin Ian King 2 participants 2 messages Oct 24, 2022 – Oct 26, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dl2k: remove variable tx_use

Variable tx_use is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/net/ethernet/dlink/dl2k.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/dlink/dl2k.c +0 -2
index 2c67a857a42f..db6615aa921b 100644
@@ -814,7 +814,6 @@ rio_free_tx (struct net_device *dev, int irq)
 {
 	struct netdev_private *np = netdev_priv(dev);
 	int entry = np->old_tx % TX_RING_SIZE;
-	int tx_use = 0;
 	unsigned long flag = 0;
 
 	if (irq)
@@ -839,7 +838,6 @@ rio_free_tx (struct net_device *dev, int irq)
 
 		np->tx_skbuff[entry] = NULL;
 		entry = (entry + 1) % TX_RING_SIZE;
-		tx_use++;
 	}
 	if (irq)
 		spin_unlock(&np->tx_lock);
Signature · 1 line
2.37.3
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 24 Oct 2022 15:35:01 +0100 you wrote:

Variable tx_use is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/net/ethernet/dlink/dl2k.c | 2 --
 1 file changed, 2 deletions(-)

Here is the summary with links:
- net: dl2k: remove variable tx_use

    https://git.kernel.org/netdev/net-next/c/d0217284cea7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html