Skip to contentSkip to conversation

net/rds: remove variable total_copied

PATCH Applied Colin Ian King 2 participants 2 messages Oct 24, 2022 – Oct 27, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/rds: remove variable total_copied

Variable total_copied is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 net/rds/message.c | 2 --
 1 file changed, 2 deletions(-)
net/rds/message.c +0 -2
index 44dbc612ef54..b47e4f0a1639 100644
@@ -366,7 +366,6 @@ static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *
 	struct scatterlist *sg;
 	int ret = 0;
 	int length = iov_iter_count(from);
-	int total_copied = 0;
 	struct rds_msg_zcopy_info *info;
 
 	rm->m_inc.i_hdr.h_len = cpu_to_be32(iov_iter_count(from));
@@ -404,7 +403,6 @@ static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *
 			ret = -EFAULT;
 			goto err;
 		}
-		total_copied += copied;
 		length -= copied;
 		sg_set_page(sg, pages, copied, start);
 		rm->data.op_nents++;
Signature · 1 line
2.37.3
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 24 Oct 2022 14:50:46 +0100 you wrote:

Variable total_copied is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 net/rds/message.c | 2 --
 1 file changed, 2 deletions(-)

Here is the summary with links:
- net/rds: remove variable total_copied

    https://git.kernel.org/netdev/net-next/c/b65ef50e0647

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html