Skip to contentSkip to conversation

net: remove unusged netdev_unregistering()

PATCH Applied Juhee Kang 2 participants 2 messages Oct 27, 2022 – Oct 31, 2022

Subsystems (2)
lore
Share & tools
lore

Juhee Kang

author
#0 lore raw

PATCH v3 1/1 net: remove unusged netdev_unregistering()

Currently, use dev->reg_state == NETREG_UNREGISTERING to check the status which is NETREG_UNREGISTERING, rather than using netdev_unregistering. Also, A helper function which is netdev_unregistering on nedevice.h is no longer used. Thus, netdev_unregistering removes from netdevice.h.

---
v3:
- v2 link : https://lore.kernel.org/netdev/[email protected]/
- Apply review. Write commit message more specific.

v2:
- v1 link : https://lore.kernel.org/netdev/[email protected]/
- Apply review. Remove netdev_unregistering().

v1:
- Replace open code which is dev->reg_state == NETREG_UNREGISTERING to netdev_unregistering() helper function.

 include/linux/netdevice.h | 5 -----
 1 file changed, 5 deletions(-)
include/linux/netdevice.h +0 -5
index eddf8ee270e7..99e58b773266 100644
@@ -5101,11 +5101,6 @@ static inline const char *netdev_name(const struct net_device *dev)
 	return dev->name;
 }
 
-static inline bool netdev_unregistering(const struct net_device *dev)
-{
-	return dev->reg_state == NETREG_UNREGISTERING;
-}
-
 static inline const char *netdev_reg_state(const struct net_device *dev)
 {
 	switch (dev->reg_state) {
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 28 Oct 2022 01:04:24 +0900 you wrote:

Currently, use dev->reg_state == NETREG_UNREGISTERING to check the status which is NETREG_UNREGISTERING, rather than using netdev_unregistering. Also, A helper function which is netdev_unregistering on nedevice.h is no longer used. Thus, netdev_unregistering removes from netdevice.h.

[...]

Here is the summary with links:
- [net-next,v3] net: remove unusged netdev_unregistering()

    https://git.kernel.org/netdev/net-next/c/f3fb589aeb88

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html