net: sched: Fix use after free in red_enqueue()
Subsystems (4)
PATCH 1/1 net: sched: Fix use after free in red_enqueue()
We can't use "skb" again after passing it to qdisc_enqueue(). This is basically identical to commit 2f09707d0c97 ("sch_sfb: Also store skb len before calling child enqueue").
---
Applies to net.
net/sched/sch_red.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/sched/sch_red.c +3 -1
@@ -72,6 +72,7 @@ static int red_enqueue(struct sk_buff *skb, struct Qdisc *sch, {struct red_sched_data *q =qdisc_priv (sch);struct Qdisc *child = q->qdisc; +unsigned int len;int ret; q->vars.qavg = red_calc_qavg(&q->parms,
@@ -126,9 +127,10 @@ static int red_enqueue(struct sk_buff *skb, struct Qdisc *sch,break ; } + len =qdisc_pkt_len (skb); ret =qdisc_enqueue (skb, child, to_free);if (likely (ret ==NET_XMIT_SUCCESS )) { -qdisc_qstats_backlog_inc (sch, skb); + sch->qstats.backlog += len; sch->q.qlen++; }else if (net_xmit_drop_count (ret)) { q->stats.pdrop++;
Signature · 1 line
2.35.1
Quoted 6 lines · Dan Carpenter
We can't use "skb" again after passing it to
qdisc_enqueue(). This is basically identical to commit2f09707d0c97("sch_sfb: Also store skb len before calling child enqueue").Fixes d7f4f332f082 ("sch_red: update backlog as well")
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 28 Oct 2022 18:05:00 +0300 you wrote:
We can't use "skb" again after passing it to
qdisc_enqueue(). This is basically identical to commit2f09707d0c97("sch_sfb: Also store skb len before calling child enqueue").Fixes d7f4f332f082 ("sch_red: update backlog as well")Signed-off-by Dan Carpenter <[email protected]>[...]
Here is the summary with links:
- [net] net: sched: Fix use after free in red_enqueue()
https://git.kernel.org/netdev/net/c/8bdc2acd420c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html