Skip to contentSkip to conversation

Bluetooth: Use kzalloc instead of kmalloc/memset

PATCH Applied Kang Minchul 3 participants 3 messages Oct 30, 2022 – Oct 31, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Bluetooth: Use kzalloc instead of kmalloc/memset

Replace kmalloc+memset by kzalloc
for better readability and simplicity.

This addresses the cocci warning below:

WARNING: kzalloc should be used for d, instead of kmalloc/memset

---
 net/bluetooth/hci_conn.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
net/bluetooth/hci_conn.c +2 -4
index 7a59c4487050..287d313aa312 100644
@@ -824,11 +824,10 @@ static int hci_le_terminate_big(struct hci_dev *hdev, u8 big, u8 bis)
 
 	bt_dev_dbg(hdev, "big 0x%2.2x bis 0x%2.2x", big, bis);
 
-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;
 
-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->bis = bis;
 
@@ -861,11 +860,10 @@ static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, u16 sync_handle)
 
 	bt_dev_dbg(hdev, "big 0x%2.2x sync_handle 0x%4.4x", big, sync_handle);
 
-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;
 
-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->sync_handle = sync_handle;
 
Signature · 1 line
2.34.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690281

---Test result---

Test Summary:

CheckPatch                    PASS      1.65 seconds
GitLint                       PASS      1.00 seconds
SubjectPrefix                 PASS      0.89 seconds
BuildKernel                   PASS      34.67 seconds
BuildKernel32                 PASS      31.46 seconds
Incremental Build with patchesPASS      48.47 seconds
TestRunner: Setup             PASS      523.11 seconds
TestRunner: l2cap-tester      PASS      17.60 seconds
TestRunner: iso-tester        PASS      16.99 seconds
TestRunner: bnep-tester       PASS      6.77 seconds
TestRunner: mgmt-tester       PASS      108.06 seconds
TestRunner: rfcomm-tester     PASS      10.56 seconds
TestRunner: sco-tester        PASS      10.04 seconds
TestRunner: ioctl-tester      PASS      11.28 seconds
TestRunner: mesh-tester       PASS      8.28 seconds
TestRunner: smp-tester        PASS      10.09 seconds
TestRunner: userchan-tester   PASS      6.97 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kang Minchul
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Mon, 31 Oct 2022 03:17:22 +0900 you wrote:

Replace kmalloc+memset by kzalloc
for better readability and simplicity.

This addresses the cocci warning below:

WARNING: kzalloc should be used for d, instead of kmalloc/memset

[...]

Here is the summary with links:
- [v3] Bluetooth: Use kzalloc instead of kmalloc/memset

    https://git.kernel.org/bluetooth/bluetooth-next/c/214c507d87cc

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html