Skip to contentSkip to conversation

rds: remove redundant variable total_payload_len

PATCH Applied Colin Ian King 2 participants 2 messages Nov 1, 2022 – Nov 4, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rds: remove redundant variable total_payload_len

Variable total_payload_len is being used to accumulate payload lengths however it is never read or used afterwards. It is redundant and can be removed.

---
 net/rds/send.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
net/rds/send.c +1 -2
index 0c5504068e3c..5e57a1581dc6 100644
@@ -1114,7 +1114,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
 	struct rds_conn_path *cpath;
 	struct in6_addr daddr;
 	__u32 scope_id = 0;
-	size_t total_payload_len = payload_len, rdma_payload_len = 0;
+	size_t rdma_payload_len = 0;
 	bool zcopy = ((msg->msg_flags & MSG_ZEROCOPY) &&
 		      sock_flag(rds_rs_to_sk(rs), SOCK_ZEROCOPY));
 	int num_sgs = DIV_ROUND_UP(payload_len, PAGE_SIZE);
@@ -1243,7 +1243,6 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
 	if (ret)
 		goto out;
 
-	total_payload_len += rdma_payload_len;
 	if (max_t(size_t, payload_len, rdma_payload_len) > RDS_MAX_MSG_SIZE) {
 		ret = -EMSGSIZE;
 		goto out;
Signature · 1 line
2.37.3
#1 lore raw
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 8 lines · On Tue, 1 Nov 2022 10:41:04 +0000 you wrote:

Variable total_payload_len is being used to accumulate payload lengths however it is never read or used afterwards. It is redundant and can be removed.

---
 net/rds/send.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
- rds: remove redundant variable total_payload_len

    https://git.kernel.org/netdev/net-next/c/d28c0e73efbe

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html