Generate device tree node for pci devices
Subsystems (2)
v3 cover Generate device tree node for pci devices
This patch series introduces OF overlay support for PCI devices which primarily addresses two use cases. First, it provides a data driven method to describe hardware peripherals that are present in a PCI endpoint and hence can be accessed by the PCI host. Second, it allows reuse of a OF compatible driver -- often used in SoC platforms -- in a PCI host based system.
There are 2 series devices rely on this patch:
1) Xilinx Alveo Accelerator cards (FPGA based device)
2) Microchip LAN9662 Ethernet Controller
Please see: https://lore.kernel.org/lkml/[email protected]/
Normally, the PCI core discovers PCI devices and their BARs using the PCI enumeration process. However, the process does not provide a way to discover the hardware peripherals that are present in a PCI device, and which can be accessed through the PCI BARs. Also, the enumeration process does not provide a way to associate MSI-X vectors of a PCI device with the hardware peripherals that are present in the device. PCI device drivers often use header files to describe the hardware peripherals and their resources as there is no standard data driven way to do so. This patch series proposes to use flattened device tree blob to describe the peripherals in a data driven way. Based on previous discussion, using device tree overlay is the best way to unflatten the blob and populate platform devices. To use device tree overlay, there are three obvious problems that need to be resolved.
First, we need to create a base tree for non-DT system such as x86_64. A patch series has been submitted for this:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
Second, a device tree node corresponding to the PCI endpoint is required for overlaying the flattened device tree blob for that PCI endpoint. Because PCI is a self-discoverable bus, a device tree node is usually not created for PCI devices. This series adds support to generate a device tree node for a PCI device which advertises itself using PCI quirks infrastructure.
Third, we need to generate device tree nodes for PCI bridges since a child PCI endpoint may choose to have a device tree node created.
This patch series is made up of three patches.
The first patch is adding OF interface to create or destroy OF node dynamically.
The second patch introduces a kernel option, CONFIG_DYNAMIC_PCI_OF_NODEX. When the option is turned on, the kernel will generate device tree nodes for all PCI bridges unconditionally. The patch also shows how to use the PCI quirks infrastructure, DECLARE_PCI_FIXUP_FINAL to generate a device tree node for a device. Specifically, the patch generates a device tree node for Xilinx Alveo U50 PCIe accelerator device. The generated device tree nodes do not have any property.
The third patch adds basic properties ('reg', 'compatible' and 'device_type') to the dynamically generated device tree nodes. More properties can be added in the future.
Here is the example of device tree nodes generated within the ARM64 QEMU.
# lspci -t
-[0000:00]-+-00.0
+-01.0-[01]--
+-01.1-[02]----00.0
+-01.2-[03]----00.0
+-01.3-[04]----00.0
+-01.4-[05]----00.0
+-01.5-[06]--
+-01.6-[07]--
+-01.7-[08]--
+-02.0-[09-0b]----00.0-[0a-0b]----00.0-[0b]--+-00.0
| \-00.1
+-02.1-[0c]--
\-03.0-[0d-0e]----00.0-[0e]----01.0# tree /sys/firmware/devicetree/base/pcie\@10000000 /sys/firmware/devicetree/base/pcie@10000000 |-- #address-cells |-- #interrupt-cells |-- #size-cells |-- bus-range |-- compatible |-- device_type |-- dma-coherent |-- interrupt-map |-- interrupt-map-mask |-- linux,pci-domain |-- msi-parent |-- name |-- pci@1,0 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,1 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,2 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,3 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,4 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,5 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,6 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@1,7 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@2,0 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- pci@0,0 | | |-- #address_cells | | |-- #size_cells | | |-- compatible | | |-- device_type | | |-- pci@0,0 | | | |-- #address_cells | | | |-- #size_cells | | | |-- compatible | | | |-- dev@0,0 | | | | |-- compatible | | | | `-- reg | | | |-- dev@0,1 | | | | |-- compatible | | | | `-- reg | | | |-- device_type | | | |-- ranges | | | `-- reg | | |-- ranges | | `-- reg | |-- ranges | `-- reg |-- pci@2,1 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- ranges | `-- reg |-- pci@3,0 | |-- #address_cells | |-- #size_cells | |-- compatible | |-- device_type | |-- pci@0,0 | | |-- #address_cells | | |-- #size_cells | | |-- compatible | | |-- device_type | | |-- ranges | | `-- reg | |-- ranges | `-- reg |-- ranges `-- reg
Changes since RFC v2:
- Merged patch 3 with patch 2
- Added OF interfaces of_changeset_add_prop_* and use them to create properties.
- Added '#address-cells', '#size-cells' and 'ranges' properties.
Changes since RFC v1:
- Added one patch to create basic properties.
- To move DT related code out of PCI subsystem, replaced of_node_alloc() with of_create_node()/of_destroy_node()
Lizhi Hou (2):
of: dynamic: Add interfaces for creating device node dynamically
PCI: Create device tree node for selected devices
drivers/of/dynamic.c | 187 ++++++++++++++++++++++++++ drivers/pci/Kconfig | 12 ++ drivers/pci/Makefile | 1 + drivers/pci/bus.c | 2 + drivers/pci/msi/irqdomain.c | 6 +- drivers/pci/of.c | 71 ++++++++++ drivers/pci/of_property.c | 256 ++++++++++++++++++++++++++++++++++++ drivers/pci/pci-driver.c | 3 +- drivers/pci/pci.h | 19 +++ drivers/pci/quirks.c | 11 ++ drivers/pci/remove.c | 1 + include/linux/of.h | 24 ++++ 12 files changed, 590 insertions(+), 3 deletions(-) create mode 100644 drivers/pci/of_property.c
Signature · 1 line
2.17.1
RFC PATCH v3 1/2 of: dynamic: Add interfaces for creating device node dynamically
of_create_node() creates device node dynamically. The parent device node and full name are required for creating the node. It optionally creates an OF changeset and attaches the newly created node to the changeset. The device node pointer and the changeset pointer can be used to add properties to the device node and apply the node to the base tree.
of_destroy_node() frees the device node created by of_create_node(). If an OF changeset was also created for this node, it will destroy the changeset before freeing the device node.
Expand of_changeset APIs to handle specific types of properties.
of_changeset_add_prop_string()
of_changeset_add_prop_string_array()
of_changeset_add_prop_u32_array()--- drivers/of/dynamic.c | 187 +++++++++++++++++++++++++++++++++++++++++++ include/linux/of.h | 24 ++++++ 2 files changed, 211 insertions(+)
drivers/of/dynamic.c +187 -0
@@ -461,6 +461,72 @@ struct device_node *__of_node_dup(const struct device_node *np,return NULL ; } +/** +* of_create_node - Dynamically create a device node +* +* @parent: Pointer to parent device node +* @full_name: Node full name +* @cset: Pointer to returning changeset +* +* Return: Pointer to the created device node or NULL in case of an error. +*/ +struct device_node *of_create_node (struct device_node *parent, +const char *full_name, +struct of_changeset **cset) +{ +struct of_changeset *ocs; +struct device_node *np; +int ret; + + np =__of_node_dup (NULL , full_name); +if (!np) +return NULL ; + np->parent = parent; + +if (!cset) +return np; + + ocs =kmalloc (sizeof (*cset),GFP_KERNEL ); +if (!ocs) { +of_node_put (np); +return NULL ; + } + +of_changeset_init (ocs); + ret =of_changeset_attach_node (ocs, np); +if (ret) { +of_changeset_destroy (ocs); +of_node_put (np); +kfree (ocs); +return NULL ; + } + + np->data = ocs; + *cset = ocs; + +return np; +} +EXPORT_SYMBOL (of_create_node); + +/** +* of_destroy_node - Destroy a dynamically created device node +* +* @np: Pointer to dynamically created device node +* +*/ +void of_destroy_node (struct device_node *np) +{ +struct of_changeset *ocs; + +if (np->data) { + ocs = (struct of_changeset *)np->data; +of_changeset_destroy (ocs); +kfree (ocs); + } +of_node_put (np); +} +EXPORT_SYMBOL (of_destroy_node); +static void __of_changeset_entry_destroy (struct of_changeset_entry *ce) { if (ce->action == OF_RECONFIG_ATTACH_NODE &&
@@ -934,3 +1000,124 @@ int of_changeset_action(struct of_changeset *ocs, unsigned long action,return 0 ; }EXPORT_SYMBOL_GPL (of_changeset_action); + +static int of_changeset_add_prop_helper (struct of_changeset *ocs, +struct device_node *np, +const struct property *pp) +{ +struct property *new_pp; +int ret; + + new_pp =__of_prop_dup (pp,GFP_KERNEL ); +if (!new_pp) +return -ENOMEM ; + + ret =of_changeset_add_property (ocs, np, new_pp); +if (ret) { +kfree (new_pp->name); +kfree (new_pp->value); +kfree (new_pp); + } + +return ret; +} + +/** +* of_changeset_add_prop_string - Add a string property to a changeset +* +* @ocs: changeset pointer +* @np: device node pointer +* @prop_name: name of the property to be added +* @str: pointer to null terminated string +* +* Create a string property and add it to a changeset. +* +* Return: 0 on success, a negative error value in case of an error. +*/ +int of_changeset_add_prop_string (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name,const char *str) +{ +struct property prop; + + prop.name = (char *)prop_name; + prop.length =strlen (str) +1 ; + prop.value = (void *)str; + +return of_changeset_add_prop_helper (ocs, np, &prop); +} +EXPORT_SYMBOL_GPL (of_changeset_add_prop_string); + +/** +* of_changeset_add_prop_string_array - Add a string list property to +* a changeset +* +* @ocs: changeset pointer +* @np: device node pointer +* @prop_name: name of the property to be added +* @str_array: pointer to an array of null terminated strings +* @sz: number of string array elements +* +* Create a string list property and add it to a changeset. +* +* Return: 0 on success, a negative error value in case of an error. +*/ +int of_changeset_add_prop_string_array (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name, +const char **str_array,size_t sz) +{ +struct property prop; +int i, ret; +char *vp; + + prop.name = (char *)prop_name; + + prop.length =0 ; +for (i =0 ; i < sz; i++) + prop.length +=strlen (str_array[i]) +1 ; + + prop.value =kmalloc (prop.length,GFP_KERNEL ); +if (!prop.value) +return -ENOMEM ; + + vp = prop.value; +for (i =0 ; i < sz; i++) { + vp +=snprintf (vp, (char *)prop.value + prop.length - vp,"%s" , + str_array[i]) +1 ; + } + ret =of_changeset_add_prop_helper (ocs, np, &prop); +kfree (prop.value); + +return ret; +} +EXPORT_SYMBOL_GPL (of_changeset_add_prop_string_array); + +/** +* of_changeset_add_prop_string - Add a property of 32 bit integers +* property to a changeset +* +* @ocs: changeset pointer +* @np: device node pointer +* @prop_name: name of the property to be added +* @u32: pointer to an array of 32 bit integers +* @sz: number of array elements +* +* Create a property of 32 bit integers and add it to a changeset. +* +* Return: 0 on success, a negative error value in case of an error. +*/ +int of_changeset_add_prop_u32_array (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name, +const u32 *array,size_t sz) +{ +struct property prop; + + prop.name = (char *)prop_name; + prop.length =sizeof (u32) * sz; + prop.value = (void *)array; + +return of_changeset_add_prop_helper (ocs, np, &prop); +} +EXPORT_SYMBOL_GPL (of_changeset_add_prop_u32_array);
include/linux/of.h +24 -0
@@ -1505,6 +1505,30 @@ static inline int of_changeset_update_property(struct of_changeset *ocs, {return of_changeset_action (ocs,OF_RECONFIG_UPDATE_PROPERTY , np, prop); } + +struct device_node *of_create_node (struct device_node *parent, +const char *full_name, +struct of_changeset **cset); +void of_destroy_node (struct device_node *np); +int of_changeset_add_prop_string (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name,const char *str); +int of_changeset_add_prop_string_array (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name, +const char **str_array,size_t sz); +int of_changeset_add_prop_u32_array (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name, +const u32 *array,size_t sz); +static inline int of_changeset_add_prop_u32 (struct of_changeset *ocs, +struct device_node *np, +const char *prop_name, +const u32 val) +{ +return of_changeset_add_prop_u32_array (ocs, np, prop_name, &val,1 ); +} +#else /* CONFIG_OF_DYNAMIC */ static inline int of_reconfig_notifier_register (struct notifier_block *nb) {
Signature · 1 line
2.17.1
RFC PATCH v3 2/2 PCI: Create device tree node for selected devices
In reply to Lizhi HouThe PCIe endpoint device such as Xilinx Alveo PCIe card maps the register spaces from multiple hardware peripherals to its PCIe BAR. Normally, the PCI core discovers devices and BARs using the PCI enumeration process. There is no infrastructure to discover the hardware peripherals that are present in a PCI device, and which can be accessed through the PCI BARs.
For Alveo PCIe card, the card firmware provides a flattened device tree to describe the hardware peripherals on its BARs. The Alveo card driver can load this flattened device tree and leverage device tree framework to generate platform devices for the hardware peripherals eventually.
Apparently, the device tree framework requires a device tree node for the PCIe device. Thus, it can generate the device tree nodes for hardware peripherals underneath. Because PCIe is self discoverable bus, there might not be a device tree node created for PCIe devices. This patch is to add support to generate device tree node for PCIe devices. It introduces a kernel option. When the option is turned on, the kernel will generate device tree nodes for PCI bridges unconditionally. It will also generate a device tree node for Xilinx Alveo U50 by using PCI quirks.
Initially, the basic properties are added for the dynamically generated device tree nodes.
--- drivers/pci/Kconfig | 12 ++ drivers/pci/Makefile | 1 + drivers/pci/bus.c | 2 + drivers/pci/msi/irqdomain.c | 6 +- drivers/pci/of.c | 71 ++++++++++ drivers/pci/of_property.c | 256 ++++++++++++++++++++++++++++++++++++ drivers/pci/pci-driver.c | 3 +- drivers/pci/pci.h | 19 +++ drivers/pci/quirks.c | 11 ++ drivers/pci/remove.c | 1 + 10 files changed, 379 insertions(+), 3 deletions(-) create mode 100644 drivers/pci/of_property.c
drivers/pci/Kconfig +12 -0
@@ -198,6 +198,18 @@ config PCI_HYPERV The PCI device frontend driver allows the kernel to import arbitrary PCI devices from a PCI backend to support PCI driver domains. +config PCI_DYNAMIC_OF_NODES + bool "Device tree node for PCI devices" + depends on OF + select OF_DYNAMIC + help + This option enables support for generating device tree nodes for some + PCI devices. Thus, the driver of this kind can load and overlay + flattened device tree for its downstream devices. + + Once this option is selected, the device tree nodes will be generated + for all PCI/PCIE bridges. + choice prompt "PCI Express hierarchy optimization setting" default PCIE_BUS_DEFAULT
drivers/pci/Makefile +1 -0
@@ -32,6 +32,7 @@ obj-$(CONFIG_PCI_P2PDMA) += p2pdma.o obj-$(CONFIG_XEN_PCIDEV_FRONTEND) += xen-pcifront.o obj-$(CONFIG_VGA_ARB) += vgaarb.o obj-$(CONFIG_PCI_DOE) += doe.o +obj-$(CONFIG_PCI_DYNAMIC_OF_NODES) += of_property.o # Endpoint library must be initialized before its users obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
drivers/pci/bus.c +2 -0
@@ -316,6 +316,8 @@ void pci_bus_add_device(struct pci_dev *dev)*/ pcibios_bus_add_device (dev);pci_fixup_device (pci_fixup_final, dev); +if (pci_is_bridge (dev)) +of_pci_make_dev_node (dev);pci_create_sysfs_dev_files (dev);pci_proc_attach_device (dev);pci_bridge_d3_update (dev);
drivers/pci/msi/irqdomain.c +4 -2
@@ -230,8 +230,10 @@ u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)pci_for_each_dma_alias (pdev, get_msi_id_cb, &rid); of_node =irq_domain_get_of_node (domain); - rid = of_node ?of_msi_map_id (&pdev->dev, of_node, rid) : -iort_msi_map_id (&pdev->dev, rid); +if (of_node && !of_node_check_flag (of_node,OF_DYNAMIC )) + rid =of_msi_map_id (&pdev->dev, of_node, rid); +else + rid =iort_msi_map_id (&pdev->dev, rid);return rid; }
drivers/pci/of.c +71 -0
83 lines not on this page · raw message
drivers/pci/of_property.c new file +256 -0
256 lines not on this page · raw message
drivers/pci/pci-driver.c +2 -1
@@ -1628,7 +1628,8 @@ static int pci_dma_configure(struct device *dev) bridge =pci_get_host_bridge_device (to_pci_dev (dev));if (IS_ENABLED (CONFIG_OF ) && bridge->parent && - bridge->parent->of_node) { + bridge->parent->of_node && + !of_node_check_flag (bridge->parent->of_node,OF_DYNAMIC )) { ret =of_dma_configure (dev, bridge->parent->of_node, true); }else if (has_acpi_companion (bridge)) {struct acpi_device *adev =to_acpi_device_node (bridge->fwnode);
drivers/pci/pci.h +19 -0
@@ -678,6 +678,25 @@ static inline int devm_of_pci_bridge_init(struct device *dev, struct pci_host_br#endif /* CONFIG_OF */ +struct of_changeset ; + +#ifdef CONFIG_PCI_DYNAMIC_OF_NODES +void of_pci_make_dev_node (struct pci_dev *pdev); +void of_pci_remove_node (struct pci_dev *pdev); +int of_pci_add_properties (struct pci_dev *pdev,struct of_changeset *ocs, +struct device_node *np); +#else +static inline void +of_pci_make_dev_node (struct pci_dev *pdev) +{ +} + +static inline void +of_pci_remove_node (struct pci_dev *pdev) +{ +} +#endif /* CONFIG_PCI_DYNAMIC_OF_NODES */ +#ifdef CONFIG_PCIEAER void pci_no_aer (void );void pci_aer_init (struct pci_dev *dev);
drivers/pci/quirks.c +11 -0
@@ -5956,3 +5956,14 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x56b1, aspm_l1_acceptable_latencyDECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,0x56c0 , aspm_l1_acceptable_latency);DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,0x56c1 , aspm_l1_acceptable_latency);#endif + +/* +* For PCI device which have multiple downstream devices, its driver may use +* a flattened device tree to describe the downstream devices. +* To overlay the flattened device tree, the PCI device and all its ancestor +* devices need to have device tree nodes on system base device tree. Thus, +* before driver probing, it might need to add a device tree node as the final +* fixup. +*/ +DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_XILINX ,0x5020 , of_pci_make_dev_node); +DECLARE_PCI_FIXUP_FINAL (PCI_VENDOR_ID_XILINX ,0x5021 , of_pci_make_dev_node);
drivers/pci/remove.c +1 -0
@@ -23,6 +23,7 @@ static void pci_stop_dev(struct pci_dev *dev)device_release_driver (&dev->dev);pci_proc_detach_device (dev);pci_remove_sysfs_dev_files (dev); +of_pci_remove_node (dev);pci_dev_assign_added (dev, false); }
Signature · 1 line
2.17.1
Re: [PATCH RFC V3 2/2] PCI: Create device tree node for selected devices
Quoted 11 lines · Lizhi Hou
The PCIe endpoint device such as Xilinx Alveo PCIe card maps the register spaces from multiple hardware peripherals to its PCIe BAR. Normally, the PCI core discovers devices and BARs using the PCI enumeration process. There is no infrastructure to discover the hardware peripherals that are present in a PCI device, and which can be accessed through the PCI BARs.
For Alveo PCIe card, the card firmware provides a flattened device tree to describe the hardware peripherals on its BARs. The Alveo card driver can load this flattened device tree and leverage device tree framework to generate platform devices for the hardware peripherals eventually.
Quoted 6 lines
Apparently, the device tree framework requires a device tree node for the PCIe device. Thus, it can generate the device tree nodes for hardware peripherals underneath. Because PCIe is self discoverable bus, there might not be a device tree node created for PCIe devices. This patch is to add support to generate device tree node for PCIe devices. It introduces a kernel option. When the option is turned on, the kernel will generate
Specify the kernel option here. These last two sentences should probably be a separate paragraph because they say specifically what this patch does.
Quoted 4 lines
device tree nodes for PCI bridges unconditionally.
It will also generate
a device tree node for Xilinx Alveo U50 by using PCI quirks.
I think I would split the Xilinx Alveo U50 quirk to a separate patch from the infrastructure and make this patch more generic.
drivers/pci/Kconfig config PCI_HYPERV · line 211
Quoted 11 lines
drivers/pci/Kconfig +11
-0+config PCI_DYNAMIC_OF_NODES + bool "Device tree node for PCI devices" + depends on OF + select OF_DYNAMIC + help + This option enables support for generating device tree nodes for some + PCI devices. Thus, the driver of this kind can load and overlay + flattened device tree for its downstream devices. + + Once this option is selected, the device tree nodes will be generated + for all PCI/PCIE bridges.
PCI/PCIe
Actually, in this context (and in the commit log), you should just say "PCI" because there's nothing PCIe-specific here.
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 628
Quoted 11 lines
drivers/pci/of.c +11
-0+void of_pci_make_dev_node (struct pci_dev *pdev) +{ +struct device_node *parent, *dt_node =NULL ; +const char *pci_type ="dev" ; +struct of_changeset *cset; +const char *full_name; +int ret; + +/* +* if there is already a device tree node linked to this device, +* return immediately.
s/if there/If there/
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 633
Quoted 5 lines
drivers/pci/of.c +5
-0+*/ +if (pci_device_to_OF_node (pdev)) +return ; + +/* check if there is device tree node for parent device */
s/check/Check/
Follow the style of the file, which is "capitalize English sentences."
Re: [PATCH RFC V3 2/2] PCI: Create device tree node for selected devices
Hi Bjorn,
Thanks for your comments. I will fix all these with next submission.
Lizhi
Quoted 65 lines · Bjorn Helgaas
Quoted 11 lines · Lizhi Hou
The PCIe endpoint device such as Xilinx Alveo PCIe card maps the register spaces from multiple hardware peripherals to its PCIe BAR. Normally, the PCI core discovers devices and BARs using the PCI enumeration process. There is no infrastructure to discover the hardware peripherals that are present in a PCI device, and which can be accessed through the PCI BARs.
For Alveo PCIe card, the card firmware provides a flattened device tree to describe the hardware peripherals on its BARs. The Alveo card driver can load this flattened device tree and leverage device tree framework to generate platform devices for the hardware peripherals eventually.
Quoted 6 lines
Apparently, the device tree framework requires a device tree node for the PCIe device. Thus, it can generate the device tree nodes for hardware peripherals underneath. Because PCIe is self discoverable bus, there might not be a device tree node created for PCIe devices. This patch is to add support to generate device tree node for PCIe devices. It introduces a kernel option. When the option is turned on, the kernel will generate
Specify the kernel option here. These last two sentences should probably be a separate paragraph because they say specifically what this patch does.
Quoted 3 lines
device tree nodes for PCI bridges unconditionally. It will also generate
a device tree node for Xilinx Alveo U50 by using PCI quirks.I think I would split the Xilinx Alveo U50 quirk to a separate patch from the infrastructure and make this patch more generic.
drivers/pci/Kconfig config PCI_HYPERV · line 211
Quoted 11 lines
drivers/pci/Kconfig +11
-0+config PCI_DYNAMIC_OF_NODES + bool "Device tree node for PCI devices" + depends on OF + select OF_DYNAMIC + help + This option enables support for generating device tree nodes for some + PCI devices. Thus, the driver of this kind can load and overlay + flattened device tree for its downstream devices. + + Once this option is selected, the device tree nodes will be generated + for all PCI/PCIE bridges.PCI/PCIe
Actually, in this context (and in the commit log), you should just say "PCI" because there's nothing PCIe-specific here.
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 628
Quoted 11 lines
drivers/pci/of.c +11
-0+void of_pci_make_dev_node (struct pci_dev *pdev) +{ +struct device_node *parent, *dt_node =NULL ; +const char *pci_type ="dev" ; +struct of_changeset *cset; +const char *full_name; +int ret; + +/* +* if there is already a device tree node linked to this device, +* return immediately. s/if there/If there/
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 633
Quoted 5 lines
drivers/pci/of.c +5
-0+*/ +if (pci_device_to_OF_node (pdev)) +return ; + +/* check if there is device tree node for parent device */ s/check/Check/
Follow the style of the file, which is "capitalize English sentences."
Re: [PATCH RFC V3 2/2] PCI: Create device tree node for selected devices
In reply to Bjorn HelgaasHi Bjorn,
Thanks for your comments. I will fix all these with next submission.
Lizhi
Quoted 65 lines · Bjorn Helgaas
Quoted 11 lines · Lizhi Hou
The PCIe endpoint device such as Xilinx Alveo PCIe card maps the register spaces from multiple hardware peripherals to its PCIe BAR. Normally, the PCI core discovers devices and BARs using the PCI enumeration process. There is no infrastructure to discover the hardware peripherals that are present in a PCI device, and which can be accessed through the PCI BARs.
For Alveo PCIe card, the card firmware provides a flattened device tree to describe the hardware peripherals on its BARs. The Alveo card driver can load this flattened device tree and leverage device tree framework to generate platform devices for the hardware peripherals eventually.
Quoted 6 lines
Apparently, the device tree framework requires a device tree node for the PCIe device. Thus, it can generate the device tree nodes for hardware peripherals underneath. Because PCIe is self discoverable bus, there might not be a device tree node created for PCIe devices. This patch is to add support to generate device tree node for PCIe devices. It introduces a kernel option. When the option is turned on, the kernel will generate
Specify the kernel option here. These last two sentences should probably be a separate paragraph because they say specifically what this patch does.
Quoted 3 lines
device tree nodes for PCI bridges unconditionally. It will also generate
a device tree node for Xilinx Alveo U50 by using PCI quirks.I think I would split the Xilinx Alveo U50 quirk to a separate patch from the infrastructure and make this patch more generic.
drivers/pci/Kconfig config PCI_HYPERV · line 211
Quoted 11 lines
drivers/pci/Kconfig +11
-0+config PCI_DYNAMIC_OF_NODES + bool "Device tree node for PCI devices" + depends on OF + select OF_DYNAMIC + help + This option enables support for generating device tree nodes for some + PCI devices. Thus, the driver of this kind can load and overlay + flattened device tree for its downstream devices. + + Once this option is selected, the device tree nodes will be generated + for all PCI/PCIE bridges.PCI/PCIe
Actually, in this context (and in the commit log), you should just say "PCI" because there's nothing PCIe-specific here.
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 628
Quoted 11 lines
drivers/pci/of.c +11
-0+void of_pci_make_dev_node (struct pci_dev *pdev) +{ +struct device_node *parent, *dt_node =NULL ; +const char *pci_type ="dev" ; +struct of_changeset *cset; +const char *full_name; +int ret; + +/* +* if there is already a device tree node linked to this device, +* return immediately. s/if there/If there/
drivers/pci/of.c int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge) · line 633
Quoted 5 lines
drivers/pci/of.c +5
-0+*/ +if (pci_device_to_OF_node (pdev)) +return ; + +/* check if there is device tree node for parent device */ s/check/Check/
Follow the style of the file, which is "capitalize English sentences."