net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()
Subsystems (2)
PATCH 1/1 net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()
In pch_gbe_xmit_frame(), NETDEV_TX_OK will be returned whether pch_gbe_tx_queue() sends data successfully or not, so pch_gbe_tx_queue() needs to free skb before returning. But pch_gbe_tx_queue() returns without freeing skb in case of dma_map_single() fails. Add dev_kfree_skb_any() to fix it.
--- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +1 -0
@@ -1143,6 +1143,7 @@ static void pch_gbe_tx_queue(struct pch_gbe_adapter *adapter, buffer_info->dma =0 ; buffer_info->time_stamp =0 ; tx_ring->next_to_use = ring_num; +dev_kfree_skb_any (skb);return ; } buffer_info->mapped = true;
Signature · 1 line
2.17.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 10 lines · On Thu, 17 Nov 2022 14:55:27 +0800 you wrote:
In
pch_gbe_xmit_frame(),NETDEV_TX_OKwill be returned whetherpch_gbe_tx_queue()sends data successfully or not, sopch_gbe_tx_queue()needs to free skb before returning. Butpch_gbe_tx_queue()returns without freeing skb in case ofdma_map_single()fails. Adddev_kfree_skb_any()to fix it.Fixes 77555ee72282 ("net: Add Gigabit Ethernet driver of Topcliff PCH")Signed-off-by Wang Hai <[email protected]>[...]
Here is the summary with links:
- [net] net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()
https://git.kernel.org/netdev/net/c/2360f9b8c4e8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html