Skip to contentSkip to conversation

octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 18, 2022 – Nov 21, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()

This code accidentally uses the RX macro twice instead of the RX and TX.

Fixes 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")

---
Applies to net.

 drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/mcs.c +1 -1
index 4a343f853b28..c0bedf402da9 100644
@@ -951,7 +951,7 @@ static void mcs_bbe_intr_handler(struct mcs *mcs, u64 intr, enum mcs_direction d
 		else
 			event.intr_mask = (dir == MCS_RX) ?
 					  MCS_BBE_RX_PLFIFO_OVERFLOW_INT :
-					  MCS_BBE_RX_PLFIFO_OVERFLOW_INT;
+					  MCS_BBE_TX_PLFIFO_OVERFLOW_INT;
 
 		/* Notify the lmac_id info which ran into BBE fatal error */
 		event.lmac_id = i & 0x3ULL;
Signature · 1 line
2.35.1
#1 lore raw

ACK.
Thanks for the patch.

Geetha.

________________________________________
From: Dan Carpenter <[email protected]>
Sent: Friday, November 18, 2022 8:37 PM
To: Sunil Kovvuri Goutham; Geethasowjanya Akula
Cc: Linu Cherian; Jerin Jacob Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni; Vamsi Krishna Attunuru; [email protected]; [email protected]
Subject: [EXT] [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()

External Email

----------------------------------------------------------------------
This code accidentally uses the RX macro twice instead of the RX and TX.

Fixes 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")

---
Applies to net.

 drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/mcs.c +1 -1
index 4a343f853b28..c0bedf402da9 100644
@@ -951,7 +951,7 @@ static void mcs_bbe_intr_handler(struct mcs *mcs, u64 intr, enum mcs_direction d
                else
                        event.intr_mask = (dir == MCS_RX) ?
                                          MCS_BBE_RX_PLFIFO_OVERFLOW_INT :
-                                         MCS_BBE_RX_PLFIFO_OVERFLOW_INT;
+                                         MCS_BBE_TX_PLFIFO_OVERFLOW_INT;
 
                /* Notify the lmac_id info which ran into BBE fatal error */
                event.lmac_id = i & 0x3ULL;

--
2.35.1

#2 lore raw
In reply to Dan Carpenter
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 18 Nov 2022 18:07:54 +0300 you wrote:

This code accidentally uses the RX macro twice instead of the RX and TX.

Fixes 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")

---
Applies to net.

[...]

Here is the summary with links:
- [net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()

    https://git.kernel.org/netdev/net/c/badbda1a0186

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html