Skip to contentSkip to conversation

xfs/243: add _require_scratch_delalloc()

PATCH In review Xiao Yang 2 participants 4 messages Nov 23, 2022 – Dec 17, 2022

lore
Share & tools
lore

Xiao Yang

author
#0 lore raw

PATCH 1/1 xfs/243: add _require_scratch_delalloc()

xfs/243 requires the delalloc feature of XFS so return [not run] when XFS with enabled DAX doesn't support it.

---
 tests/xfs/243 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/243 +1 -0
index 8f0c5939..739efe4a 100755
@@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch
 _supported_fs xfs
 _require_xfs_debug
 _require_scratch_reflink
+_require_scratch_delalloc
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "cowextsize"
 _require_xfs_io_command "fpunch"
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Xiao Yang

xfs/243 requires the delalloc feature of XFS so return [not run] when XFS with enabled DAX doesn't support it.

---

Looks good to me, this case starts to fail from xfs dax supports reflink.

Quoted 18 lines
 tests/xfs/243 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/243 +1 -0
index 8f0c5939..739efe4a 100755
@@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch
 _supported_fs xfs
 _require_xfs_debug
 _require_scratch_reflink
+_require_scratch_delalloc
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "cowextsize"
 _require_xfs_io_command "fpunch"
Signature · 1 line
2.34.1
author Reviewed-by Zorro Lang
#2 lore raw

Hi zorro,

Is it OK to merge the patch?

Best Regards,
Xiao Yang

-----Original Message-----
From: Zorro Lang <[email protected]>
Sent: 2022年11月24日 0:27
To: Yang, Xiao/杨 晓 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] xfs/243: add _require_scratch_delalloc()

Quoted 5 lines · Xiao Yang

xfs/243 requires the delalloc feature of XFS so return [not run] when XFS with enabled DAX doesn't support it.

---

Looks good to me, this case starts to fail from xfs dax supports reflink.

Quoted 16 lines
 tests/xfs/243 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/243 index 8f0c5939..739efe4a renamed from tests/xfs/243 +0 -0

100755

tests/xfs/243 +0 -0
@@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch  _supported_fs 

xfs _require_xfs_debug _require_scratch_reflink
+_require_scratch_delalloc
_require_xfs_io_command "falloc"
_require_xfs_io_command "cowextsize"
_require_xfs_io_command "fpunch"
--
2.34.1

#3 lore raw
Quoted 3 lines · On Sat, Dec 17, 2022 at 09:33:41AM +0000, [email protected] wrote:

Hi zorro,

Is it OK to merge the patch?

Thanks for ping me, I'll merge this patch.

Thanks,
Zorro

Quoted 39 lines

Best Regards,
Xiao Yang

-----Original Message-----
From: Zorro Lang <[email protected]>
Sent: 2022年11月24日 0:27
To: Yang, Xiao/杨 晓 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] xfs/243: add _require_scratch_delalloc()

Quoted 5 lines · Xiao Yang

xfs/243 requires the delalloc feature of XFS so return [not run] when XFS with enabled DAX doesn't support it.

---

Looks good to me, this case starts to fail from xfs dax supports reflink.

Quoted 16 lines
 tests/xfs/243 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/243 index 8f0c5939..739efe4a renamed from tests/xfs/243 +0 -0

100755

tests/xfs/243 +0 -0
@@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch  _supported_fs 

xfs _require_xfs_debug _require_scratch_reflink
+_require_scratch_delalloc
_require_xfs_io_command "falloc"
_require_xfs_io_command "cowextsize"
_require_xfs_io_command "fpunch"
--
2.34.1