Skip to contentSkip to conversation

net/ice: fix link status error when dev start

PATCH In review Shuang Han 2 participants 3 messages Nov 23, 2022 – Dec 13, 2022 Network drivers

lore
Share & tools
lore

Shuang Han

author
#0 lore raw

PATCH 1/1 net/ice: fix link status error when dev start

ice_link_update get port link status and wait for one second when dev start. If the device need almost one second for link up,
ice_link_update will enter the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime link interrupt raised,
the interrupt handler update dev->data->dev_link to up.
After a while the rte_delay_ms(CHECK_INTERVAL) finished
and update dev->data->dev_link to down.

---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_ethdev.c +1 -1
index 0bc739d..316ba5a 100644
@@ -4013,9 +4013,9 @@ static int ice_init_rss(struct ice_pf *pf)
 			      RTE_ETH_LINK_SPEED_FIXED);
 
 out:
-	ice_atomic_write_link_status(dev, &link);
 	if (link.link_status == old.link_status)
 		return -1;
+	ice_atomic_write_link_status(dev, &link);
 
 	return 0;
 }
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 27 lines

-----Original Message-----
From: Shuang Han <[email protected]>
Sent: Wednesday, November 23, 2022 8:42 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Shuang Han <[email protected]>
Subject: [PATCH] net/ice: fix link status error when dev start

ice_link_update get port link status and wait for one second when dev start. If the device need almost one second for link up, ice_link_update will enter the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime link interrupt raised, the interrupt handler update dev->data->dev_link to up. After a while the rte_delay_ms(CHECK_INTERVAL) finished and update dev-

Quoted 1 line

data->dev_link to down.

---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_ethdev.c index renamed from drivers/net/ice/ice_ethdev.c +0 -0

0bc739d..316ba5a 100644

drivers/net/ice/ice_ethdev.c static int ice_init_rss(struct ice_pf *pf) · line 4018

Quoted 7 lines
drivers/net/ice/ice_ethdev.c +1 -1
@@ -4013,9 +4013,9 @@ static int ice_init_rss(struct ice_pf *pf)
 			      RTE_ETH_LINK_SPEED_FIXED);
 
 out:
-	ice_atomic_write_link_status(dev, &link);
 	if (link.link_status == old.link_status)
 		return -1;
+	ice_atomic_write_link_status(dev, &link);

This looks like a workaround, I think we may need some lock to prevent ice_link_update be re-entered from different thread at same time.

Quoted 5 lines
drivers/net/ice/ice_ethdev.c +0 -1
 	return 0;
 }
--

1.8.3.1

author
#2 lore raw

I agree. Maybe this is the better solution

Quoted 49 lines · Zhang, Qi Z <[email protected]> 于2022年12月13日周二 09:50写道:
Quoted 11 lines

-----Original Message-----
From: Shuang Han <[email protected]>
Sent: Wednesday, November 23, 2022 8:42 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Shuang Han <[email protected]>
Subject: [PATCH] net/ice: fix link status error when dev start

ice_link_update get port link status and wait for one second when dev

start.

Quoted 1 line

If the device need almost one second for link up, ice_link_update will

enter

Quoted 2 lines

the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime link interrupt raised, the interrupt handler update dev->data->dev_link

to up.

drivers/net/ice/ice_ethdev.c

Quoted 9 lines

After a while the rte_delay_ms(CHECK_INTERVAL) finished and update dev-

Quoted 1 line

data->dev_link to down.

---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_ethdev.c +0 -0

index

drivers/net/ice/ice_ethdev.c static int ice_init_rss(struct ice_pf *pf) · line 4018

Quoted 11 lines

0bc739d..316ba5a 100644

drivers/net/ice/ice_ethdev.c +1 -1
@@ -4013,9 +4013,9 @@ static int ice_init_rss(struct ice_pf *pf)
                            RTE_ETH_LINK_SPEED_FIXED);
 
 out:
-     ice_atomic_write_link_status(dev, &link);
      if (link.link_status == old.link_status)
              return -1;
+     ice_atomic_write_link_status(dev, &link);

This looks like a workaround, I think we may need some lock to prevent ice_link_update be re-entered from different thread at same time.

Quoted 5 lines
drivers/net/ice/ice_ethdev.c +0 -1
      return 0;
 }
--

1.8.3.1

Signature · 2 lines
Best regards
Han Shuang