vdpa/ifc: fix argument compatibility check
PATCH 1/1 vdpa/ifc: fix argument compatibility check
"sw_fallback_lm=0" means driver does not provide live migration assistance. so hardware assistance is needed to support live migration. However registers for live migration in BAR4 are not implemented. In the case, we just return error after display some logs.
--- drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/vdpa/ifc/ifcvf_vdpa.c +5 -0
@@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = { goto error; } internal->sw_lm = sw_fallback_lm; +if (!internal->sw_lm && !internal->hw.lm_cfg) { +DRV_LOG (ERR ,"Device %s does not support HW assist live migration, please enable sw-live-migration!" , + pci_dev->name); + goto error; + }pthread_mutex_lock (&internal_list_lock);TAILQ_INSERT_TAIL (&internal_list, list, next);
Signature · 1 line
1.8.3.1
Quoted 19 lines · Andy Pei
"sw_fallback_lm=0" means driver does not provide live migration assistance. so hardware assistance is needed to support live migration. However registers for live migration in BAR4 are not implemented. In the case, we just return error after display some logs.
Fixes 4c3f55cc23ea ("net/ifc: add LM mode parameter")Signed-off-by Andy Pei <[email protected]>--- drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/vdpa/ifc/ifcvf_vdpa.c +0
-0@@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = { goto error;
drivers/vdpa/ifc/ifcvf_vdpa.c struct rte_vdpa_dev_info dev_info[] = { · line 1756
Quoted 10 lines
drivers/vdpa/ifc/ifcvf_vdpa.c +5
-0} internal->sw_lm = sw_fallback_lm; +if (!internal->sw_lm && !internal->hw.lm_cfg) { +DRV_LOG (ERR ,"Device %s does not support HW assist live migration, please enable sw-live-migration!" , + pci_dev->name); + goto error; + }pthread_mutex_lock (&internal_list_lock);TAILQ_INSERT_TAIL (&internal_list, list, next);
Thanks,
Maxime
Maxime Coquelin
AppliedQuoted 19 lines · Andy Pei
"sw_fallback_lm=0" means driver does not provide live migration assistance. so hardware assistance is needed to support live migration. However registers for live migration in BAR4 are not implemented. In the case, we just return error after display some logs.
Fixes 4c3f55cc23ea ("net/ifc: add LM mode parameter")Signed-off-by Andy Pei <[email protected]>--- drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/vdpa/ifc/ifcvf_vdpa.c +0
-0@@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = { goto error;
drivers/vdpa/ifc/ifcvf_vdpa.c struct rte_vdpa_dev_info dev_info[] = { · line 1756
Quoted 10 lines
drivers/vdpa/ifc/ifcvf_vdpa.c +5
-0} internal->sw_lm = sw_fallback_lm; +if (!internal->sw_lm && !internal->hw.lm_cfg) { +DRV_LOG (ERR ,"Device %s does not support HW assist live migration, please enable sw-live-migration!" , + pci_dev->name); + goto error; + }pthread_mutex_lock (&internal_list_lock);TAILQ_INSERT_TAIL (&internal_list, list, next);
Applied to dpdk-next-virtio/main.
Thanks,
Maxime