r8169: use tp_to_dev instead of open code
PATCH 1/1 r8169: use tp_to_dev instead of open code
The open code is defined as a helper function(tp_to_dev) on r8169_main.c, which the open code is &tp->pci_dev->dev. The helper function was added in commit 1e1205b7d3e9 ("r8169: add helper tp_to_dev"). And then later, commit f1e911d5d0df ("r8169: add basic phylib support") added r8169_phylink_handler function but it didn't use the helper function. Thus, tp_to_dev() replaces the open code. This patch doesn't change logic.
--- drivers/net/ethernet/realtek/r8169_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +3 -2
@@ -4559,12 +4559,13 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)static void r8169_phylink_handler (struct net_device *ndev) {struct rtl8169_private *tp =netdev_priv (ndev); +struct device *d =tp_to_dev (tp);if (netif_carrier_ok (ndev)) {rtl_link_chg_patch (tp); -pm_request_resume (&tp->pci_dev->dev); +pm_request_resume (d); }else { -pm_runtime_idle (&tp->pci_dev->dev); +pm_runtime_idle (d); }phy_print_status (tp->phydev);
Signature · 1 line
2.34.1
Quoted 8 lines · Juhee Kang
The open code is defined as a helper
function(tp_to_dev)onr8169_main.c, which the open code is&tp->pci_dev->dev. The helper function was added in commit1e1205b7d3e9("r8169: add helpertp_to_dev"). And then later, commitf1e911d5d0df("r8169: add basic phylib support") addedr8169_phylink_handlerfunction but it didn't use the helper function. Thus,tp_to_dev()replaces the open code. This patch doesn't change logic.Signed-off-by Juhee Kang <[email protected]>
Doesn't hurt and helper is used more than once in this function.
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Wed, 30 Nov 2022 01:12:44 +0900 you wrote:
The open code is defined as a helper
function(tp_to_dev)onr8169_main.c, which the open code is&tp->pci_dev->dev. The helper function was added in commit1e1205b7d3e9("r8169: add helpertp_to_dev"). And then later, commitf1e911d5d0df("r8169: add basic phylib support") addedr8169_phylink_handlerfunction but it didn't use the helper function. Thus,tp_to_dev()replaces the open code. This patch doesn't change logic.[...]
Here is the summary with links:
- [net-next] r8169: use tp_to_dev instead of open code
https://git.kernel.org/netdev/net-next/c/4b6c6065fca1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html