remove label = "cpu" from DSA dt-binding
Subsystems (15)
cover remove label = "cpu" from DSA dt-binding
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)
I've been meaning to submit this for a few months. Find the relevant conversation here:
https://lore.kernel.org/netdev/[email protected]/
Here's how I did it, for the interested (or suggestions):
Find the platforms which have got 'label = "cpu";' defined. grep -rnw . -e 'label = "cpu";'
Remove the line where 'label = "cpu";' is included.
sed -i /'label = "cpu";'/,+d arch/arm/boot/dts/*
sed -i /'label = "cpu";'/,+d arch/arm64/boot/dts/freescale/*
sed -i /'label = "cpu";'/,+d arch/arm64/boot/dts/marvell/*
sed -i /'label = "cpu";'/,+d arch/arm64/boot/dts/mediatek/*
sed -i /'label = "cpu";'/,+d arch/arm64/boot/dts/rockchip/*
sed -i /'label = "cpu";'/,+d arch/mips/boot/dts/qca/*
sed -i /'label = "cpu";'/,+d arch/mips/boot/dts/ralink/*
sed -i /'label = "cpu";'/,+d arch/powerpc/boot/dts/turris1x.dts
sed -i /'label = "cpu";'/,+d Documentation/devicetree/bindings/net/qca,ar71xx.yaml
Restore the symlink files which typechange after running sed.
Arınç ÜNAL (5):
dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
arm: dts: remove label = "cpu" from DSA dt-binding
arm64: dts: remove label = "cpu" from DSA dt-binding
mips: dts: remove label = "cpu" from DSA dt-binding
powerpc: dts: remove label = "cpu" from DSA dt-binding
PATCH 1/5 dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
This is not used by the DSA dt-binding, so remove it from the examples.
--- Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/net/qca,ar71xx.yaml +0 -1
@@ -123,7 +123,6 @@ examples: switch_port0: port@0 { reg = <0x0>; - label = "cpu"; ethernet = <ð1>; phy-mode = "gmii";
Signature · 1 line
2.34.1
Re: [PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
Quoted 3 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from the examples.
Signed-off-by Arınç ÜNAL <[email protected]>
Thx!
Quoted 20 lines
--- Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - 1 file changed, 1 deletion(-)Documentation/devicetree/bindings/net/qca,ar71xx.yaml +0
-1@@ -123,7 +123,6 @@ examples: switch_port0: port@0 { reg = <0x0>; - label = "cpu"; ethernet = <ð1>; phy-mode = "gmii";Signature · 1 line
2.34.1
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: [PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
In reply to Arınç ÜNALQuoted 7 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from the examples.
Signed-off-by Arınç ÜNAL <[email protected]>--- Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - 1 file changed, 1 deletion(-)
PATCH 2/5 arm: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALThis is not used by the DSA dt-binding, so remove it from all devicetrees.
--- arch/arm/boot/dts/armada-370-rd.dts | 1 - arch/arm/boot/dts/armada-381-netgear-gs110emx.dts | 1 - arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dts | 1 - arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dts | 1 - arch/arm/boot/dts/armada-385-linksys.dtsi | 1 - arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 - arch/arm/boot/dts/armada-388-clearfog.dts | 1 - arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 - arch/arm/boot/dts/at91-sama5d2_icp.dts | 1 - arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts | 1 - arch/arm/boot/dts/bcm-cygnus.dtsi | 1 - arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp-common.dtsi | 1 - arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts | 1 - arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts | 1 - arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 1 - arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 1 - arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 1 - arch/arm/boot/dts/bcm47081-luxul-xap-1410.dts | 1 - arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts | 1 - arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 1 - arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 3 --- arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 1 - arch/arm/boot/dts/bcm47094-linksys-panamera.dts | 4 ---- arch/arm/boot/dts/bcm47094-luxul-abr-4500.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xap-1610.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xbr-4500.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwc-2000.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts | 1 - arch/arm/boot/dts/bcm47189-tenda-ac9.dts | 1 - arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 1 - arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 1 - arch/arm/boot/dts/bcm953012er.dts | 1 - arch/arm/boot/dts/bcm958622hr.dts | 1 - arch/arm/boot/dts/bcm958623hr.dts | 1 - arch/arm/boot/dts/bcm958625hr.dts | 1 - arch/arm/boot/dts/bcm958625k.dts | 1 - arch/arm/boot/dts/bcm988312hr.dts | 1 - arch/arm/boot/dts/gemini-dlink-dir-685.dts | 1 - arch/arm/boot/dts/gemini-sl93512r.dts | 1 - arch/arm/boot/dts/gemini-sq201.dts | 1 - arch/arm/boot/dts/imx51-zii-rdu1.dts | 1 - arch/arm/boot/dts/imx51-zii-scu2-mezz.dts | 1 - arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 1 - arch/arm/boot/dts/imx53-kp-hsc.dts | 1 - arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 1 - arch/arm/boot/dts/imx6q-b450v3.dts | 1 - arch/arm/boot/dts/imx6q-b650v3.dts | 1 - arch/arm/boot/dts/imx6q-b850v3.dts | 1 - arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 1 - arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 1 - arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 1 - arch/arm/boot/dts/imx6qp-prtwd3.dts | 1 - arch/arm/boot/dts/imx7d-zii-rpu2.dts | 1 - arch/arm/boot/dts/kirkwood-dir665.dts | 1 - arch/arm/boot/dts/kirkwood-l-50.dts | 1 - arch/arm/boot/dts/kirkwood-linksys-viper.dts | 1 - arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 1 - arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 1 - arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 1 - arch/arm/boot/dts/mt7623a-rfb-nand.dts | 1 - arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 - arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 1 - arch/arm/boot/dts/orion5x-netgear-wnr854t.dts | 1 - arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 -- arch/arm/boot/dts/r9a06g032.dtsi | 1 - arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 1 - arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 1 - arch/arm/boot/dts/vf610-zii-cfu1.dts | 1 - arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 1 - arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 1 - arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 1 - arch/arm/boot/dts/vf610-zii-spb4.dts | 1 - arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 1 - arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 1 - 75 files changed, 81 deletions(-)
arch/arm/boot/dts/armada-370-rd.dts +0 -1
@@ -171,7 +171,6 @@ port@3 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð1>; fixed-link { speed = <1000>;
arch/arm/boot/dts/armada-381-netgear-gs110emx.dts +0 -1
@@ -148,7 +148,6 @@ ports { port@0 { ethernet = <ð0>; - label = "cpu"; reg = <0>; fixed-link {
arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dts +0 -1
@@ -68,7 +68,6 @@ port@8 { port@10 { reg = <10>; - label = "cpu"; ethernet = <ð1>; };
arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dts +0 -1
@@ -48,7 +48,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð1>; };
arch/arm/boot/dts/armada-385-linksys.dtsi +0 -1
@@ -195,7 +195,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð2>; fixed-link {
arch/arm/boot/dts/armada-385-turris-omnia.dts +0 -1
@@ -473,7 +473,6 @@ ports@4 { ports@5 { reg = <5>; - label = "cpu"; ethernet = <ð1>; phy-mode = "rgmii-id";
arch/arm/boot/dts/armada-388-clearfog.dts +0 -1
@@ -129,7 +129,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð1>; fixed-link { speed = <1000>;
arch/arm/boot/dts/armada-xp-linksys-mamba.dts +0 -1
@@ -302,7 +302,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð0>; fixed-link { speed = <1000>;
arch/arm/boot/dts/at91-sama5d2_icp.dts +0 -1
@@ -137,7 +137,6 @@ port@1 { port@2 { reg = <2>; - label = "cpu"; ethernet = <&macb0>; phy-mode = "mii"; fixed-link {
arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts +0 -1
@@ -149,7 +149,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&macb0>; phy-mode = "rgmii-txid";
arch/arm/boot/dts/bcm-cygnus.dtsi +0 -1
@@ -210,7 +210,6 @@ port@1 { port@8 { reg = <8>; - label = "cpu"; ethernet = <ð0>; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp-common.dtsi +0 -1
@@ -185,7 +185,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts +0 -1
@@ -73,7 +73,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts +0 -1
@@ -75,7 +75,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm4708-netgear-r6250.dts +0 -1
@@ -126,7 +126,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts +0 -1
@@ -149,7 +149,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts +0 -1
@@ -149,7 +149,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47081-luxul-xap-1410.dts +0 -1
@@ -68,7 +68,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts +0 -1
@@ -141,7 +141,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm4709-netgear-r8000.dts +0 -1
@@ -217,7 +217,6 @@ port@4 { port@8 { reg = <8>; - label = "cpu"; ethernet = <&gmac2>; fixed-link {
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts +0 -3
@@ -136,7 +136,6 @@ port@3 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&sw0_p5>; phy-mode = "rgmii"; tx-internal-delay-ps = <2000>;
@@ -220,7 +219,6 @@ fixed-link { port@7 { reg = <7>; ethernet = <&gmac1>; - label = "cpu"; fixed-link { speed = <1000>;
@@ -231,7 +229,6 @@ fixed-link { port@8 { reg = <8>; ethernet = <&gmac2>; - label = "cpu"; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts +0 -1
@@ -150,7 +150,6 @@ port@4 { port@8 { reg = <8>; - label = "cpu"; ethernet = <&gmac2>; fixed-link {
arch/arm/boot/dts/bcm47094-linksys-panamera.dts +0 -4
@@ -180,7 +180,6 @@ port@4 { sw1_p8: port@8 { reg = <8>; ethernet = <&sw0_p0>; - label = "cpu"; fixed-link { speed = <1000>;
@@ -230,7 +229,6 @@ port@4 { port@5 { reg = <5>; ethernet = <&gmac0>; - label = "cpu"; status = "disabled"; fixed-link {
@@ -242,7 +240,6 @@ fixed-link { port@7 { reg = <7>; ethernet = <&gmac1>; - label = "cpu"; status = "disabled"; fixed-link {
@@ -254,7 +251,6 @@ fixed-link { port@8 { reg = <8>; ethernet = <&gmac2>; - label = "cpu"; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm47094-luxul-abr-4500.dts +0 -1
@@ -100,7 +100,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47094-luxul-xap-1610.dts +0 -1
@@ -71,7 +71,6 @@ port@1 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47094-luxul-xbr-4500.dts +0 -1
@@ -100,7 +100,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47094-luxul-xwc-2000.dts +0 -1
@@ -62,7 +62,6 @@ port@0 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts +0 -1
@@ -140,7 +140,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts +0 -1
@@ -123,7 +123,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm47189-tenda-ac9.dts +0 -1
@@ -137,7 +137,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm53015-meraki-mr26.dts +0 -1
@@ -123,7 +123,6 @@ port@0 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; fixed-link {
arch/arm/boot/dts/bcm53016-meraki-mr32.dts +0 -1
@@ -182,7 +182,6 @@ port@0 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; fixed-link {
arch/arm/boot/dts/bcm953012er.dts +0 -1
@@ -81,7 +81,6 @@ port@1 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; }; };
arch/arm/boot/dts/bcm958622hr.dts +0 -1
@@ -204,7 +204,6 @@ port@4 { port@8 { ethernet = <&amac2>; - label = "cpu"; reg = <8>; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm958623hr.dts +0 -1
@@ -208,7 +208,6 @@ port@4 { port@8 { ethernet = <&amac2>; - label = "cpu"; reg = <8>; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm958625hr.dts +0 -1
@@ -231,7 +231,6 @@ port@5 { port@8 { ethernet = <&amac2>; - label = "cpu"; reg = <8>; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm958625k.dts +0 -1
@@ -244,7 +244,6 @@ port@4 { port@8 { ethernet = <&amac2>; - label = "cpu"; reg = <8>; fixed-link { speed = <1000>;
arch/arm/boot/dts/bcm988312hr.dts +0 -1
@@ -216,7 +216,6 @@ port@4 { port@8 { ethernet = <&amac2>; - label = "cpu"; reg = <8>; fixed-link { speed = <1000>;
arch/arm/boot/dts/gemini-dlink-dir-685.dts +0 -1
@@ -235,7 +235,6 @@ port@4 { }; rtl8366rb_cpu_port: port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "rgmii"; fixed-link {
arch/arm/boot/dts/gemini-sl93512r.dts +0 -1
@@ -123,7 +123,6 @@ port@3 { }; vsc: port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac1>; phy-mode = "rgmii"; fixed-link {
arch/arm/boot/dts/gemini-sq201.dts +0 -1
@@ -108,7 +108,6 @@ port@3 { }; vsc: port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac1>; phy-mode = "rgmii"; fixed-link {
arch/arm/boot/dts/imx51-zii-rdu1.dts +0 -1
@@ -181,7 +181,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec>; fixed-link {
arch/arm/boot/dts/imx51-zii-scu2-mezz.dts +0 -1
@@ -82,7 +82,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <&fec>; fixed-link {
arch/arm/boot/dts/imx51-zii-scu3-esb.dts +0 -1
@@ -267,7 +267,6 @@ fixed-link { port@6 { reg = <6>; - label = "cpu"; phy-mode = "mii"; ethernet = <&fec>;
arch/arm/boot/dts/imx53-kp-hsc.dts +0 -1
@@ -34,7 +34,6 @@ ports { port@0 { /* RMII fixed link to master */ reg = <0>; - label = "cpu"; ethernet = <&fec>; };
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +0 -1
@@ -138,7 +138,6 @@ switch_ports: ports { ethphy0: port@0 { reg = <0>; - label = "cpu"; phy-mode = "rgmii-id"; ethernet = <&fec>;
arch/arm/boot/dts/imx6q-b450v3.dts +0 -1
@@ -139,7 +139,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <&switch_nic>; phy-handle = <&switchphy4>; };
arch/arm/boot/dts/imx6q-b650v3.dts +0 -1
@@ -138,7 +138,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <&switch_nic>; phy-handle = <&switchphy4>; };
arch/arm/boot/dts/imx6q-b850v3.dts +0 -1
@@ -288,7 +288,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <&switch_nic>; phy-handle = <&switchphy4>; };
arch/arm/boot/dts/imx6qdl-gw5904.dtsi +0 -1
@@ -238,7 +238,6 @@ port@3 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&fec>; }; };
arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi +0 -1
@@ -87,7 +87,6 @@ ports@1 { ports@2 { reg = <2>; - label = "cpu"; ethernet = <&fec>; phy-mode = "rmii";
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +0 -1
@@ -757,7 +757,6 @@ port@1 { port@2 { reg = <2>; - label = "cpu"; ethernet = <&fec>; fixed-link {
arch/arm/boot/dts/imx6qp-prtwd3.dts +0 -1
@@ -175,7 +175,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <&fec>; phy-mode = "rgmii-id"; rx-internal-delay-ps = <2000>;
arch/arm/boot/dts/imx7d-zii-rpu2.dts +0 -1
@@ -262,7 +262,6 @@ fixed-link { port@5 { reg = <5>; - label = "cpu"; ethernet = <&fec1>; phy-mode = "rgmii-id";
arch/arm/boot/dts/kirkwood-dir665.dts +0 -1
@@ -232,7 +232,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <ð0port>; fixed-link { speed = <1000>;
arch/arm/boot/dts/kirkwood-l-50.dts +0 -1
@@ -254,7 +254,6 @@ fixed-link { port@6 { reg = <6>; - label = "cpu"; phy-mode = "rgmii-id"; ethernet = <ð1port>; fixed-link {
arch/arm/boot/dts/kirkwood-linksys-viper.dts +0 -1
@@ -198,7 +198,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð0port>; fixed-link { speed = <1000>;
arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts +0 -1
@@ -149,7 +149,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð0port>; fixed-link { speed = <1000>;
arch/arm/boot/dts/kirkwood-rd88f6281.dtsi +0 -1
@@ -105,7 +105,6 @@ port@3 { port@5 { reg = <5>; - label = "cpu"; ethernet = <ð0port>; fixed-link { speed = <1000>;
arch/arm/boot/dts/mt7623a-rfb-emmc.dts +0 -1
@@ -171,7 +171,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";
arch/arm/boot/dts/mt7623a-rfb-nand.dts +0 -1
@@ -175,7 +175,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +0 -1
@@ -228,7 +228,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";
arch/arm/boot/dts/mt7623n-rfb-emmc.dts +0 -1
@@ -225,7 +225,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";
arch/arm/boot/dts/orion5x-netgear-wnr854t.dts +0 -1
@@ -137,7 +137,6 @@ port@2 { port@3 { reg = <3>; - label = "cpu"; ethernet = <ðport>; };
arch/arm/boot/dts/qcom-ipq8064-rb3011.dts +0 -2
@@ -55,7 +55,6 @@ ports { switch0cpu: port@0 { reg = <0>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "rgmii-id"; fixed-link {
@@ -122,7 +121,6 @@ ports { switch1cpu: port@0 { reg = <0>; - label = "cpu"; ethernet = <&gmac3>; phy-mode = "sgmii"; fixed-link {
arch/arm/boot/dts/r9a06g032.dtsi +0 -1
@@ -401,7 +401,6 @@ switch_port3: port@3 { switch_port4: port@4 { reg = <4>; ethernet = <&gmac2>; - label = "cpu"; phy-mode = "internal"; status = "disabled"; fixed-link {
arch/arm/boot/dts/stm32mp151a-prtt1c.dts +0 -1
@@ -290,7 +290,6 @@ port@3 { port@4 { reg = <4>; - label = "cpu"; ethernet = <ðernet0>; phy-mode = "rmii";
arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts +0 -1
@@ -169,7 +169,6 @@ port4: port@4 { port8: port@8 { reg = <8>; - label = "cpu"; ethernet = <&gmac>; phy-mode = "rgmii-txid"; fixed-link {
arch/arm/boot/dts/vf610-zii-cfu1.dts +0 -1
@@ -202,7 +202,6 @@ port@5 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +0 -1
@@ -75,7 +75,6 @@ fixed-link { port@6 { reg = <6>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +0 -1
@@ -44,7 +44,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-scu4-aib.dts +0 -1
@@ -59,7 +59,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-spb4.dts +0 -1
@@ -140,7 +140,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts +0 -1
@@ -129,7 +129,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts +0 -1
@@ -154,7 +154,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
Signature · 1 line
2.34.1
Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding
CC cleger
Quoted 5 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>arch/arm/boot/dts/r9a06g032.dtsi | 1 -
arch/arm/boot/dts/r9a06g032.dtsi switch_port3: port@3 { · line 406
Quoted 10 lines
arch/arm/boot/dts/r9a06g032.dtsi +0
-1@@ -401,7 +401,6 @@ switch_port3: port@3 { switch_port4: port@4 { reg = <4>; ethernet = <&gmac2>; - label = "cpu"; phy-mode = "internal"; status = "disabled"; fixed-link {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALQuoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 1 - arch/arm/boot/dts/imx6qp-prtwd3.dts | 1 -
Thx!
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALOn Wed, Nov 30, 2022 at 05:10:37PM +0300, Arınç ÜNAL wrote:
[..]
Quoted 1 line
arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 --
Regards,
Bjorn
Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALQuoted 3 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>
Yours,
Linus Walleij
Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALDne sreda, 30. november 2022 ob 15:10:37 CET je Arınç ÜNAL napisal(a):
Quoted 64 lines
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/arm/boot/dts/armada-370-rd.dts | 1 - arch/arm/boot/dts/armada-381-netgear-gs110emx.dts | 1 - arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dts | 1 - arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dts | 1 - arch/arm/boot/dts/armada-385-linksys.dtsi | 1 - arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 - arch/arm/boot/dts/armada-388-clearfog.dts | 1 - arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 - arch/arm/boot/dts/at91-sama5d2_icp.dts | 1 - arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts | 1 - arch/arm/boot/dts/bcm-cygnus.dtsi | 1 - arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp-common.dtsi | 1 - arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts | 1 - arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts | 1 - arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 1 - arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 1 - arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 1 - arch/arm/boot/dts/bcm47081-luxul-xap-1410.dts | 1 - arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts | 1 - arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 1 - arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 3 --- arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 1 - arch/arm/boot/dts/bcm47094-linksys-panamera.dts | 4 ---- arch/arm/boot/dts/bcm47094-luxul-abr-4500.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xap-1610.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xbr-4500.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwc-2000.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts | 1 - arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts | 1 - arch/arm/boot/dts/bcm47189-tenda-ac9.dts | 1 - arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 1 - arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 1 - arch/arm/boot/dts/bcm953012er.dts | 1 - arch/arm/boot/dts/bcm958622hr.dts | 1 - arch/arm/boot/dts/bcm958623hr.dts | 1 - arch/arm/boot/dts/bcm958625hr.dts | 1 - arch/arm/boot/dts/bcm958625k.dts | 1 - arch/arm/boot/dts/bcm988312hr.dts | 1 - arch/arm/boot/dts/gemini-dlink-dir-685.dts | 1 - arch/arm/boot/dts/gemini-sl93512r.dts | 1 - arch/arm/boot/dts/gemini-sq201.dts | 1 - arch/arm/boot/dts/imx51-zii-rdu1.dts | 1 - arch/arm/boot/dts/imx51-zii-scu2-mezz.dts | 1 - arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 1 - arch/arm/boot/dts/imx53-kp-hsc.dts | 1 - arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 1 - arch/arm/boot/dts/imx6q-b450v3.dts | 1 - arch/arm/boot/dts/imx6q-b650v3.dts | 1 - arch/arm/boot/dts/imx6q-b850v3.dts | 1 - arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 1 - arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 1 - arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 1 - arch/arm/boot/dts/imx6qp-prtwd3.dts | 1 - arch/arm/boot/dts/imx7d-zii-rpu2.dts | 1 - arch/arm/boot/dts/kirkwood-dir665.dts | 1 - arch/arm/boot/dts/kirkwood-l-50.dts | 1 - arch/arm/boot/dts/kirkwood-linksys-viper.dts | 1 - arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 1 - arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 1 - arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 1 -
Quoted 8 lines
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 1 - arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 - arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 1 - arch/arm/boot/dts/orion5x-netgear-wnr854t.dts | 1 - arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 -- arch/arm/boot/dts/r9a06g032.dtsi | 1 - arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 1 - arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 1 -
For sun7i:
Best regards,
Jernej
Quoted 8 lines
arch/arm/boot/dts/vf610-zii-cfu1.dts | 1 - arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 1 - arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 1 - arch/arm/boot/dts/vf610-zii-scu4-aib.dts | 1 - arch/arm/boot/dts/vf610-zii-spb4.dts | 1 - arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 1 - arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 1 - 75 files changed, 81 deletions(-)
PATCH 3/5 arm64: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALThis is not used by the DSA dt-binding, so remove it from all devicetrees.
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 1 - arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 1 - arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 1 - arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 1 - arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 -- arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 1 - arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 - arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 1 - arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 1 - arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 1 - arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 1 - arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 1 - 13 files changed, 14 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +0 -1
@@ -662,7 +662,6 @@ lan4: port@3 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&fec1>; phy-mode = "rgmii-id";
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +0 -1
@@ -546,7 +546,6 @@ lan5: port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&fec>; phy-mode = "rgmii-id";
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi +0 -1
@@ -177,7 +177,6 @@ port@1 { port@2 { reg = <2>; - label = "cpu"; ethernet = <&fec1>; fixed-link {
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0 -1
@@ -159,7 +159,6 @@ ports { switch0port0: port@0 { reg = <0>; - label = "cpu"; ethernet = <ð0>; phy-mode = "rgmii-id"; fixed-link {
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +0 -2
@@ -400,7 +400,6 @@ port@8 { port@9 { reg = <0x9>; - label = "cpu"; ethernet = <ð1>; phy-mode = "2500base-x"; managed = "in-band-status";
@@ -485,7 +484,6 @@ port@4 { port@5 { reg = <0x5>; - label = "cpu"; phy-mode = "2500base-x"; managed = "in-band-status"; ethernet = <ð1>;
arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts +0 -1
@@ -344,7 +344,6 @@ swport4: port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&cp0_eth1>; phy-mode = "2500base-x"; managed = "in-band-status";
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +0 -1
@@ -534,7 +534,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&cp1_eth2>; phy-mode = "2500base-x"; managed = "in-band-status";
arch/arm64/boot/dts/marvell/cn9130-crb.dtsi +0 -1
@@ -282,7 +282,6 @@ port@9 { port@a { reg = <10>; - label = "cpu"; ethernet = <&cp0_eth0>; };
arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +0 -1
@@ -183,7 +183,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "2500base-x";
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts +0 -1
@@ -156,7 +156,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "2500base-x";
arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts +0 -1
@@ -172,7 +172,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "2500base-x";
arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts +0 -1
@@ -84,7 +84,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "2500base-x";
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts +0 -1
@@ -552,7 +552,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "rgmii";
Signature · 1 line
2.34.1
Re: [PATCH 3/5] arm64: dts: remove label = "cpu" from DSA dt-binding
Am Mittwoch, 30. November 2022, 15:10:38 CET schrieb Arınç ÜNAL:
Quoted 11 lines
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts port@4 { · line 557
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts +0
-1@@ -552,7 +552,6 @@ port@4 { port@5 { reg = <5>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "rgmii";
Rockchip-part:
PATCH 4/5 mips: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALThis is not used by the DSA dt-binding, so remove it from all devicetrees.
--- arch/mips/boot/dts/qca/ar9331.dtsi | 1 - arch/mips/boot/dts/ralink/mt7621.dtsi | 1 - 2 files changed, 2 deletions(-)
arch/mips/boot/dts/qca/ar9331.dtsi +0 -1
@@ -176,7 +176,6 @@ ports { switch_port0: port@0 { reg = <0x0>; - label = "cpu"; ethernet = <ð1>; phy-mode = "gmii";
arch/mips/boot/dts/ralink/mt7621.dtsi +0 -1
@@ -386,7 +386,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";
Signature · 1 line
2.34.1
Re: [PATCH 4/5] mips: dts: remove label = "cpu" from DSA dt-binding
Quoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/mips/boot/dts/ralink/mt7621.dtsi | 1 -
Thanks,
Sergio Paracuellos
Re: [PATCH 4/5] mips: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALQuoted 13 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/mips/boot/dts/qca/ar9331.dtsi | 1 - arch/mips/boot/dts/ralink/mt7621.dtsi | 1 - 2 files changed, 2 deletions(-)arch/mips/boot/dts/qca/ar9331.dtsi +0
-0
arch/mips/boot/dts/qca/ar9331.dtsi ports { · line 181
Quoted 7 lines
arch/mips/boot/dts/qca/ar9331.dtsi +0
-1@@ -176,7 +176,6 @@ ports { switch_port0: port@0 { reg = <0x0>; - label = "cpu"; ethernet = <ð1>; phy-mode = "gmii";
Thx!
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: [PATCH 4/5] mips: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALQuoted 34 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/mips/boot/dts/qca/ar9331.dtsi | 1 - arch/mips/boot/dts/ralink/mt7621.dtsi | 1 - 2 files changed, 2 deletions(-)arch/mips/boot/dts/qca/ar9331.dtsi +0
-1@@ -176,7 +176,6 @@ ports { switch_port0: port@0 { reg = <0x0>; - label = "cpu"; ethernet = <ð1>; phy-mode = "gmii";arch/mips/boot/dts/ralink/mt7621.dtsi +0
-1@@ -386,7 +386,6 @@ port@4 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&gmac0>; phy-mode = "trgmii";Signature · 1 line
2.34.1
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
PATCH 5/5 powerpc: dts: remove label = "cpu" from DSA dt-binding
In reply to Arınç ÜNALThis is not used by the DSA dt-binding, so remove it from all devicetrees.
--- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)
arch/powerpc/boot/dts/turris1x.dts +0 -2
@@ -147,7 +147,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&enet1>; phy-mode = "rgmii-id";
@@ -184,7 +183,6 @@ port@5 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&enet0>; phy-mode = "rgmii-id";
Signature · 1 line
2.34.1
Michael Ellerman
reviewerRe: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)
Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d ("powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes")
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to be updated.
cheers
Quoted 22 lines
arch/powerpc/boot/dts/turris1x.dts +0
-2@@ -147,7 +147,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&enet1>; phy-mode = "rgmii-id";@@ -184,7 +183,6 @@ port@5 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&enet0>; phy-mode = "rgmii-id";Signature · 1 line
2.34.1
Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 14 lines · On Thursday 01 December 2022 21:40:03 Michael Ellerman wrote:
Quoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d("powerpc: dts:turris1x.dts: Fix labels in DSA cpu port nodes")
Quoted 8 lines
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to be updated.
cheers
I was told by Marek (CCed) that DSA port connected to CPU should have label "cpu" and not "cpu<number>". Modern way for specifying CPU port is by defining reference to network device, which there is already (&enet1 and &enet0). So that change just "fixed" incorrect naming cpu0 and cpu1.
So probably linux kernel does not need label = "cpu" in DTS anymore. But this is not the reason to remove this property. Linux kernel does not use lot of other nodes and properties too... Device tree should describe hardware and not its usage in Linux. "label" property is valid in device tree and it exactly describes what or where is this node connected. And it may be used for other systems.
So I do not see a point in removing "label" properties from turris1x.dts file, nor from any other dts file.
Quoted 23 lines
Quoted 23 lines
arch/powerpc/boot/dts/turris1x.dts +0
-2@@ -147,7 +147,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&enet1>; phy-mode = "rgmii-id";@@ -184,7 +183,6 @@ port@5 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&enet0>; phy-mode = "rgmii-id";Signature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 36 lines · Pali Rohár
Quoted 14 lines · On Thursday 01 December 2022 21:40:03 Michael Ellerman wrote:
Quoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d("powerpc: dts:turris1x.dts: Fix labels in DSA cpu port nodes")Quoted 8 lines
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to be updated.
cheers
I was told by Marek (CCed) that DSA port connected to CPU should have label "cpu" and not "cpu<number>". Modern way for specifying CPU port is by defining reference to network device, which there is already (&enet1 and &enet0). So that change just "fixed" incorrect naming cpu0 and cpu1.
So probably linux kernel does not need label = "cpu" in DTS anymore. But this is not the reason to remove this property. Linux kernel does not use lot of other nodes and properties too... Device tree should describe hardware and not its usage in Linux. "label" property is valid in device tree and it exactly describes what or where is this node connected. And it may be used for other systems.
Quoted 2 lines
So I do not see a point in removing "label" properties from
turris1x.dtsfile, nor from any other dts file.
Well, it seems like a bit of an abuse of 'label' to me. 'label' should be aligned with a sticker or other identifier identifying something to a human. Software should never care what the value of 'label' is.
Rob
Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 37 lines · On Thursday 01 December 2022 17:44:00 Rob Herring wrote:
Quoted 36 lines · Pali Rohár
Quoted 14 lines · On Thursday 01 December 2022 21:40:03 Michael Ellerman wrote:
Quoted 6 lines · Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees.
Signed-off-by Arınç ÜNAL <[email protected]>--- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d("powerpc: dts:turris1x.dts: Fix labels in DSA cpu port nodes")Quoted 8 lines
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to be updated.
cheers
I was told by Marek (CCed) that DSA port connected to CPU should have label "cpu" and not "cpu<number>". Modern way for specifying CPU port is by defining reference to network device, which there is already (&enet1 and &enet0). So that change just "fixed" incorrect naming cpu0 and cpu1.
So probably linux kernel does not need label = "cpu" in DTS anymore. But this is not the reason to remove this property. Linux kernel does not use lot of other nodes and properties too... Device tree should describe hardware and not its usage in Linux. "label" property is valid in device tree and it exactly describes what or where is this node connected. And it may be used for other systems.
Quoted 8 lines
Quoted 2 lines
So I do not see a point in removing "label" properties from
turris1x.dtsfile, nor from any other dts file.Well, it seems like a bit of an abuse of 'label' to me. 'label' should be aligned with a sticker or other identifier identifying something to a human. Software should never care what the value of 'label' is.
Rob
But it already does. "label" property is used for setting (initial) network interface name for DSA drivers. And you can try to call e.g. git grep '"cpu"' net/dsa drivers/net/dsa to see that cpu is still present on some dsa places (probably relict or backward compatibility before eth reference).
I agree with you that in this case it is abuse. But I would not say that software should not care about "label". I think that software should care about "label" but only in situation in which it presents information to user. So if user wants to see device with labels *ABC* (meaning show me anything which stickers contains substring ABC) then software should filter devices and turns that with asked label.
The main problem here is _existing_ software. New software should really do not use cpu label for deciding if network port is connected to cpu or not and it should be designed correctly. But you cannot change nor fix old / existing software...
The worst thing which can be done is breaking updated version of (old) software. Prevention is always testing software and in this case testing on the real hardware. I know, it is hard as developers do not have such lot of hardware devices and configurations.
Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Hi Pali,
Quoted 21 lines · Pali Rohár
Quoted 13 lines · On Thursday 01 December 2022 17:44:00 Rob Herring wrote:
Quoted 12 lines · Pali Rohár
I was told by Marek (CCed) that DSA port connected to CPU should have label "cpu" and not "cpu<number>". Modern way for specifying CPU port is by defining reference to network device, which there is already (&enet1 and &enet0). So that change just "fixed" incorrect naming cpu0 and cpu1.
So probably linux kernel does not need label = "cpu" in DTS anymore. But this is not the reason to remove this property. Linux kernel does not use lot of other nodes and properties too... Device tree should describe hardware and not its usage in Linux. "label" property is valid in device tree and it exactly describes what or where is this node connected. And it may be used for other systems.
Quoted 6 lines
Quoted 2 lines
So I do not see a point in removing "label" properties from
turris1x.dtsfile, nor from any other dts file.Well, it seems like a bit of an abuse of 'label' to me. 'label' should be aligned with a sticker or other identifier identifying something to a human. Software should never care what the value of 'label' is.
Quoted 5 lines
But it already does. "label" property is used for setting (initial) network interface name for DSA drivers. And you can try to call e.g. git grep '"cpu"' net/dsa
drivers/net/dsato see that cpu is still present on some dsa places (probably relict or backward compatibility before eth reference).
Can you try to eliminate the word "probably" from the information you transmit and be specific about when did the DSA binding parse or require the 'label = "cpu"' property for CPU ports in any way?
Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 30 lines · Vladimir Oltean
Hi Pali,
Quoted 21 lines · Pali Rohár
Quoted 13 lines · On Thursday 01 December 2022 17:44:00 Rob Herring wrote:
Quoted 12 lines · Pali Rohár
I was told by Marek (CCed) that DSA port connected to CPU should have label "cpu" and not "cpu<number>". Modern way for specifying CPU port is by defining reference to network device, which there is already (&enet1 and &enet0). So that change just "fixed" incorrect naming cpu0 and cpu1.
So probably linux kernel does not need label = "cpu" in DTS anymore. But this is not the reason to remove this property. Linux kernel does not use lot of other nodes and properties too... Device tree should describe hardware and not its usage in Linux. "label" property is valid in device tree and it exactly describes what or where is this node connected. And it may be used for other systems.
Quoted 6 lines
Quoted 2 lines
So I do not see a point in removing "label" properties from
turris1x.dtsfile, nor from any other dts file.Well, it seems like a bit of an abuse of 'label' to me. 'label' should be aligned with a sticker or other identifier identifying something to a human. Software should never care what the value of 'label' is.
Quoted 5 lines
But it already does. "label" property is used for setting (initial) network interface name for DSA drivers. And you can try to call e.g. git grep '"cpu"' net/dsa
drivers/net/dsato see that cpu is still present on some dsa places (probably relict or backward compatibility before eth reference).
Quoted 3 lines
Can you try to eliminate the word "probably" from the information you transmit and be specific about when did the DSA binding parse or require the 'label = "cpu"' property for CPU ports in any way?
As Jonas (on CC) pointed out, I only see this being used in the swconfig b53 driver which uses the label to identify the cpu port.
Maybe this got into DSA dt-bindings unchecked before it was decided to move forward with DSA instead of swconfig on Linux.
Arınç
Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
Quoted 7 lines · Arınç ÜNAL
As Jonas (on CC) pointed out, I only see this being used in the swconfig b53 driver which uses the label to identify the cpu port.
Maybe this got into DSA dt-bindings unchecked before it was decided to move forward with DSA instead of swconfig on Linux.
Yes, but swconfig is not DSA and their bindings are not compatible anyway (swconfig lacks an ethernet = <&phandle> property that would allow DSA to work). Still waiting for Pali to clarify what he had in mind.
Quoted 10 lines · Arınç ÜNAL
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)
Hi Arınç
So your plan is that each architecture maintainer merges one patch?
That is fine, but it is good to be explicit, otherwise patches will fall through the cracks because nobody picks them up. I generally use
To: to indicate who i expect to merge a patch, and everybody else in the Cc:
Andrew
Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Arınç ÜNAL
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)
Quoted 3 lines
Hi Arınç
So your plan is that each architecture maintainer merges one patch?
Initially, I sent this series to [email protected] to take it all but Rob said it must be this way instead.
Quoted 5 lines
That is fine, but it is good to be explicit, otherwise patches will fall through the cracks because nobody picks them up. I generally use
To: to indicate who i expect to merge a patch, and everybody else in the Cc:
Thanks for this, I'll follow suit if I don't see any activity for a few weeks.
Quoted 4 lines
Reviewed-by Andrew Lunn <[email protected]>Andrew
Arınç
Michael Ellerman
reviewerQuoted 21 lines · Arınç ÜNAL
Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Arınç ÜNAL
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)Quoted 3 lines
Hi Arınç
So your plan is that each architecture maintainer merges one patch?
Initially, I sent this series to [email protected] to take it all but Rob said it must be this way instead.
Quoted 1 line
Quoted 7 lines
Quoted 4 lines
That is fine, but it is good to be explicit, otherwise patches will fall through the cracks because nobody picks them up. I generally use
To: to indicate who i expect to merge a patch, and everybody else in the Cc:Thanks for this, I'll follow suit if I don't see any activity for a few weeks.
IMHO the best solution if the patches are truly independent is to send them independantly to each maintainer. That way there's no confusion about whether someone else will take the series.
It's also simpler for maintainers to apply a single standalone patch vs pick a single patch from a larger series.
cheers
Quoted 30 lines · Michael Ellerman
Quoted 21 lines · Arınç ÜNAL
Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Arınç ÜNAL
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)Quoted 3 lines
Hi Arınç
So your plan is that each architecture maintainer merges one patch?
Initially, I sent this series to [email protected] to take it all but Rob said it must be this way instead.
Quoted 1 line
Quoted 7 lines
Quoted 4 lines
That is fine, but it is good to be explicit, otherwise patches will fall through the cracks because nobody picks them up. I generally use
To: to indicate who i expect to merge a patch, and everybody else in the Cc:Thanks for this, I'll follow suit if I don't see any activity for a few weeks.
Quoted 6 lines
IMHO the best solution if the patches are truly independent is to send them independantly to each maintainer. That way there's no confusion about whether someone else will take the series.
It's also simpler for maintainers to apply a single standalone patch vs pick a single patch from a larger series.
I agree. I'll do that next time.
Cheers.
Arınç
I'm sending a more specific mail to make sure this series doesn't fall through the cracks like Andrew said. I'd like this merged this week before the merge window closes.
Jakub, please take patch 1. Arnd, please take patch 2 and 3. Thomas, please take patch 4. Michael, please take patch 5.
Arınç
Quoted 41 lines · Arınç ÜNAL
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)I've been meaning to submit this for a few months. Find the relevant conversation here:
https://lore.kernel.org/netdev/[email protected]/Here's how I did it, for the interested (or suggestions):
Find the platforms which have got 'label = "cpu";' defined. grep -rnw . -e 'label = "cpu";'
Remove the line where 'label = "cpu";' is included.
sed -i /'label = "cpu";'/,+darch/arm/boot/dts/*
sed -i /'label = "cpu";'/,+darch/arm64/boot/dts/freescale/*
sed -i /'label = "cpu";'/,+darch/arm64/boot/dts/marvell/*
sed -i /'label = "cpu";'/,+darch/arm64/boot/dts/mediatek/*
sed -i /'label = "cpu";'/,+darch/arm64/boot/dts/rockchip/*
sed -i /'label = "cpu";'/,+darch/mips/boot/dts/qca/*
sed -i /'label = "cpu";'/,+darch/mips/boot/dts/ralink/*
sed -i /'label = "cpu";'/,+darch/powerpc/boot/dts/turris1x.dts
sed -i /'label = "cpu";'/,+dDocumentation/devicetree/bindings/net/qca,ar71xx.yamlRestore the symlink files which typechange after running sed.
Arınç ÜNAL (5):
dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
arm: dts: remove label = "cpu" from DSA dt-binding
arm64: dts: remove label = "cpu" from DSA dt-binding
mips: dts: remove label = "cpu" from DSA dt-binding
powerpc: dts: remove label = "cpu" from DSA dt-binding
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 5 lines · On Wed, 30 Nov 2022 17:10:35 +0300 you wrote:
Hello folks,
With this patch series, we're completely getting rid of 'label = "cpu";' which is not used by the DSA dt-binding at all.
Quoted 7 lines
Information for taking the patches for maintainers:
Patch 1: netdev maintainers (based off netdev/net-next.git main) Patch 2-3: SoC maintainers (based off soc/soc.git soc/dt) Patch 4: MIPS maintainers (based off mips/linux.git mips-next) Patch 5: PowerPC maintainers (based off powerpc/linux.git next-test)[...]
Here is the summary with links:
- [1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples
https://git.kernel.org/netdev/net-next/c/ce36d7ef4e08
- [2/5] arm: dts: remove label = "cpu" from DSA dt-binding (no matching commit)
- [3/5] arm64: dts: remove label = "cpu" from DSA dt-binding (no matching commit)
- [4/5] mips: dts: remove label = "cpu" from DSA dt-binding (no matching commit)
- [5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding (no matching commit)
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html