Skip to contentSkip to conversation

polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

PATCH In review Lei Maohui 3 participants 3 messages Dec 7, 2022 – Dec 9, 2022

lore
Share & tools
lore

Lei Maohui

author
#0 lore raw

PATCH 1/1 polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
/usr/lib/polkit-1/polkit-agent-helper-1
/usr/lib/polkit-1/polkitd
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
polkit: 2 installed and not shipped files. [installed-vs-shipped]

---
 meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/polkit/polkit_122.bb +3 -1
index dfa6c14a4..a7cfbdd62 100644
@@ -46,4 +46,6 @@ do_install:append() {
 	chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
 }
 
-FILES:${PN} += "${libdir}/polkit-1 ${datadir}"
+FILES:${PN} += "${libdir}/polkit-1 ${datadir} \
+                ${nonarch_libdir}/${BPN}-1 \
+               "
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of leimaohui
Sent: den 7 december 2022 04:14
To: [email protected]
Cc: Lei Maohui <[email protected]>
Subject: [oe] [meta-oe][PATCH] polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

That is a very long subject, way longer than the recommendations. I suggest you change it to something shorter, e.g.:

polkit: Make it build with multilib

Quoted 17 lines

ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
/usr/lib/polkit-1/polkit-agent-helper-1
/usr/lib/polkit-1/polkitd
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
polkit: 2 installed and not shipped files. [installed-vs-shipped]

---
 meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/polkit/polkit_122.bb +0 -0
index dfa6c14a4..a7cfbdd62 100644

meta-oe/recipes-extended/polkit/polkit_122.bb do_install:append() { · line 51

Quoted 7 lines
meta-oe/recipes-extended/polkit/polkit_122.bb +3 -1
@@ -46,4 +46,6 @@ do_install:append() {
 	chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
 }
 
-FILES:${PN} += "${libdir}/polkit-1 ${datadir}"
+FILES:${PN} += "${libdir}/polkit-1 ${datadir} \
+                ${nonarch_libdir}/${BPN}-1 \
+               "

It would be more obvious what's going on if you change the above to:

FILES:${PN} += "${libdir}/polkit-1 ${nonarch_libdir}/polkit-1 ${datadir}"

Quoted 2 lines

--
2.25.1

//Peter

#2 lore raw

Thanks for review Peter, I have made these changes on master-next

Quoted 56 lines · Peter Kjellerstedt
Quoted 7 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of leimaohui
Sent: den 7 december 2022 04:14
To: [email protected]
Cc: Lei Maohui <[email protected]>
Subject: [oe] [meta-oe][PATCH] polkit: Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when enable multilib.

That is a very long subject, way longer than the recommendations. I suggest you change it to something shorter, e.g.:

polkit: Make it build with multilib

Quoted 17 lines

ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
/usr/lib/polkit-1/polkit-agent-helper-1
/usr/lib/polkit-1/polkitd
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
polkit: 2 installed and not shipped files. [installed-vs-shipped]

---
 meta-oe/recipes-extended/polkit/polkit_122.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-extended/polkit/polkit_122.bb +0 -0
index dfa6c14a4..a7cfbdd62 100644

meta-oe/recipes-extended/polkit/polkit_122.bb do_install:append() { · line 51

Quoted 7 lines
meta-oe/recipes-extended/polkit/polkit_122.bb +3 -1
@@ -46,4 +46,6 @@ do_install:append() {
      chown polkitd:root ${D}/${datadir}/polkit-1/rules.d
 }
 
-FILES:${PN} += "${libdir}/polkit-1 ${datadir}"
+FILES:${PN} += "${libdir}/polkit-1 ${datadir} \
+                ${nonarch_libdir}/${BPN}-1 \
+               "

It would be more obvious what's going on if you change the above to:

FILES:${PN} += "${libdir}/polkit-1 ${nonarch_libdir}/polkit-1 ${datadir}"

Quoted 2 lines

--
2.25.1

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#100000): https://lists.openembedded.org/g/openembedded-devel/message/100000
Mute This Topic: https://lists.openembedded.org/mt/95509198/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-