Skip to contentSkip to conversation

bonding: get correct NA dest address

PATCH Applied Hangbin Liu 5 participants 5 messages Dec 6, 2022 – Dec 7, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding: get correct NA dest address

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages"), there is a copy/paste issue for NA daddr. I found that in my testing and fixed it in my local branch. But I forgot to re-format the patch and sent the wrong mail.

Fix it by reading the correct dest address.

Fixes 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
---
 drivers/net/bonding/bond_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
index f298b9b3eb77..b9a882f182d2 100644
@@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
 		goto out;
 
 	saddr = &combined->ip6.saddr;
-	daddr = &combined->ip6.saddr;
+	daddr = &combined->ip6.daddr;
 
 	slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
 		  __func__, slave->dev->name, bond_slave_state(slave),
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Hangbin Liu

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages"), there is a copy/paste issue for NA daddr. I found that in my testing and fixed it in my local branch. But I forgot to re-format the patch and sent the wrong mail.

Fix it by reading the correct dest address.

Fixes 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
---
 drivers/net/bonding/bond_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +0 -0
index f298b9b3eb77..b9a882f182d2 100644

drivers/net/bonding/bond_main.c static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond, · line 3251

Quoted 6 lines
drivers/net/bonding/bond_main.c +1 -1
@@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
                goto out;
 
        saddr = &combined->ip6.saddr;
-       daddr = &combined->ip6.saddr;
+       daddr = &combined->ip6.daddr;
 

Indeed, thanks.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Hangbin Liu
Quoted 9 lines · Tue, Dec 06, 2022 at 04:20:55AM CET, [email protected] wrote:

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages"), there is a copy/paste issue for NA daddr. I found that in my testing and fixed it in my local branch. But I forgot to re-format the patch and sent the wrong mail.

Fix it by reading the correct dest address.

Fixes 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
Acked-by on v1 1/1
#3 lore raw
In reply to Hangbin Liu
Quoted 9 lines · Hangbin Liu

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages"), there is a copy/paste issue for NA daddr. I found that in my testing and fixed it in my local branch. But I forgot to re-format the patch and sent the wrong mail.

Fix it by reading the correct dest address.

Fixes 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
Quoted 17 lines
---
  drivers/net/bonding/bond_main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
index f298b9b3eb77..b9a882f182d2 100644
@@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
  		goto out;
 
  	saddr = &combined->ip6.saddr;
-	daddr = &combined->ip6.saddr;
+	daddr = &combined->ip6.daddr;
 
  	slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
  		  __func__, slave->dev->name, bond_slave_state(slave),
#4 lore raw
In reply to Hangbin Liu
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 6 Dec 2022 11:20:55 +0800 you wrote:

In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages"), there is a copy/paste issue for NA daddr. I found that in my testing and fixed it in my local branch. But I forgot to re-format the patch and sent the wrong mail.

Fix it by reading the correct dest address.

[...]

Here is the summary with links:
- [net] bonding: get correct NA dest address

    https://git.kernel.org/netdev/net/c/1f154f3b56a1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html