Skip to contentSkip to conversation

net: hns3: use strscpy() to instead of strncpy()

PATCH Applied [email protected] 3 participants 3 messages Dec 9, 2022 – Dec 12, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: hns3: use strscpy() to instead of strncpy()

From: Xu Panda <[email protected]>

The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.

---
change for v2
- change the subject, replace linux-next with net-next.

---
 drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c +2 -4
index cdf76fb58d45..55306fe8a540 100644
@@ -639,13 +639,11 @@ static void hns3_get_drvinfo(struct net_device *netdev,
 		return;
 	}
 
-	strncpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
+	strscpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
 		sizeof(drvinfo->driver));
-	drvinfo->driver[sizeof(drvinfo->driver) - 1] = '\0';
 
-	strncpy(drvinfo->bus_info, pci_name(h->pdev),
+	strscpy(drvinfo->bus_info, pci_name(h->pdev),
 		sizeof(drvinfo->bus_info));
-	drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0';
 
 	fw_version = priv->ae_handle->ae_algo->ops->get_fw_version(h);
 
Signature · 1 line
2.15.2
#2 lore raw
In reply to [email protected]
This patch was applied to bpf/bpf-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 9 Dec 2022 15:38:59 +0800 (CST) you wrote:

From: Xu Panda <[email protected]>

The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.

[...]

Here is the summary with links:
- [net-next] net: hns3: use strscpy() to instead of strncpy()

    https://git.kernel.org/bpf/bpf-next/c/80a464d83f08

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html