Skip to contentSkip to conversation

soc: tegra: fix CPU_BIG_ENDIAN dependencies

PATCH Applied Arnd Bergmann 3 participants 3 messages Dec 15, 2022 – Dec 19, 2022 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: tegra: fix CPU_BIG_ENDIAN dependencies

From: Arnd Bergmann <[email protected]>

My previous patch to prevent BPMP from being enabled on big endian kernels caused a build regression:

WARNING: unmet direct dependencies detected for TEGRA_BPMP
Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y] Selected by [y]:
- ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]

Add even more such dependencies for the SoC types that use the BPMP driver.

Fixes 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
---
 drivers/soc/tegra/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/soc/tegra/Kconfig +3 -0
index 5f5324294636..3658fb0f0c5b 100644
@@ -95,6 +95,7 @@ config ARCH_TEGRA_210_SOC
 
 config ARCH_TEGRA_186_SOC
 	bool "NVIDIA Tegra186 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select TEGRA_BPMP
 	select TEGRA_HSP_MBOX
@@ -110,6 +111,7 @@ config ARCH_TEGRA_186_SOC
 
 config ARCH_TEGRA_194_SOC
 	bool "NVIDIA Tegra194 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select PINCTRL_TEGRA194
 	select TEGRA_BPMP
@@ -121,6 +123,7 @@ config ARCH_TEGRA_194_SOC
 
 config ARCH_TEGRA_234_SOC
 	bool "NVIDIA Tegra234 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select TEGRA_BPMP
 	select TEGRA_HSP_MBOX
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

My previous patch to prevent BPMP from being enabled on big endian kernels caused a build regression:

WARNING: unmet direct dependencies detected for TEGRA_BPMP
Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y] Selected by [y]:
- ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]

Quoted 8 lines

Add even more such dependencies for the SoC types that use the BPMP driver.

Fixes 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
---
 drivers/soc/tegra/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Do you want to pick this up into ARM SoC directly? If so:

#2 lore raw
In reply to Arnd Bergmann
This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <[email protected]>:

Quoted 5 lines · On Thu, 15 Dec 2022 17:53:21 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

My previous patch to prevent BPMP from being enabled on big endian kernels caused a build regression:

Quoted 8 lines

WARNING: unmet direct dependencies detected for TEGRA_BPMP
Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y] Selected by [y]:
- ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
- ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]

[...]

Here is the summary with links:
- soc: tegra: fix CPU_BIG_ENDIAN dependencies

    https://git.kernel.org/soc/soc/c/ba4b4d0293ed

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html