Skip to contentSkip to conversation

Return unused memory to hypervisor

PATCH Miroslav Rezanina 2 participants 2 messages Sep 17, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 976992170.207631253175200763.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com

#1 lore raw

Hi Jeremy,
I check your application. It won't work correctly. You are calling return_unused_memory in xen_memory_setup that is too soon. When you are calling it, there is no hole in map in any case. Calling should be in xen_post_allocator_init function (in arch/x86/xen/mmu.c).

Mirek

Quoted 22 lines · ----- "Jeremy Fitzhardinge

From: "Jeremy Fitzhardinge" <[email protected]>
To: "Miroslav Rezanina" <[email protected]>
Cc: "Konrad Rzeszutek Wilk" <[email protected]>, [email protected], [email protected]
Sent: Thursday, September 17, 2009 6:54:56 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor

Quoted 1 line · Miroslav Rezanina

Ups.....This should not be commented out. I will resent the patch

with

Quoted 1 line

correct (uncommented) line.

I've already applied a variant of your patch. Check the rebase/core-freemem branch in xen.git.

J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Miroslav Rezanina
Software Engineer - Virtualization Team - XEN kernel
#2 lore raw
Quoted 4 lines · Miroslav Rezanina

Hi Jeremy,
I check your application. It won't work correctly. You are calling return_unused_memory in xen_memory_setup that is too soon. When you are calling it, there is no hole in map in any case. Calling should be in xen_post_allocator_init function (in arch/x86/xen/mmu.c).

OK. Where does the e820 map get changed in the meantime?

J