bnxt_en: Bug fixes
Subsystems (5)
Michael Chan
maintainercover bnxt_en: Bug fixes
This series fixes a devlink bug and several XDP related bugs. The devlink bug causes a kernel crash on VF devices. The XDP driver patches fix and clean up the RX XDP path and re-enable header-data split that was disabled by mistake when adding the XDP multi-buffer support.
Michael Chan (4):
bnxt_en: Simplify bnxt_xdp_buff_init()
bnxt_en: Fix XDP RX path
bnxt_en: Fix first buffer size calculations for XDP multi-buffer
bnxt_en: Fix HDS and jumbo thresholds for RX packets
Vikas Gupta (1):
bnxt_en: fix devlink port registration to netdev
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++++++++++-------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++++++--- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 20 +++++++------- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 6 ++--- 4 files changed, 39 insertions(+), 29 deletions(-)
Signature · 1 line
2.18.1
Michael Chan
maintainerPATCH 1/5 bnxt_en: fix devlink port registration to netdev
From: Vikas Gupta <[email protected]>
We don't register a devlink port in case of a VF so avoid setting the devlink pointer to netdev. Also, SET_NETDEV_DEVLINK_PORT has to be moved so that we determine whether the device is PF/VF first.
This fixes the NULL pointer dereference of devlink_port->devlink when creating VFs:
BUG: kernel NULL pointer dereference, address: 0000000000000160 PGD 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 14 PID: 388 Comm: kworker/14:1 Kdump: loaded Not tainted 6.1.0-rc8 #5 Hardware name: Dell Inc. PowerEdge R750/06V45N, BIOS 1.3.8 08/31/2021 Workqueue: events work_for_cpu_fn RIP: 0010:devlink_nl_port_handle_size+0xb/0x50 Code: 83 c4 10 5b 5d c3 cc cc cc cc b8 a6 ff ff ff eb de e8 c9 59 21 00 66 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 53 48 8b 47 20 <48> 8b a8 60 01 00 00 48 8b 45 60 48 8b 38 e8 92 90 1a 00 48 8b 7d RSP: 0018:ff4fe5394846fcd8 EFLAGS: 00010286 RAX: 0000000000000000 RBX: 0000000000000794 RCX: 0000000000000000 RDX: ff1f129683a30a40 RSI: 0000000000000008 RDI: ff1f1296bb496188 RBP: 0000000000000334 R08: 0000000000000cc0 R09: 0000000000000000 R10: ff1f1296bb494298 R11: ffffffffffffffc0 R12: 0000000000000000 R13: 0000000000000000 R14: ff1f1296bb494000 R15: 0000000000000000 FS: 0000000000000000(0000) GS:ff1f129e5fa00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000160 CR3: 000000131f610006 CR4: 0000000000771ee0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: <TASK> if_nlmsg_size+0x14a/0x220 rtmsg_ifinfo_build_skb+0x3c/0x100 rtmsg_ifinfo+0x9c/0xc0 register_netdevice+0x59d/0x670 register_netdev+0x1c/0x40 bnxt_init_one+0x674/0xa60 [bnxt_en] local_pci_probe+0x42/0x80 work_for_cpu_fn+0x13/0x20 process_one_work+0x1e2/0x3b0 ? rescuer_thread+0x390/0x390 worker_thread+0x1c4/0x3a0 ? rescuer_thread+0x390/0x390 kthread+0xd6/0x100 ? kthread_complete_and_exit+0x20/0x20
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +4 -1
@@ -13591,7 +13591,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)return -ENOMEM ; bp =netdev_priv (dev); -SET_NETDEV_DEVLINK_PORT (dev, &bp->dl_port); bp->board_idx = ent->driver_data; bp->msg_enable =BNXT_DEF_MSG_ENABLE ;bnxt_set_max_func_irqs (bp, max_irqs);
@@ -13599,6 +13598,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)if (bnxt_vf_pciid (bp->board_idx)) bp->flags |=BNXT_FLAG_VF ; +/* No devlink port registration in case of a VF */ +if (BNXT_PF (bp)) +SET_NETDEV_DEVLINK_PORT (dev, &bp->dl_port); +if (pdev->msix_cap) bp->flags |=BNXT_FLAG_MSIX_CAP ;
Signature · 1 line
2.18.1
Michael Chan
maintainerPATCH 2/5 bnxt_en: Simplify bnxt_xdp_buff_init()
In reply to Michael Chanbnxt_xdp_buff_init() does not modify the data_ptr or the len parameters, so no need to pass in the addresses of these parameters.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 6 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
@@ -1925,7 +1925,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, dma_addr = rx_buf->mapping;if (bnxt_xdp_attached (bp, rxr)) { -bnxt_xdp_buff_init (bp, rxr, cons, &data_ptr, &len, &xdp); +bnxt_xdp_buff_init (bp, rxr, cons, data_ptr, len, &xdp);if (agg_bufs) { u32 frag_len = bnxt_rx_agg_pages_xdp(bp, cpr, &xdp, cp_cons, agg_bufs,
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +3 -3
@@ -177,7 +177,7 @@ bool bnxt_xdp_attached(struct bnxt *bp, struct bnxt_rx_ring_info *rxr) }void bnxt_xdp_buff_init (struct bnxt *bp,struct bnxt_rx_ring_info *rxr, -u16 cons,u8 **data_ptr,unsigned int *len, +u16 cons,u8 *data_ptr,unsigned int len,struct xdp_buff *xdp) {struct bnxt_sw_rx_bd *rx_buf;
@@ -191,13 +191,13 @@ void bnxt_xdp_buff_init(struct bnxt *bp, struct bnxt_rx_ring_info *rxr, offset = bp->rx_offset; mapping = rx_buf->mapping - bp->rx_dma_offset; -dma_sync_single_for_cpu (&pdev->dev, mapping + offset, *len, bp->rx_dir); +dma_sync_single_for_cpu (&pdev->dev, mapping + offset, len, bp->rx_dir);if (bp->xdp_has_frags) buflen =BNXT_PAGE_MODE_BUF_SIZE + offset;xdp_init_buff (xdp, buflen, &rxr->xdp_rxq); -xdp_prepare_buff (xdp, *data_ptr - offset, offset, *len, false); +xdp_prepare_buff (xdp, data_ptr - offset, offset, len, false); } void bnxt_xdp_buff_frags_free(struct bnxt_rx_ring_info *rxr,
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h +1 -1
@@ -27,7 +27,7 @@ int bnxt_xdp_xmit(struct net_device *dev, int num_frames,bool bnxt_xdp_attached (struct bnxt *bp,struct bnxt_rx_ring_info *rxr);void bnxt_xdp_buff_init (struct bnxt *bp,struct bnxt_rx_ring_info *rxr, -u16 cons,u8 **data_ptr,unsigned int *len, +u16 cons,u8 *data_ptr,unsigned int len,struct xdp_buff *xdp);void bnxt_xdp_buff_frags_free (struct bnxt_rx_ring_info *rxr,struct xdp_buff *xdp);
Signature · 1 line
2.18.1
Michael Chan
maintainerPATCH 3/5 bnxt_en: Fix XDP RX path
In reply to Michael ChanThe XDP program can change the starting address of the RX data buffer and this information needs to be passed back from bnxt_rx_xdp() to bnxt_rx_pkt() for the XDP_PASS case so that the SKB can point correctly to the modified buffer address. Add back the data_ptr parameter to bnxt_rx_xdp() to make this work.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 7 +++++-- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 4 ++-- 3 files changed, 8 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
@@ -1940,7 +1940,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, }if (xdp_active) { -if (bnxt_rx_xdp (bp, rxr, cons, xdp, data, &len, event)) { +if (bnxt_rx_xdp (bp, rxr, cons, xdp, data, &data_ptr, &len, event)) { rc =1 ; goto next_rx; }
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +5 -2
@@ -222,7 +222,8 @@ void bnxt_xdp_buff_frags_free(struct bnxt_rx_ring_info *rxr,* false - packet should be passed to the stack. */ bool bnxt_rx_xdp (struct bnxt *bp,struct bnxt_rx_ring_info *rxr,u16 cons, -struct xdp_buff xdp,struct page *page,unsigned int *len,u8 *event) +struct xdp_buff xdp,struct page *page,u8 **data_ptr, +unsigned int *len,u8 *event) {struct bpf_prog *xdp_prog =READ_ONCE (rxr->xdp_prog);struct bnxt_tx_ring_info *txr;
@@ -255,8 +256,10 @@ bool bnxt_rx_xdp(struct bnxt *bp, struct bnxt_rx_ring_info *rxr, u16 cons, *event &= ~BNXT_RX_EVENT ; *len = xdp.data_end - xdp.data; -if (orig_data != xdp.data) +if (orig_data != xdp.data) { offset = xdp.data - xdp.data_hard_start; + *data_ptr = xdp.data_hard_start + offset; + }switch (act) {case XDP_PASS :
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h +2 -2
@@ -18,8 +18,8 @@ struct bnxt_sw_tx_bd *bnxt_xmit_bd(struct bnxt *bp, struct xdp_buff *xdp);void bnxt_tx_int_xdp (struct bnxt *bp,struct bnxt_napi *bnapi,int nr_pkts);bool bnxt_rx_xdp (struct bnxt *bp,struct bnxt_rx_ring_info *rxr,u16 cons, -struct xdp_buff xdp,struct page *page,unsigned int *len, -u8 *event); +struct xdp_buff xdp,struct page *page,u8 **data_ptr, +unsigned int *len,u8 *event);int bnxt_xdp (struct net_device *dev,struct netdev_bpf *xdp);int bnxt_xdp_xmit (struct net_device *dev,int num_frames,struct xdp_frame **frames,u32 flags);
Signature · 1 line
2.18.1
Michael Chan
maintainerPATCH 4/5 bnxt_en: Fix first buffer size calculations for XDP multi-buffer
In reply to Michael ChanThe size of the first buffer is always page size, and the useable space is the page size minus the offset and the skb_shared_info size. Make sure SKB and XDP buf sizes match so that the skb_shared_info is at the same offset seen from the SKB and XDP_BUF.
build_skb() should be passed PAGE_SIZE. xdp_init_buff() should be passed PAGE_SIZE as well. xdp_get_shared_info_from_buff() will automatically deduct the skb_shared_info size if the XDP buffer has frags. There is no need to keep bp->xdp_has_frags.
Change BNXT_PAGE_MODE_BUF_SIZE to BNXT_MAX_PAGE_MODE_MTU_SBUF since this constant is really the MTU with ethernet header size subtracted.
Also fix the BNXT_MAX_PAGE_MODE_MTU macro with proper parentheses.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++++---- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 +++++++++++---- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 7 +------ 3 files changed, 17 insertions(+), 14 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +5 -4
@@ -991,8 +991,7 @@ static struct sk_buff *bnxt_rx_multi_page_skb(struct bnxt *bp, dma_addr -= bp->rx_dma_offset;dma_unmap_page_attrs (&bp->pdev->dev, dma_addr,PAGE_SIZE , bp->rx_dir,DMA_ATTR_WEAK_ORDERING ); - skb =build_skb (page_address (page),BNXT_PAGE_MODE_BUF_SIZE + - bp->rx_dma_offset); + skb =build_skb (page_address (page),PAGE_SIZE );if (!skb) {__free_page (page);return NULL ;
@@ -3969,8 +3968,10 @@ void bnxt_set_ring_params(struct bnxt *bp) bp->rx_agg_ring_mask = (bp->rx_agg_nr_pages *RX_DESC_CNT ) -1 ;if (BNXT_RX_PAGE_MODE (bp)) { - rx_space =BNXT_PAGE_MODE_BUF_SIZE ; - rx_size =BNXT_MAX_PAGE_MODE_MTU ; + rx_space =PAGE_SIZE ; + rx_size =PAGE_SIZE - +ALIGN (max (NET_SKB_PAD ,XDP_PACKET_HEADROOM ),8 ) - +SKB_DATA_ALIGN (sizeof (struct skb_shared_info )); }else { rx_size =SKB_DATA_ALIGN (BNXT_RX_COPY_THRESH +NET_IP_ALIGN ); rx_space = rx_size + NET_SKB_PAD +
drivers/net/ethernet/broadcom/bnxt/bnxt.h +11 -4
@@ -591,12 +591,20 @@ struct nqe_cn {#define BNXT_RX_PAGE_SIZE (1 << BNXT_RX_PAGE_SHIFT)#define BNXT_MAX_MTU 9500 -#define BNXT_PAGE_MODE_BUF_SIZE \ + +/* First RX buffer page in XDP multi-buf mode +* +* +-------------------------------------------------------------------------+ +* | XDP_PACKET_HEADROOM | bp->rx_buf_use_size | skb_shared_info| +* | (bp->rx_dma_offset) | | | +* +-------------------------------------------------------------------------+ +*/ +#define BNXT_MAX_PAGE_MODE_MTU_SBUF \ ((unsigned int)PAGE_SIZE - VLAN_ETH_HLEN - NET_IP_ALIGN - \ XDP_PACKET_HEADROOM)#define BNXT_MAX_PAGE_MODE_MTU \ - BNXT_PAGE_MODE_BUF_SIZE - \ - SKB_DATA_ALIGN((unsigned int)sizeof(struct skb_shared_info)) + (BNXT_MAX_PAGE_MODE_MTU_SBUF - \ + SKB_DATA_ALIGN((unsigned int)sizeof(struct skb_shared_info)))#define BNXT_MIN_PKT_SIZE 52
@@ -2134,7 +2142,6 @@ struct bnxt {#define BNXT_DUMP_CRASH 1struct bpf_prog *xdp_prog; -u8 xdp_has_frags;struct bnxt_ptp_cfg *ptp_cfg;u8 ptp_all_rx_tstamp;
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +1 -6
@@ -193,9 +193,6 @@ void bnxt_xdp_buff_init(struct bnxt *bp, struct bnxt_rx_ring_info *rxr, mapping = rx_buf->mapping - bp->rx_dma_offset;dma_sync_single_for_cpu (&pdev->dev, mapping + offset, len, bp->rx_dir); -if (bp->xdp_has_frags) - buflen =BNXT_PAGE_MODE_BUF_SIZE + offset; -xdp_init_buff (xdp, buflen, &rxr->xdp_rxq);xdp_prepare_buff (xdp, data_ptr - offset, offset, len, false); }
@@ -404,10 +401,8 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog)netdev_warn (dev,"ethtool rx/tx channels must be combined to support XDP.\n" );return -EOPNOTSUPP ; } -if (prog) { +if (prog) tx_xdp = bp->rx_nr_rings; - bp->xdp_has_frags = prog->aux->xdp_has_frags; - } tc =netdev_get_num_tc (dev);if (!tc)
Signature · 1 line
2.18.1
Michael Chan
maintainerPATCH 5/5 bnxt_en: Fix HDS and jumbo thresholds for RX packets
In reply to Michael ChanThe recent XDP multi-buffer feature has introduced regressions in the setting of HDS and jumbo thresholds. HDS was accidentally disabled in the nornmal mode without XDP. This patch restores jumbo HDS placement when not in XDP mode. In XDP multi-buffer mode, HDS should be disabled and the jumbo threshold should be set to the usable page size in the first page buffer.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +5 -4
@@ -5399,15 +5399,16 @@ static int bnxt_hwrm_vnic_set_hds(struct bnxt *bp, u16 vnic_id) req->flags =cpu_to_le32 (VNIC_PLCMODES_CFG_REQ_FLAGS_JUMBO_PLACEMENT ); req->enables =cpu_to_le32 (VNIC_PLCMODES_CFG_REQ_ENABLES_JUMBO_THRESH_VALID ); -if (BNXT_RX_PAGE_MODE (bp) && !BNXT_RX_JUMBO_MODE (bp)) { +if (BNXT_RX_PAGE_MODE (bp)) { + req->jumbo_thresh =cpu_to_le16 (bp->rx_buf_use_size); + }else { req->flags |=cpu_to_le32 (VNIC_PLCMODES_CFG_REQ_FLAGS_HDS_IPV4 |VNIC_PLCMODES_CFG_REQ_FLAGS_HDS_IPV6 ); req->enables |=cpu_to_le32 (VNIC_PLCMODES_CFG_REQ_ENABLES_HDS_THRESHOLD_VALID ); + req->jumbo_thresh =cpu_to_le16 (bp->rx_copy_thresh); + req->hds_threshold =cpu_to_le16 (bp->rx_copy_thresh); } -/* thresholds not implemented in firmware yet */ - req->jumbo_thresh =cpu_to_le16 (bp->rx_copy_thresh); - req->hds_threshold =cpu_to_le16 (bp->rx_copy_thresh); req->vnic_id =cpu_to_le32 (vnic->fw_vnic_id);return hwrm_req_send (bp, req); }
Signature · 1 line
2.18.1
This series was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This series was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Quoted 6 lines · On Mon, 26 Dec 2022 22:19:35 -0500 you wrote:
This series fixes a devlink bug and several XDP related bugs. The devlink bug causes a kernel crash on VF devices. The XDP driver patches fix and clean up the RX XDP path and re-enable header-data split that was disabled by mistake when adding the XDP multi-buffer support.
Quoted 7 lines
Michael Chan (4):
bnxt_en: Simplifybnxt_xdp_buff_init()
bnxt_en: Fix XDP RX path
bnxt_en: Fix first buffer size calculations for XDP multi-buffer
bnxt_en: Fix HDS and jumbo thresholds for RX packets[...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix devlink port registration to netdev
https://git.kernel.org/netdev/net/c/0020ae2a4aa8 - [net,2/5] bnxt_en: Simplify bnxt_xdp_buff_init() https://git.kernel.org/netdev/net/c/bbfc17e50ba2 - [net,3/5] bnxt_en: Fix XDP RX path https://git.kernel.org/netdev/net/c/9b3e607871ea - [net,4/5] bnxt_en: Fix first buffer size calculations for XDP multi-buffer https://git.kernel.org/netdev/net/c/1abeacc1979f - [net,5/5] bnxt_en: Fix HDS and jumbo thresholds for RX packets https://git.kernel.org/netdev/net/c/a056ebcc30e2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html