Skip to contentSkip to conversation

net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe

PATCH Applied Miaoqian Lin 2 participants 2 messages Dec 29, 2022 – Dec 30, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe

of_phy_find_device() return device node with refcount incremented. Call put_device() to relese it when not needed anymore.

Fixes ab4e6ee578e8 ("net: phy: xgmiitorgmii: Check phy_driver ready before accessing")
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/phy/xilinx_gmii2rgmii.c +1 -0
index 8dcb49ed1f3d..7fd9fe6a602b 100644
@@ -105,6 +105,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 
 	if (!priv->phy_dev->drv) {
 		dev_info(dev, "Attached phy not ready\n");
+		put_device(&priv->phy_dev->mdio.dev);
 		return -EPROBE_DEFER;
 	}
 
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Thu, 29 Dec 2022 10:29:25 +0400 you wrote:

of_phy_find_device() return device node with refcount incremented. Call put_device() to relese it when not needed anymore.

Fixes ab4e6ee578e8 ("net: phy: xgmiitorgmii: Check phy_driver ready before accessing")
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 1 +
 1 file changed, 1 insertion(+)

Here is the summary with links:
- net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe

    https://git.kernel.org/netdev/net/c/d039535850ee

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html