net: ipa: use proper endpoint mask for suspend
PATCH 1/1 net: ipa: use proper endpoint mask for suspend
It is now possible for a system to have more than 32 endpoints. As a result, registers related to endpoint suspend are parameterized, with 32 endpoints represented in one more registers.
In ipa_interrupt_suspend_control(), the IPA_SUSPEND_EN register offset is determined properly, but the bit mask used still assumes the number of enpoints won't exceed 32. This is a bug. Fix it.
--- drivers/net/ipa/ipa_interrupt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ipa/ipa_interrupt.c +1 -2
@@ -132,10 +132,10 @@ static void ipa_interrupt_suspend_control(struct ipa_interrupt *interrupt, u32 endpoint_id, bool enable) {struct ipa *ipa = interrupt->ipa; +u32 mask =BIT (endpoint_id %32 );u32 unit = endpoint_id /32 ;const struct ipa_reg *reg;u32 offset; -u32 mask;u32 val;WARN_ON (!test_bit (endpoint_id, ipa->available));
@@ -148,7 +148,6 @@ static void ipa_interrupt_suspend_control(struct ipa_interrupt *interrupt, offset =ipa_reg_n_offset (reg, unit); val =ioread32 (ipa->reg_virt + offset); - mask =BIT (endpoint_id);if (enable) val |= mask;else
Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Fri, 30 Dec 2022 16:33:04 -0600 you wrote:
It is now possible for a system to have more than 32 endpoints. As a result, registers related to endpoint suspend are parameterized, with 32 endpoints represented in one more registers.
In
ipa_interrupt_suspend_control(), theIPA_SUSPEND_ENregister offset is determined properly, but the bit mask used still assumes the number of enpoints won't exceed 32. This is a bug. Fix it.[...]
Here is the summary with links:
- [net] net: ipa: use proper endpoint mask for suspend
https://git.kernel.org/netdev/net/c/d9d71a89f28d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html