inet: control sockets should not use current thread task_frag
Subsystems (2)
PATCH 1/1 inet: control sockets should not use current thread task_frag
Because ICMP handlers run from softirq contexts, they must not use current thread task_frag.
Previously, all sockets allocated by inet_ctl_sock_create() would use the per-socket page fragment, with no chance of recursion.
--- net/ipv4/af_inet.c | 1 + 1 file changed, 1 insertion(+)
net/ipv4/af_inet.c +1 -0
@@ -1665,6 +1665,7 @@ int inet_ctl_sock_create(struct sock **sk, unsigned short family,if (rc ==0 ) { *sk = sock->sk; (*sk)->sk_allocation =GFP_ATOMIC ; + (*sk)->sk_use_task_frag = false;/* * Unhash it so that IP input processing does not even see it, * we do not wish this socket to see incoming packets.
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
Quoted 6 lines · Eric Dumazet
Because ICMP handlers run from softirq contexts,
they must not use current threadtask_frag.Previously, all sockets allocated by
inet_ctl_sock_create()would use the per-socket page fragment, with no chance of recursion.
Thanks for the fix!
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 3 Jan 2023 19:27:36 +0000 you wrote:
Because ICMP handlers run from softirq contexts,
they must not use current threadtask_frag.Previously, all sockets allocated by
inet_ctl_sock_create()would use the per-socket page fragment, with no chance of recursion.[...]
Here is the summary with links:
- [net] inet: control sockets should not use current thread task_frag
https://git.kernel.org/netdev/net/c/1ac885574470
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html