Skip to contentSkip to conversation

Revert "r8169: disable detection of chip version 36"

PATCH Applied Heiner Kallweit 2 participants 2 messages Jan 8, 2023 – Jan 10, 2023

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 Revert "r8169: disable detection of chip version 36"

This reverts commit 42666b2c452ce87894786aae05e3fad3cfc6cb59.

This chip version seems to be very rare, but it exits in consumer devices, see linked report.

https://stackoverflow.com/questions/75049473/cant-setup-a-wired-network-in-archlinux-fresh-install

---
 drivers/net/ethernet/realtek/r8169_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +1 -4
index 24592d972523..dadd61bccfe7 100644
@@ -1996,10 +1996,7 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
 
 		/* 8168F family. */
 		{ 0x7c8, 0x488,	RTL_GIGA_MAC_VER_38 },
-		/* It seems this chip version never made it to
-		 * the wild. Let's disable detection.
-		 * { 0x7cf, 0x481,	RTL_GIGA_MAC_VER_36 },
-		 */
+		{ 0x7cf, 0x481,	RTL_GIGA_MAC_VER_36 },
 		{ 0x7cf, 0x480,	RTL_GIGA_MAC_VER_35 },
 
 		/* 8168E family. */
Signature · 1 line
2.39.0
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Sun, 8 Jan 2023 20:37:53 +0100 you wrote:

This reverts commit 42666b2c452ce87894786aae05e3fad3cfc6cb59.

This chip version seems to be very rare, but it exits in consumer devices, see linked report.

https://stackoverflow.com/questions/75049473/cant-setup-a-wired-network-in-archlinux-fresh-install

[...]

Here is the summary with links:
- [net] Revert "r8169: disable detection of chip version 36"

    https://git.kernel.org/netdev/net/c/2ea26b4de6f4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html