Skip to contentSkip to conversation

tc: remove support for rr qdisc

PATCH Applied Stephen Hemminger 2 participants 2 messages Jan 11, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tc: remove support for rr qdisc

The Round-Robin qdisc was removed in kernel version 2.6.27. Remove code and man page references from iproute.

---
 bash-completion/tc |   4 +-
 man/man8/tc.8      |   4 --
 tc/Makefile        |   1 -
 tc/q_rr.c          | 119 ---------------------------------------------
 4 files changed, 2 insertions(+), 126 deletions(-)
 delete mode 100644 tc/q_rr.c
bash-completion/tc +2 -2
index 9f16d0d481e0..8352cc94e391 100644
@@ -3,7 +3,7 @@
 # Copyright 2016 Quentin Monnet <[email protected]>
 
 QDISC_KIND=' choke codel bfifo pfifo pfifo_head_drop fq fq_codel gred hhf \
-            mqprio multiq netem pfifo_fast pie fq_pie red rr sfb sfq tbf atm \
+            mqprio multiq netem pfifo_fast pie fq_pie red sfb sfq tbf atm \
             cbq drr dsmark hfsc htb prio qfq '
 FILTER_KIND=' basic bpf cgroup flow flower fw route rsvp tcindex u32 matchall '
 ACTION_KIND=' gact mirred bpf sample '
@@ -339,7 +339,7 @@ _tc_qdisc_options()
                 bandwidth ecn harddrop'
             return 0
             ;;
-        rr|prio)
+        prio)
             _tc_once_attr 'bands priomap multiqueue'
             return 0
             ;;
man/man8/tc.8 +0 -4
index 2969fb55aafc..d436d46472af 100644
@@ -361,10 +361,6 @@ Random Early Detection simulates physical congestion by randomly dropping
 packets when nearing configured bandwidth allocation. Well suited to very
 large bandwidth applications.
 .TP
-rr
-Round-Robin qdisc with support for multiqueue network devices. Removed from
-Linux since kernel version 2.6.27.
-.TP
 sfb
 Stochastic Fair Blue is a classless qdisc to manage congestion based on
 packet loss and link utilization history while trying to prevent
tc/Makefile +0 -1
index 5a517af20b7c..98d2ee597a1e 100644
@@ -15,7 +15,6 @@ TCMODULES += q_prio.o
 TCMODULES += q_skbprio.o
 TCMODULES += q_tbf.o
 TCMODULES += q_cbq.o
-TCMODULES += q_rr.o
 TCMODULES += q_multiq.o
 TCMODULES += q_netem.o
 TCMODULES += q_choke.o
tc/q_rr.c deleted +0 -119

119 lines not on this page · raw message

Signature · 1 line
2.39.0
#1 lore raw
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Quoted 11 lines · On Wed, 11 Jan 2023 09:14:20 -0800 you wrote:

The Round-Robin qdisc was removed in kernel version 2.6.27. Remove code and man page references from iproute.

---
 bash-completion/tc |   4 +-
 man/man8/tc.8      |   4 --
 tc/Makefile        |   1 -
 tc/q_rr.c          | 119 ---------------------------------------------
 4 files changed, 2 insertions(+), 126 deletions(-)
 delete mode 100644 tc/q_rr.c

Here is the summary with links:
- [iproute] tc: remove support for rr qdisc

    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=4dc60c017920

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html