Skip to contentSkip to conversation

selftests/bpf: Fix missing space error

PATCH Applied Roberto Valenzuela 2 participants 2 messages Jan 13, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Fix missing space error

Add the missing space after 'dest' variable assignment. This change will resolve the following checkpatch.pl script error:

ERROR: spaces required around that '+=' (ctx:VxW)

---
 tools/testing/selftests/bpf/progs/test_xdp_vlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/progs/test_xdp_vlan.c +1 -1
index 134768f6b788..cdf3c48d6cbb 100644
@@ -195,7 +195,7 @@ int  xdp_prognum2(struct xdp_md *ctx)
 
 	/* Moving Ethernet header, dest overlap with src, memmove handle this */
 	dest = data;
-	dest+= VLAN_HDR_SZ;
+	dest += VLAN_HDR_SZ;
 	/*
 	 * Notice: Taking over vlan_hdr->h_vlan_encapsulated_proto, by
 	 * only moving two MAC addrs (12 bytes), not overwriting last 2 bytes
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 8 lines · On Fri, 13 Jan 2023 13:02:57 -0500 you wrote:

Add the missing space after 'dest' variable assignment. This change will resolve the following checkpatch.pl script error:

ERROR: spaces required around that '+=' (ctx:VxW)

[...]

Here is the summary with links:
- selftests/bpf: Fix missing space error

    https://git.kernel.org/bpf/bpf-next/c/1c48391bc673

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html