caif: don't assume iov_iter type
Subsystems (3)
PATCH 1/1 caif: don't assume iov_iter type
From: Keith Busch <[email protected]>
The details of the iov_iter types are appropriately abstracted, so there's no need to check for specific type fields. Just let the abstractions handle it.
This is preparing for io_uring/net's io_send to utilize the more efficient ITER_UBUF.
--- net/caif/caif_socket.c | 4 ---- 1 file changed, 4 deletions(-)
net/caif/caif_socket.c +0 -4
@@ -533,10 +533,6 @@ static int caif_seqpkt_sendmsg(struct socket *sock, struct msghdr *msg,if (msg->msg_namelen) goto err; - ret = -EINVAL ; -if (unlikely (msg->msg_iter.nr_segs ==0 ) || -unlikely (msg->msg_iter.iov->iov_base ==NULL )) - goto err; noblock = msg->msg_flags &MSG_DONTWAIT ; timeo =sock_sndtimeo (sk, noblock);
Signature · 1 line
2.30.2
Quoted 8 lines · Keith Busch
From: Keith Busch <[email protected]>
The details of the
iov_itertypes are appropriately abstracted, so there's no need to check for specific type fields. Just let the abstractions handle it.This is preparing for io_uring/net's
io_sendto utilize the more efficientITER_UBUF.
Looks good to me - the correct return here would be -EFAULT as well, not -EINVAL. Which is what will happen once memcpy_from_msg() is called anyway.
Signature · 1 line
Jens Axboe
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Wed, 11 Jan 2023 10:42:45 -0800 you wrote:
From: Keith Busch <[email protected]>
The details of the
iov_itertypes are appropriately abstracted, so there's no need to check for specific type fields. Just let the abstractions handle it.This is preparing for io_uring/net's
io_sendto utilize the more efficientITER_UBUF.[...]
Here is the summary with links:
- caif: don't assume iov_iter type
https://git.kernel.org/netdev/net-next/c/c19175141079
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html