Skip to contentSkip to conversation

add space after keyword

PATCH Applied Stephen Hemminger 2 participants 2 messages Jan 16, 2023

Subsystems (2)

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add space after keyword

The style standard is to use space after keywords. Example:
if (expr)
verus
if(expr)

---
 dcb/dcb_app.c     | 2 +-
 devlink/devlink.c | 2 +-
 ip/iprule.c       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
dcb/dcb_app.c +1 -1
index b9ac8f4bce59..eeb78e70f63f 100644
@@ -264,7 +264,7 @@ static int dcb_app_parse_pcp(__u32 *key, const char *arg)
 {
 	int i;
 
-	for(i = 0; i < ARRAY_SIZE(pcp_names); i++) {
+	for (i = 0; i < ARRAY_SIZE(pcp_names); i++) {
 		if (pcp_names[i] && strcmp(arg, pcp_names[i]) == 0) {
 			*key = i;
 			return 0;
devlink/devlink.c +1 -1
index 931a768a41d1..795f8318c0c4 100644
@@ -1963,7 +1963,7 @@ static int dl_argv_parse(struct dl *dl, uint64_t o_required,
 
 			dl_arg_inc(dl);
 			err = dl_argv_str(dl, &sectionstr);
-			if(err)
+			if (err)
 				return err;
 			err = flash_overwrite_section_get(sectionstr,
 							  &opts->overwrite_mask);
ip/iprule.c +1 -1
index 654ffffe3cc0..458607efd93f 100644
@@ -695,7 +695,7 @@ static int iprule_list_flush_or_save(int argc, char **argv, int action)
 			else if (ret != 2)
 				invarg("invalid dport range\n", *argv);
 			filter.dport = r;
-		} else{
+		} else {
 			if (matches(*argv, "dst") == 0 ||
 			    matches(*argv, "to") == 0) {
 				NEXT_ARG();
Signature · 1 line
2.39.0
#1 lore raw
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Quoted 9 lines · On Mon, 16 Jan 2023 09:20:46 -0800 you wrote:

The style standard is to use space after keywords. Example:
if (expr)
verus
if(expr)

[...]

Here is the summary with links:
- [iproute] add space after keyword

    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=46686c563b91

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html