Skip to contentSkip to conversation

ARM: dts: imx8mm-evk: Fix wrong PMIC device for new EVK board

PATCH In review Ye Li 2 participants 3 messages Jan 17, 2023 – Jan 18, 2023

Subsystems (2)
lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/1 ARM: dts: imx8mm-evk: Fix wrong PMIC device for new EVK board

In commit 48ddafd (imx8mm_evk: Switch to new imx8mm evk board), the iMX8MM EVK support was updated to new EVK board which is using PCA9450A PMIC.
But the commit 24a7a3c (imx8mm: synchronise device tree with linux) changed DTS node back to legacy PMIC which is not aligned with SPL codes and defconfig, then cause SPL boot failure.

---
 arch/arm/dts/imx8mm-evk-u-boot.dtsi |   4 +-
 arch/arm/dts/imx8mm-evk.dtsi        | 127 +++++++++++++++++++-----------------
 2 files changed, 68 insertions(+), 63 deletions(-)
arch/arm/dts/imx8mm-evk-u-boot.dtsi +2 -2
index d82428f..951017b 100644
@@ -121,11 +121,11 @@
 	u-boot,dm-spl;
 };
 
-&{/soc@0/bus@30800000/i2c@30a20000/pmic@4b} {
+&{/soc@0/bus@30800000/i2c@30a20000/pca9450@25} {
 	u-boot,dm-spl;
 };
 
-&{/soc@0/bus@30800000/i2c@30a20000/pmic@4b/regulators} {
+&{/soc@0/bus@30800000/i2c@30a20000/pca9450@25/regulators} {
 	u-boot,dm-spl;
 };
 
arch/arm/dts/imx8mm-evk.dtsi +66 -61

181 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

Hi Ye Li

Quoted 6 lines · Ye Li

In commit 48ddafd (imx8mm_evk: Switch to new imx8mm evk board), the iMX8MM EVK support was updated to new EVK board which is using PCA9450A PMIC.
But the commit 24a7a3c (imx8mm: synchronise device tree with linux) changed DTS node back to legacy PMIC which is not aligned with SPL codes and defconfig, then cause SPL boot failure.

Please note that I even mentioned this back in the day [1], however, neither NXP nor anybody else reacted in any way.

The correct way would be, of course, to update this in Linux and subsequently re-syncing with U-Boot. Do you at least plan to properly update this on the Linux side as well?

Thanks!

[1] https://patchwork.ozlabs.org/project/uboot/cover/[email protected]/

[snip]

Cheers

Marcel

author
#2 lore raw

Hi Marcel,

Quoted 12 lines · Marcel Ziswiler

Caution: EXT Email

Hi Ye Li

Quoted 7 lines · Ye Li

In commit 48ddafd (imx8mm_evk: Switch to new imx8mm evk board), the iMX8MM EVK support was updated to new EVK board which is using PCA9450A PMIC.
But the commit 24a7a3c (imx8mm: synchronise device tree with linux) changed DTS node back to legacy PMIC which is not aligned with SPL codes and defconfig, then cause SPL boot failure.

Quoted 8 lines

Please note that I even mentioned this back in the day [1], however, neither NXP nor anybody else reacted in
any way.

The correct way would be, of course, to update this in Linux and subsequently re-syncing with U-Boot. Do you at
least plan to properly update this on the Linux side as well?

Yes, we will upstream this to kernel. I also notice another break on 8ULP EVK which causes no any log. Fix has sent out.

Best regards,
Ye Li

Quoted 16 lines

Thanks!

[1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2
Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fcover%2F20220721132748.1052 244-1- marcel%40ziswiler.com%2F&data=05%7C01%7Cye.li%40nxp.com%7Cd979241c65a d4161f80a08daf86b833f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63 8095437885252506%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=y1w4PE3% 2BKoJ%2Beskp%2Bjx54BYq5bLI6SjlUPwTXWUnEB4%3D&reserved=0

[snip]

Cheers

Marcel