net: stmmac: fix invalid call to mdiobus_get_phy()
Subsystems (4)
PATCH 1/1 net: stmmac: fix invalid call to mdiobus_get_phy()
In a number of cases the driver assigns a default value of -1 to priv->plat->phy_addr. This may result in calling mdiobus_get_phy() with addr parameter being -1. Therefore check for this scenario and bail out before calling mdiobus_get_phy().
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +5 -0
@@ -1150,6 +1150,11 @@ static int stmmac_init_phy(struct net_device *dev)int addr = priv->plat->phy_addr;struct phy_device *phydev; +if (addr <0 ) { +netdev_err (priv->dev,"no phy found\n" ); +return -ENODEV ; + } + phydev =mdiobus_get_phy (priv->mii, addr);if (!phydev) {netdev_err (priv->dev,"no phy at addr %d\n" , addr);
Signature · 1 line
2.39.0
This patch was applied to netdev/net.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:
Quoted 9 lines · On Sun, 15 Jan 2023 18:24:08 +0100 you wrote:
In a number of cases the driver assigns a default value of -1 to
priv->plat->phy_addr. This may result in callingmdiobus_get_phy()with addr parameter being -1. Therefore check for this scenario and bail out before callingmdiobus_get_phy().Fixes 42e87024f727 ("net: stmmac: Fix case when PHY handle is not present")Signed-off-by Heiner Kallweit <[email protected]>[...]
Here is the summary with links:
- [net] net: stmmac: fix invalid call to mdiobus_get_phy()
https://git.kernel.org/netdev/net/c/1f3bd64ad921
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html