s390/dcssblk:: don't call bio_split_to_limits
Subsystems (2)
PATCH 1/1 s390/dcssblk:: don't call bio_split_to_limits
s390 iterates over the bio using bio_for_each_segment and doesn't need any bio splitting.
--- drivers/s390/block/dcssblk.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/s390/block/dcssblk.c +0 -4
@@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)unsigned long source_addr;unsigned long bytes_done; - bio =bio_split_to_limits (bio); -if (!bio) -return ; - bytes_done =0 ; dev_info = bio->bi_bdev->bd_disk->private_data;if (dev_info ==NULL )
Signature · 1 line
2.39.0
Alexander Gordeev
maintainerOn Mon, Jan 23, 2023 at 08:53:56AM +0100, Christoph Hellwig wrote:
Hi Christoph,
Quoted 13 lines
s390 iterates over the bio using
bio_for_each_segmentand doesn't need any bio splitting.Signed-off-by Christoph Hellwig <[email protected]>--- drivers/s390/block/dcssblk.c | 4 ---- 1 file changed, 4 deletions(-)drivers/s390/block/dcssblk.c +0
-0
drivers/s390/block/dcssblk.c dcssblk_submit_bio(struct bio *bio) · line 869
Quoted 10 lines
drivers/s390/block/dcssblk.c +0
-4@@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)unsigned long source_addr;unsigned long bytes_done; - bio =bio_split_to_limits (bio); -if (!bio) -return ; - bytes_done =0 ; dev_info = bio->bi_bdev->bd_disk->private_data;if (dev_info ==NULL )
If my understanding is correct that this change was as good as early as commit 54efd50bfd87 ("block: make generic_make_request handle arbitrarily sized bios") took place and simply fell into the second category?
...
Some make_request_fn() callbacks were simple enough to audit and verify they don't need blk_queue_split() calls. The skipped ones are:
...
Some others are almost certainly safe to remove now, but will be left for future patches.
...
Thanks!
Quoted 4 lines · Alexander Gordeev
If my understanding is correct that this change was as good as early as commit
54efd50bfd87("block: makegeneric_make_requesthandle arbitrarily sized bios") took place and simply fell into the second category?
Yes.
Quoted 13 lines · Christoph Hellwig
s390 iterates over the bio using
bio_for_each_segmentand doesn't need any bio splitting.Signed-off-by Christoph Hellwig <[email protected]>--- drivers/s390/block/dcssblk.c | 4 ---- 1 file changed, 4 deletions(-)drivers/s390/block/dcssblk.c +0
-0
drivers/s390/block/dcssblk.c dcssblk_submit_bio(struct bio *bio) · line 869
Quoted 10 lines
drivers/s390/block/dcssblk.c +0
-4@@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)unsigned long source_addr;unsigned long bytes_done; - bio =bio_split_to_limits (bio); -if (!bio) -return ; - bytes_done =0 ; dev_info = bio->bi_bdev->bd_disk->private_data;if (dev_info ==NULL )
Quoted 4 lines · Christoph Hellwig
s390 iterates over the bio using
bio_for_each_segmentand doesn't need any bio splitting.
Applied, thanks!
[1/1] s390/dcssblk:: don't call bio_split_to_limits
commit: a2aea8f56f9ee995aeabeb633b708024a3be5281
Best regards,
Signature · 1 line
Jens Axboe