MAC address falls to permanent
cover MAC address falls to permanent
A bug was found with the vmxnet3 driver, after changing the MAC address and rebooting, it falls into the category of a permanent address until the VM is turned off. Here is log output:
-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff-bash-4.4# ip link set dev ens3 address 33:33:33:33:33:33 -bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff-bash-4.4# ethtool -P ens3
Permanent address: 52:54:00:12:34:56
-bash-4.4# reboot
//rebooting
-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff-bash-4.4# ethtool -P ens3
Permanent address: 33:33:33:33:33:33
-bash-4.4#
VlaoMao (1):
vmxnet3: add mac address restore upon reset
hw/net/vmxnet3.c | 2 ++ 1 file changed, 2 insertions(+)
Signature · 1 line
2.34.5
Use ./scripts/get_maintainer.pl to have the list of the maintainers.
Always send your patches to qemu-devel&nongnu.org
Thanks,
Laurent
Le 30/01/2023 à 18:54, ~vlaomao a écrit :
Quoted 50 lines
A bug was found with the vmxnet3 driver, after changing the MAC address and rebooting, it falls into the category of a permanent address until the VM is turned off. Here is log output:
-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever 2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff(quoted diff) +0
-2-bash-4.4# ip link set dev ens3 address 33:33:33:33:33:33 -bash-4.4# ip a1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever 2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff-bash-4.4# ethtool -P ens3
Permanent address: 52:54:00:12:34:56
-bash-4.4# reboot//rebooting
-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever 2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff-bash-4.4# ethtool -P ens3
Permanent address: 33:33:33:33:33:33
-bash-4.4#VlaoMao (1):
vmxnet3: add mac address restore upon resethw/net/vmxnet3.c | 2 ++ 1 file changed, 2 insertions(+)
PATCH 1/1 vmxnet3: add mac address restore upon reset
In reply to ~vlaomaoFrom: VlaoMao <[email protected]>
Changing the address with a subsequent reboot makes this address permanent until the vm is turned off
--- hw/net/vmxnet3.c | 2 ++ 1 file changed, 2 insertions(+)
hw/net/vmxnet3.c +2 -0
@@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s) s->drv_shmem =0 ; s->tx_sop = true; s->skip_current_tx_pkt = false; + +vmxnet3_reset_mac (s); }static void vmxnet3_update_rx_mode (VMXNET3State *s)
Signature · 1 line
2.34.5
Re: [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset
Le 30/01/2023 à 18:28, ~vlaomao a écrit :
Quoted 3 lines
From: VlaoMao <[email protected]>
Changing the address with a subsequent reboot makes this address permanent until the vm is turned off
Missing Signed-off-by.
See https://www.qemu.org/docs/master/devel/submitting-a-patch.html
Quoted 17 lines
--- hw/net/vmxnet3.c | 2 ++ 1 file changed, 2 insertions(+)hw/net/vmxnet3.c +2
-0@@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s) s->drv_shmem =0 ; s->tx_sop = true; s->skip_current_tx_pkt = false; + +vmxnet3_reset_mac (s); }static void vmxnet3_update_rx_mode (VMXNET3State *s)
Re: [PATCH qemu 1/1] vmxnet3: add mac address restore upon reset
пн, 30 янв. 2023 г. в 21:12, Laurent Vivier <[email protected]>:
Quoted 29 lines · ~vlaomao
Quoted 3 lines
From: VlaoMao <[email protected]>
Changing the address with a subsequent reboot makes this address permanent until the vm is turned off
Missing Signed-off-by.
See https://www.qemu.org/docs/master/devel/submitting-a-patch.html
Quoted 17 lines
--- hw/net/vmxnet3.c | 2 ++ 1 file changed, 2 insertions(+)hw/net/vmxnet3.c +2
-0@@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s) s->drv_shmem =0 ; s->tx_sop = true; s->skip_current_tx_pkt = false; + +vmxnet3_reset_mac (s); }static void vmxnet3_update_rx_mode (VMXNET3State *s)