Skip to contentSkip to conversation

gatttool: Use consistent spacing before brackets

PATCH Applied David Nicolson 3 participants 3 messages Feb 12, 2023 – Feb 14, 2023 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gatttool: Use consistent spacing before brackets

From: Dave Nicolson <[email protected]>

---
 attrib/gatttool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
attrib/gatttool.c +4 -4
index 6a0ddfaad..2d03875b0 100644
@@ -456,17 +456,17 @@ static gboolean parse_uuid(const char *key, const char *value,
 
 static GOptionEntry primary_char_options[] = {
 	{ "start", 's' , 0, G_OPTION_ARG_INT, &opt_start,
-		"Starting handle(optional)", "0x0001" },
+		"Starting handle (optional)", "0x0001" },
 	{ "end", 'e' , 0, G_OPTION_ARG_INT, &opt_end,
-		"Ending handle(optional)", "0xffff" },
+		"Ending handle (optional)", "0xffff" },
 	{ "uuid", 'u', G_OPTION_FLAG_OPTIONAL_ARG, G_OPTION_ARG_CALLBACK,
-		parse_uuid, "UUID16 or UUID128(optional)", "0x1801"},
+		parse_uuid, "UUID16 or UUID128 (optional)", "0x1801"},
 	{ NULL },
 };
 
 static GOptionEntry char_rw_options[] = {
 	{ "handle", 'a' , 0, G_OPTION_ARG_INT, &opt_handle,
-		"Read/Write characteristic by handle(required)", "0x0001" },
+		"Read/Write characteristic by handle (required)", "0x0001" },
 	{ "value", 'n' , 0, G_OPTION_ARG_STRING, &opt_value,
 		"Write characteristic value (required for write operation)",
 		"0x0001" },
Signature · 1 line
2.38.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=721094

---Test result---

Test Summary:

CheckPatch                    PASS      0.35 seconds
GitLint                       PASS      0.26 seconds
BuildEll                      PASS      33.20 seconds
BluezMake                     PASS      1090.59 seconds
MakeCheck                     PASS      12.80 seconds
MakeDistcheck                 PASS      183.29 seconds
CheckValgrind                 PASS      301.39 seconds
CheckSmatch                   WARNING   411.94 seconds
bluezmakeextell               PASS      122.16 seconds
IncrementalBuild              PASS      922.53 seconds
ScanBuild                     PASS      1317.16 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
attrib/gatttool.c:235:23: warning: Variable length array is used.

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to David Nicolson
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 5 lines · On Sun, 12 Feb 2023 18:24:02 +0100 you wrote:

From: Dave Nicolson <[email protected]>

---
 attrib/gatttool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
- [BlueZ] gatttool: Use consistent spacing before brackets

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=89f535894e59

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html