Skip to contentSkip to conversation

Add a quirk for Plantronics DA45

PATCH In review denk 3 participants 6 messages Feb 19, 2016 – Mar 1, 2016 Sound

lore
Share & tools
lore

denk

author
#0 lore raw

PATCH 1/1 Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -0
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
        case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
        case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
        case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
        case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
        case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
        case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */

---

author
#1 lore raw

As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

Thank you very much and best
denk

----- Ursprüngliche Mail -----
Von: "denk" <[email protected]>
An: [email protected]
Gesendet: Freitag, 19. Februar 2016 14:01:02
Betreff: [PATCH] Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -0
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
        case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
        case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
        case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
        case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
        case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
        case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */

---

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw
Quoted 2 lines · denk

As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

I thought I replied you, suggesting to give a proper sign-off line. Without your own sign-off, we can't merge any patch from you. See Documentation/SubmittingPatches for details.

So, please resubmit with it.

thanks,

Takashi

Quoted 30 lines

Thank you very much and best
denk

----- Ursprüngliche Mail -----
Von: "denk" <[email protected]>
An: [email protected]
Gesendet: Freitag, 19. Februar 2016 14:01:02
Betreff: [PATCH] Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -1
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
        case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
        case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
        case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
        case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
        case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
        case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
---
Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

author
#3 lore raw

I'm sorry, maybe I've misunderstood something. As far as I understood https://www.kernel.org/doc/Documentation/SubmittingPatches, it should be sufficient to close the patch mail with Signed-off-by: Dennis Kadioglu <[email protected]>, which I did in my second mail (see below). Is there anything else I've missed?

----- Ursprüngliche Mail -----
Von: "Takashi Iwai" <[email protected]>
An: "denk" <[email protected]>
CC: [email protected]
Gesendet: Dienstag, 1. März 2016 11:23:19
Betreff: Re: [alsa-devel] [PATCH] Add a quirk for Plantronics DA45

Quoted 2 lines · denk

As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

I thought I replied you, suggesting to give a proper sign-off line. Without your own sign-off, we can't merge any patch from you. See Documentation/SubmittingPatches for details.

So, please resubmit with it.

thanks,

Takashi

Quoted 30 lines

Thank you very much and best
denk

----- Ursprüngliche Mail -----
Von: "denk" <[email protected]>
An: [email protected]
Gesendet: Freitag, 19. Februar 2016 14:01:02
Betreff: [PATCH] Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -1
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
        case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
        case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
        case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
        case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
        case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
        case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
---
Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#4 lore raw
In reply to Takashi Iwai

Actually, there is a Signed-off-by line, but it's at the wrong place. Also the Author/From line should state your full name.

Denk, please see below:

Quoted 9 lines · Takashi Iwai
Quoted 2 lines · denk

As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

I thought I replied you, suggesting to give a proper sign-off line. Without your own sign-off, we can't merge any patch from you. See Documentation/SubmittingPatches for details.

Quoted 19 lines

So, please resubmit with it.

thanks,

Takashi

Quoted 11 lines

Thank you very much and best
denk

----- Ursprüngliche Mail -----
Von: "denk" <[email protected]>
An: [email protected]
Gesendet: Freitag, 19. Februar 2016 14:01:02
Betreff: [PATCH] Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

Here is where sign-off-line should be: after the commit message but before the "---" line.

Quoted 5 lines
Quoted 5 lines
---
  sound/usb/quirks.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 13 lines
sound/usb/quirks.c +1 -1
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
         case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
         case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
         case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
         case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
         case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
         case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
---
Quoted 1 line

And here where it actually is; down here it won't be picked up correctly.

Quoted 9 lines
Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Signature · 6 lines
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#5 lore raw

OK, thanks for the clarification and sorry for the mistake. I will send it again including the mentioned fixes.

----- Ursprüngliche Mail -----
Von: "David Henningsson" <[email protected]>
An: "Takashi Iwai" <[email protected]>, "denk" <[email protected]>
CC: [email protected]
Gesendet: Dienstag, 1. März 2016 12:54:39
Betreff: Re: [alsa-devel] [PATCH] Add a quirk for Plantronics DA45

Actually, there is a Signed-off-by line, but it's at the wrong place. Also the Author/From line should state your full name.

Denk, please see below:

Quoted 9 lines · Takashi Iwai
Quoted 2 lines · denk

As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

I thought I replied you, suggesting to give a proper sign-off line. Without your own sign-off, we can't merge any patch from you. See Documentation/SubmittingPatches for details.

Quoted 19 lines

So, please resubmit with it.

thanks,

Takashi

Quoted 11 lines

Thank you very much and best
denk

----- Ursprüngliche Mail -----
Von: "denk" <[email protected]>
An: [email protected]
Gesendet: Freitag, 19. Februar 2016 14:01:02
Betreff: [PATCH] Add a quirk for Plantronics DA45

Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.

Here is where sign-off-line should be: after the commit message but before the "---" line.

Quoted 5 lines
Quoted 5 lines
---
  sound/usb/quirks.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 13 lines
sound/usb/quirks.c +1 -1
index 2585c17..5b03296 100644
@@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
         case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
         case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
         case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
+       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
         case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
         case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
         case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
---
Quoted 1 line

And here where it actually is; down here it won't be picked up correctly.

Quoted 9 lines
Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Signature · 6 lines
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel