Skip to contentSkip to conversation

bpf, docs: Add signed comparison example

PATCH Applied Dave Thaler 4 participants 4 messages Mar 10, 2023 – Mar 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf, docs: Add signed comparison example

From: Dave Thaler <[email protected]>

Improve clarity by adding an example of a signed comparison instruction

---
 Documentation/bpf/instruction-set.rst | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Documentation/bpf/instruction-set.rst +10 -1
index 5e43e14abe8..b4464058905 100644
@@ -11,7 +11,8 @@ Documentation conventions
 =========================
 
 For brevity, this document uses the type notion "u64", "u32", etc.
-to mean an unsigned integer whose width is the specified number of bits.
+to mean an unsigned integer whose width is the specified number of bits,
+and "s32", etc. to mean a signed integer of the specified number of bits.
 
 Registers and calling convention
 ================================
@@ -264,6 +265,14 @@ BPF_JSLE  0xd0   PC += off if dst <= src    signed
 The eBPF program needs to store the return value into register R0 before doing a
 BPF_EXIT.
 
+Example:
+
+``BPF_JSGE | BPF_X | BPF_JMP32`` (0x7e) means::
+
+  if (s32)dst s>= (s32)src goto +offset
+
+where 's>=' indicates a signed '>=' comparison.
+
 Helper functions
 ~~~~~~~~~~~~~~~~
 
Signature · 1 line
2.33.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dave Thaler

From: Dave Thaler <[email protected]>

Improve clarity by adding an example of a signed comparison instruction

Quoted 40 lines
---
 Documentation/bpf/instruction-set.rst | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Documentation/bpf/instruction-set.rst +10 -1
index 5e43e14abe8..b4464058905 100644
@@ -11,7 +11,8 @@ Documentation conventions
 =========================
 
 For brevity, this document uses the type notion "u64", "u32", etc.
-to mean an unsigned integer whose width is the specified number of bits.
+to mean an unsigned integer whose width is the specified number of bits,
+and "s32", etc. to mean a signed integer of the specified number of bits.
 
 Registers and calling convention
 ================================
@@ -264,6 +265,14 @@ BPF_JSLE  0xd0   PC += off if dst <= src    signed
 The eBPF program needs to store the return value into register R0 before doing a
 BPF_EXIT.
 
+Example:
+
+``BPF_JSGE | BPF_X | BPF_JMP32`` (0x7e) means::
+
+  if (s32)dst s>= (s32)src goto +offset
+
+where 's>=' indicates a signed '>=' comparison.
+
 Helper functions
 ~~~~~~~~~~~~~~~~
 
Signature · 6 lines
2.33.4

-- 
Bpf mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/bpf
Acked-by on v1 1/1
#2 lore raw
In reply to Dave Thaler
Quoted 28 lines · Dave Thaler

From: Dave Thaler <[email protected]>

Improve clarity by adding an example of a signed comparison instruction

---
 Documentation/bpf/instruction-set.rst | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Documentation/bpf/instruction-set.rst +3 -1
index 5e43e14abe8..b4464058905 100644
@@ -11,7 +11,8 @@ Documentation conventions
 =========================
 
 For brevity, this document uses the type notion "u64", "u32", etc.
-to mean an unsigned integer whose width is the specified number of bits.
+to mean an unsigned integer whose width is the specified number of bits,
+and "s32", etc. to mean a signed integer of the specified number of bits.
 
 Registers and calling convention
 ================================
@@ -264,6 +265,14 @@ BPF_JSLE  0xd0   PC += off if dst <= src    signed
 The eBPF program needs to store the return value into register R0 before doing a
 BPF_EXIT.
 
+Example:

Documentation/bpf/instruction-set.rst BPF_JSLE 0xd0 PC += off if dst <= src signed · line 278

Quoted 10 lines
Documentation/bpf/instruction-set.rst +7 -0
+
+``BPF_JSGE | BPF_X | BPF_JMP32`` (0x7e) means::
+
+  if (s32)dst s>= (s32)src goto +offset
+
+where 's>=' indicates a signed '>=' comparison.
+
 Helper functions
 ~~~~~~~~~~~~~~~~
 
#3 lore raw
In reply to Dave Thaler
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 8 lines · On Fri, 10 Mar 2023 23:38:14 +0000 you wrote:

From: Dave Thaler <[email protected]>

Improve clarity by adding an example of a signed comparison instruction

---
 Documentation/bpf/instruction-set.rst | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Here is the summary with links:
- [bpf-next] bpf, docs: Add signed comparison example

    https://git.kernel.org/bpf/bpf-next/c/b9fe8e8d03d0

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html