FAILED: patch "[PATCH] memory: tegra124-emc: fix interconnect registration race" failed to apply to 5.15-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x abd9f1b49cf25eebeaba193c7707355be3f48dae
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '[email protected]' --subject-prefix 'PATCH 5.15.y' HEAD^..
Possible dependencies:
abd9f1b49cf2 ("memory: tegra124-emc: fix interconnect registration race")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From abd9f1b49cf25eebeaba193c7707355be3f48dae Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2023 08:56:46 +0100
Subject: [PATCH] memory: tegra124-emc: fix interconnect registration race
The current interconnect provider registration interface is inherently racy as nodes are not added until the after adding the provider. This can specifically cause racing DT lookups to fail.
Switch to using the new API where the provider is not registered until after it has been fully initialised.
drivers/memory/tegra/tegra124-emc.c +6 -6
@@ -1351,15 +1351,13 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc) emc->provider.aggregate = soc->icc_ops->aggregate; emc->provider.xlate_extended = emc_of_icc_xlate_extended; - err =icc_provider_add (&emc->provider); -if (err) - goto err_msg; +icc_provider_init (&emc->provider);/* create External Memory Controller node */ node =icc_node_create (TEGRA_ICC_EMC );if (IS_ERR (node)) { err =PTR_ERR (node); - goto del_provider; + goto err_msg; } node->name ="External Memory Controller" ;
@@ -1380,12 +1378,14 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc) node->name ="External Memory (DRAM)" ;icc_node_add (node, &emc->provider); + err =icc_provider_register (&emc->provider); +if (err) + goto remove_nodes; +return 0 ; remove_nodes:icc_nodes_remove (&emc->provider); -del_provider: -icc_provider_del (&emc->provider); err_msg:dev_err (emc->dev,"failed to initialize ICC: %d\n" , err);