Skip to contentSkip to conversation

veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

PATCH Applied Andrii Nakryiko 2 participants 2 messages Mar 30, 2023

Subsystems (3)
lore
Share & tools
lore

Andrii Nakryiko

author maintainer
#0 lore raw

PATCH 1/1 veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

SCHED_CLS seems to be a better option as a default guess for freplace programs that have __sk_buff as a context type.

---
 tools/testing/selftests/bpf/veristat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/veristat.c +1 -1
index 055df1abd7ca..7888c03ba631 100644
@@ -798,7 +798,7 @@ static int guess_prog_type_by_ctx_name(const char *ctx_name,
 		enum bpf_attach_type attach_type;
 	} ctx_map[] = {
 		/* __sk_buff is most ambiguous, for now we assume cgroup_skb */
-		{ "__sk_buff", "sk_buff", BPF_PROG_TYPE_CGROUP_SKB, BPF_CGROUP_INET_INGRESS },
+		{ "__sk_buff", "sk_buff", BPF_PROG_TYPE_SCHED_CLS },
 		{ "bpf_sock", "sock", BPF_PROG_TYPE_CGROUP_SOCK, BPF_CGROUP_INET4_POST_BIND },
 		{ "bpf_sock_addr", "bpf_sock_addr_kern",  BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_BIND },
 		{ "bpf_sock_ops", "bpf_sock_ops_kern", BPF_PROG_TYPE_SOCK_OPS, BPF_CGROUP_SOCK_OPS },
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Quoted 8 lines · On Thu, 30 Mar 2023 12:01:15 -0700 you wrote:

SCHED_CLS seems to be a better option as a default guess for freplace programs that have __sk_buff as a context type.

---
 tools/testing/selftests/bpf/veristat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [bpf-next] veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

    https://git.kernel.org/bpf/bpf-next/c/d816129530e7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html