Skip to contentSkip to conversation

bnxt_en: fix free-runnig PHC mode

PATCH Applied Vadim Fedorenko 4 participants 4 messages Apr 18, 2023 – Apr 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bnxt_en: fix free-runnig PHC mode

The patch in fixes changed the way real-time mode is chosen for PHC on the NIC. Apparently there is one more use case of the check outside of ptp part of the driver which was not converted to the new macro and is making a lot of noise in free-running mode.

Fixes 131db4991622 ("bnxt_en: reset PHC frequency in free-running mode")
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
index ef97a4190b39..651b79ce5d80 100644
@@ -2388,7 +2388,7 @@ static int bnxt_async_event_process(struct bnxt *bp,
 	case ASYNC_EVENT_CMPL_EVENT_ID_PHC_UPDATE: {
 		switch (BNXT_EVENT_PHC_EVENT_TYPE(data1)) {
 		case ASYNC_EVENT_CMPL_PHC_UPDATE_EVENT_DATA1_FLAGS_PHC_RTC_UPDATE:
-			if (bp->fw_cap & BNXT_FW_CAP_PTP_RTC) {
+			if (BNXT_PTP_USE_RTC(bp)) {
 				struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
 				u64 ns;
 
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Vadim Fedorenko

The patch in fixes changed the way real-time mode is chosen for PHC on the NIC. Apparently there is one more use case of the check outside of ptp part of the driver which was not converted to the new macro and is making a lot of noise in free-running mode.

Fixes 131db4991622 ("bnxt_en: reset PHC frequency in free-running mode")

Looks good to me. Please wait for Pavan to review it also. Thanks.

maintainer Reviewed-by
#2 lore raw
Quoted 8 lines · Michael Chan
Quoted 6 lines · Vadim Fedorenko

The patch in fixes changed the way real-time mode is chosen for PHC on the NIC. Apparently there is one more use case of the check outside of ptp part of the driver which was not converted to the new macro and is making a lot of noise in free-running mode.

Quoted 6 lines
Quoted 2 lines
Fixes 131db4991622 ("bnxt_en: reset PHC frequency in free-running mode")

Looks good to me. Please wait for Pavan to review it also. Thanks.

Looks good to me as well. Thanks.

#3 lore raw
In reply to Vadim Fedorenko
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 18 Apr 2023 13:25:11 -0700 you wrote:

The patch in fixes changed the way real-time mode is chosen for PHC on the NIC. Apparently there is one more use case of the check outside of ptp part of the driver which was not converted to the new macro and is making a lot of noise in free-running mode.

Fixes 131db4991622 ("bnxt_en: reset PHC frequency in free-running mode")

[...]

Here is the summary with links:
- [net] bnxt_en: fix free-runnig PHC mode

    https://git.kernel.org/netdev/net/c/8c154d272c3e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html