Skip to contentSkip to conversation

dt-bindings: net: ethernet: Fix JSON pointer references

PATCH Applied Rob Herring 2 participants 2 messages Apr 18, 2023 – Apr 20, 2023

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: ethernet: Fix JSON pointer references

A JSON pointer reference (the part after the "#") must start with a "/". Conversely, references to the entire document must not have a trailing "/" and should be just a "#". The existing jsonschema package allows these, but coming changes make allowed "$ref" URIs stricter and throw errors on these references.

---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 +-
 Documentation/devicetree/bindings/net/ethernet-switch.yaml     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/ethernet-controller.yaml +1 -1
index 00be387984ac..b7ac69dafbe9 100644
@@ -205,7 +205,7 @@ properties:
               duplex is assumed.
 
           pause:
-            $ref: /schemas/types.yaml#definitions/flag
+            $ref: /schemas/types.yaml#/definitions/flag
             description:
               Indicates that pause should be enabled.
 
Documentation/devicetree/bindings/net/ethernet-switch.yaml +1 -1
index a04f8ef744aa..3a9bac7b1b98 100644
@@ -51,7 +51,7 @@ additionalProperties: true
 $defs:
   base:
     description: An ethernet switch without any extra port properties
-    $ref: '#/'
+    $ref: '#'
 
     patternProperties:
       "^(ethernet-)?port@[0-9]+$":
Signature · 1 line
2.39.2
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 18 Apr 2023 10:06:27 -0500 you wrote:

A JSON pointer reference (the part after the "#") must start with a "/". Conversely, references to the entire document must not have a trailing "/" and should be just a "#". The existing jsonschema package allows these, but coming changes make allowed "$ref" URIs stricter and throw errors on these references.

[...]

Here is the summary with links:
- dt-bindings: net: ethernet: Fix JSON pointer references

    https://git.kernel.org/netdev/net-next/c/84ce730f82df

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html