Skip to contentSkip to conversation

ip: bridge_slave: Fix help message indentation

PATCH Applied Ido Schimmel 3 participants 3 messages Apr 19, 2023 – Apr 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ip: bridge_slave: Fix help message indentation

Use tabs instead of spaces to be consistent with the rest of the options.

Before:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                       [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]

After:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                        [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]
Fixes 05f1164fe811 ("bridge: link: Add MAC Authentication Bypass (MAB) support")
---
 ip/iplink_bridge_slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ip/iplink_bridge_slave.c +1 -1
index 43b429485502..66a67961957f 100644
@@ -40,7 +40,7 @@ static void print_explain(FILE *f)
 		"			[ vlan_tunnel {on | off} ]\n"
 		"			[ isolated {on | off} ]\n"
 		"			[ locked {on | off} ]\n"
-		"                       [ mab {on | off} ]\n"
+		"			[ mab {on | off} ]\n"
 		"			[ backup_port DEVICE ] [ nobackup_port ]\n"
 	);
 }
Signature · 1 line
2.37.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Ido Schimmel

Use tabs instead of spaces to be consistent with the rest of the options.

Before:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                       [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]

After:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                        [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]
Quoted 2 lines
Fixes 05f1164fe811 ("bridge: link: Add MAC Authentication Bypass (MAB) support")
#2 lore raw
In reply to Ido Schimmel
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Quoted 14 lines · On Wed, 19 Apr 2023 18:43:59 +0300 you wrote:

Use tabs instead of spaces to be consistent with the rest of the options.

Before:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                       [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]
Quoted 1 line

[...]

Here is the summary with links:
- [iproute2] ip: bridge_slave: Fix help message indentation

    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ed328120f47a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html